Doctrine\Migrations\Tools\Console\Command\ExecuteCommand::execute()

Complexity

Conditions	9
Paths	12

Size

Total Lines	55
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	29
CRAP Score	9.1442

Importance

Changes

0

<?php
    protected function execute(InputInterface $input, OutputInterface $output) : int
    {
        $versions  = $input->getArgument('versions');
        $path      = $input->getOption('write-sql');
        $direction = $input->getOption('down') !== false
            ? Direction::DOWN
            : Direction::UP;

        $migrator       = $this->getDependencyFactory()->getMigrator();
        $planCalculator = $this->getDependencyFactory()->getMigrationPlanCalculator();
        $plan           = $planCalculator->getPlanForVersions(array_map(static function (string $version) : Version {
            return new Version($version);
        }, $versions), $direction);

It seems like $versions can also be of type null and string; however, parameter $arr1 of array_map() does only seem to accept array, maybe add an additional type check?

        $migratorConfigurationFactory = $this->getDependencyFactory()->getConsoleInputMigratorConfigurationFactory();
        $migratorConfiguration        = $migratorConfigurationFactory->getMigratorConfiguration($input);

        if ($path !== false) {
            $migratorConfiguration->setDryRun(true);
            $sql = $migrator->migrate($plan, $migratorConfiguration);

            $path = is_string($path) ? $path : getcwd();

            if (! is_string($path) || ! is_writable($path)) {

The condition is_string($path) is always true.

                $this->io->error('Path not writeable!');

                return 1;
            }

            $writer = $this->getDependencyFactory()->getQueryWriter();
            $writer->write($path, $direction, $sql);

            return 0;
        }

        $question = 'WARNING! You are about to execute a database migration that could result in schema changes and data lost. Are you sure you wish to continue?';

        if (! $migratorConfiguration->isDryRun() && ! $this->canExecute($question, $input)) {
            $this->io->error('Migration cancelled!');

            return 1;
        }

        $this->getDependencyFactory()->getMetadataStorage()->ensureInitialized();

        $this->getDependencyFactory()->getLogger()->notice(
            'Executing' . ($migratorConfiguration->isDryRun() ? ' (dry-run)' : '') . ' {versions} {direction}',
            [
                'direction' => $plan->getDirection(),
                'versions' => implode(', ', $versions),

It seems like $versions can also be of type null and string; however, parameter $pieces of implode() does only seem to accept array, maybe add an additional type check?

            ]
        );
        $migrator->migrate($plan, $migratorConfiguration);

        return 0;
    }