MysqliConnectionTest::testRestoresErrorHandlerOnException() - Code Metrics - Inspection of "Removed ServerInfoAwareConnection#requiresQueryFor..." - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3807)

by Sergei

created 2020-01-03 05:31 UTC

testRestoresErrorHandlerOnException() A

↳ Parent: MysqliConnectionTest

Complexity

Conditions	2
Paths	3

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	10
dl	0
loc	17
rs	9.9332
c	0
b	0
f	0
cc	2
nc	3
nop	0

<?php

declare(strict_types=1);

namespace Doctrine\Tests\DBAL\Driver\Mysqli;

use Doctrine\DBAL\Driver\Mysqli\Exception\ConnectionError;
use Doctrine\DBAL\Driver\Mysqli\MysqliConnection;
use Doctrine\DBAL\Platforms\MySqlPlatform;
use Doctrine\Tests\DbalFunctionalTestCase;
use PHPUnit\Framework\MockObject\MockObject;
use function extension_loaded;
use function restore_error_handler;
use function set_error_handler;

class MysqliConnectionTest extends DbalFunctionalTestCase
{
    /**
     * The mysqli driver connection mock under test.
     *
     * @var MysqliConnection|MockObject
     */
    private $connectionMock;

    protected function setUp() : void
    {
        if (! extension_loaded('mysqli')) {
            $this->markTestSkipped('mysqli is not installed.');
        }

        parent::setUp();

        if (! $this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
            $this->markTestSkipped('MySQL only test.');
        }

        $this->connectionMock = $this->getMockBuilder(MysqliConnection::class)
            ->disableOriginalConstructor()
            ->getMockForAbstractClass();
    }

    public function testRestoresErrorHandlerOnException() : void
    {
        $handler         = static function () : bool {
            self::fail('Never expected this to be called');
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
        };
        $default_handler = set_error_handler($handler);


        try {
            new MysqliConnection(['host' => '255.255.255.255'], 'user', 'pass');
            self::fail('An exception was supposed to be raised');
        } catch (ConnectionError $e) {
            // Do nothing
        }

        self::assertSame($handler, set_error_handler($handler), 'Restoring error handler failed.');
        restore_error_handler();
        restore_error_handler();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Doctrine\Tests\DBAL\Driver\Mysqli;
6
7			use Doctrine\DBAL\Driver\Mysqli\Exception\ConnectionError;
8			use Doctrine\DBAL\Driver\Mysqli\MysqliConnection;
9			use Doctrine\DBAL\Platforms\MySqlPlatform;
10			use Doctrine\Tests\DbalFunctionalTestCase;
11			use PHPUnit\Framework\MockObject\MockObject;
12			use function extension_loaded;
13			use function restore_error_handler;
14			use function set_error_handler;
15
16			class MysqliConnectionTest extends DbalFunctionalTestCase
17			{
18			/**
19			* The mysqli driver connection mock under test.
20			*
21			* @var MysqliConnection\|MockObject
22			*/
23			private $connectionMock;
24
25			protected function setUp() : void
26			{
27			if (! extension_loaded('mysqli')) {
28			$this->markTestSkipped('mysqli is not installed.');
29			}
30
31			parent::setUp();
32
33			if (! $this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
34			$this->markTestSkipped('MySQL only test.');
35			}
36
37			$this->connectionMock = $this->getMockBuilder(MysqliConnection::class)
38			->disableOriginalConstructor()
39			->getMockForAbstractClass();
40			}
41
42			public function testRestoresErrorHandlerOnException() : void
43			{
44			$handler = static function () : bool {
45			self::fail('Never expected this to be called');
			0 ignored issues – show Bug Best Practice introduced 2019-08-27 06:10 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `boolean`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
46			};
47			$default_handler = set_error_handler($handler);
			0 ignored issues – show Unused Code introduced 2019-05-31 21:57 UTC by Report Bug Copy Issue Report The assignment to `$default_handler` is dead and can be removed. Loading history...
48
49			try {
50			new MysqliConnection(['host' => '255.255.255.255'], 'user', 'pass');
51			self::fail('An exception was supposed to be raised');
52			} catch (ConnectionError $e) {
53			// Do nothing
54			}
55
56			self::assertSame($handler, set_error_handler($handler), 'Restoring error handler failed.');
57			restore_error_handler();
58			restore_error_handler();
59			}
60			}
61

doctrine / dbal

Pull Request — master (#3807)

testRestoresErrorHandlerOnException() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like