Completed
Pull Request — master (#3756)
by Sergei
62:43
created

AbstractSQLServerDriver::createDatabasePlatformForVersion()   A

Complexity

Conditions 3
Paths 3

Size

Total Lines 24
Code Lines 17

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 17
CRAP Score 3

Importance

Changes 0
Metric Value
eloc 17
dl 0
loc 24
ccs 17
cts 17
cp 1
rs 9.7
c 0
b 0
f 0
cc 3
nc 3
nop 1
crap 3

1 Method

Rating   Name   Duplication   Size   Complexity  
A AbstractSQLServerDriver::getSchemaManager() 0 3 1
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Doctrine\DBAL\Driver;
6
7
use Doctrine\DBAL\Connection;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Doctrine\DBAL\Driver\Connection. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
8
use Doctrine\DBAL\Driver;
9
use Doctrine\DBAL\Platforms\AbstractPlatform;
10
use Doctrine\DBAL\Platforms\SQLServerPlatform;
11
use Doctrine\DBAL\Schema\AbstractSchemaManager;
12
use Doctrine\DBAL\Schema\SQLServerSchemaManager;
13
14
/**
15
 * Abstract base implementation of the {@link Doctrine\DBAL\Driver} interface for Microsoft SQL Server based drivers.
16
 */
17
abstract class AbstractSQLServerDriver implements Driver
18
{
19
    /**
20
     * {@inheritdoc}
21
     */
22
    public function getDatabasePlatform() : AbstractPlatform
23
    {
24
        return new SQLServerPlatform();
25 542
    }
26
27 542
    /**
28 12
     * {@inheritdoc}
29 542
     */
30 542
    public function getSchemaManager(Connection $conn) : AbstractSchemaManager
31
    {
32 511
        return new SQLServerSchemaManager($conn);
33 511
    }
34
}
35