ConvertPositionalToNamedPlaceholdersTest::positionalToNamedPlaceholdersProvider() - Code Metrics - Inspection of "Made the OCI8Statement class final" - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3820)

by Sergei

created 2020-01-12 20:21 UTC

positionalToNamedPlaceholdersProvider() A

↳ Parent: ConvertPositionalToNamedPlaceholdersTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	52
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	31
dl	0
loc	52
rs	9.424
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace Doctrine\Tests\DBAL\Driver\OCI8;

use Doctrine\DBAL\Driver\OCI8\ConvertPositionalToNamedPlaceholders;
use Doctrine\DBAL\Driver\OCI8\OCI8Exception;
use Doctrine\Tests\DbalTestCase;

class ConvertPositionalToNamedPlaceholdersTest extends DbalTestCase
{
    /** @var ConvertPositionalToNamedPlaceholders */
    private $convertPositionalToNamedPlaceholders;

    protected function setUp() : void
    {
        $this->convertPositionalToNamedPlaceholders = new ConvertPositionalToNamedPlaceholders();
    }

    /**
     * @param mixed[] $expectedOutputParamsMap
     *
     * @dataProvider positionalToNamedPlaceholdersProvider
     */
    public function testConvertPositionalToNamedParameters(string $inputSQL, string $expectedOutputSQL, array $expectedOutputParamsMap) : void
    {
        [$statement, $params] = ($this->convertPositionalToNamedPlaceholders)($inputSQL);

        self::assertEquals($expectedOutputSQL, $statement);
        self::assertEquals($expectedOutputParamsMap, $params);
    }

    /**
     * @return mixed[][]
     */
    public static function positionalToNamedPlaceholdersProvider() : iterable
    {
        return [
            [
                'SELECT name FROM users WHERE id = ?',
                'SELECT name FROM users WHERE id = :param1',
                [1 => ':param1'],
            ],
            [
                'SELECT name FROM users WHERE id = ? AND status = ?',
                'SELECT name FROM users WHERE id = :param1 AND status = :param2',
                [1 => ':param1', 2 => ':param2'],
            ],
            [
                "UPDATE users SET name = '???', status = ?",
                "UPDATE users SET name = '???', status = :param1",
                [1 => ':param1'],
            ],
            [
                "UPDATE users SET status = ?, name = '???'",
                "UPDATE users SET status = :param1, name = '???'",
                [1 => ':param1'],
            ],
            [
                "UPDATE users SET foo = ?, name = '???', status = ?",
                "UPDATE users SET foo = :param1, name = '???', status = :param2",
                [1 => ':param1', 2 => ':param2'],
            ],
            [
                'UPDATE users SET name = "???", status = ?',
                'UPDATE users SET name = "???", status = :param1',
                [1 => ':param1'],
            ],
            [
                'UPDATE users SET status = ?, name = "???"',
                'UPDATE users SET status = :param1, name = "???"',
                [1 => ':param1'],
            ],
            [
                'UPDATE users SET foo = ?, name = "???", status = ?',
                'UPDATE users SET foo = :param1, name = "???", status = :param2',
                [1 => ':param1', 2 => ':param2'],
            ],
            [
                'SELECT * FROM users WHERE id = ? AND name = "" AND status = ?',
                'SELECT * FROM users WHERE id = :param1 AND name = "" AND status = :param2',
                [1 => ':param1', 2 => ':param2'],
            ],
            [
                "SELECT * FROM users WHERE id = ? AND name = '' AND status = ?",
                "SELECT * FROM users WHERE id = :param1 AND name = '' AND status = :param2",
                [1 => ':param1', 2 => ':param2'],
            ],
        ];
    }

    /**
     * @dataProvider nonTerminatedLiteralProvider
     */
    public function testConvertNonTerminatedLiteral(string $sql, string $expectedExceptionMessageRegExp) : void
    {
        $this->expectException(OCI8Exception::class);
        $this->expectExceptionMessageMatches($expectedExceptionMessageRegExp);
        ($this->convertPositionalToNamedPlaceholders)($sql);
    }

    /**
     * @return array<string, array<int, mixed>>
     */
    public static function nonTerminatedLiteralProvider() : iterable
    {
        return [
            'no-matching-quote' => [
                "SELECT 'literal FROM DUAL",
                '/offset 7./',
            ],
            'no-matching-double-quote' => [
                'SELECT 1 "COL1 FROM DUAL',
                '/offset 9./',
            ],
            'incorrect-escaping-syntax' => [
                "SELECT 'quoted \\'string' FROM DUAL",
                '/offset 23./',
            ],
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Doctrine\Tests\DBAL\Driver\OCI8;
6
7			use Doctrine\DBAL\Driver\OCI8\ConvertPositionalToNamedPlaceholders;
8			use Doctrine\DBAL\Driver\OCI8\OCI8Exception;
9			use Doctrine\Tests\DbalTestCase;
10
11			class ConvertPositionalToNamedPlaceholdersTest extends DbalTestCase
12			{
13			/** @var ConvertPositionalToNamedPlaceholders */
14			private $convertPositionalToNamedPlaceholders;
15
16			protected function setUp() : void
17			{
18			$this->convertPositionalToNamedPlaceholders = new ConvertPositionalToNamedPlaceholders();
19			}
20
21			/**
22			* @param mixed[] $expectedOutputParamsMap
23			*
24			* @dataProvider positionalToNamedPlaceholdersProvider
25			*/
26			public function testConvertPositionalToNamedParameters(string $inputSQL, string $expectedOutputSQL, array $expectedOutputParamsMap) : void
27			{
28			[$statement, $params] = ($this->convertPositionalToNamedPlaceholders)($inputSQL);
29
30			self::assertEquals($expectedOutputSQL, $statement);
31			self::assertEquals($expectedOutputParamsMap, $params);
32			}
33
34			/**
35			* @return mixed[][]
36			*/
37			public static function positionalToNamedPlaceholdersProvider() : iterable
38			{
39			return [
40			[
41			'SELECT name FROM users WHERE id = ?',
42			'SELECT name FROM users WHERE id = :param1',
43			[1 => ':param1'],
44			],
45			[
46			'SELECT name FROM users WHERE id = ? AND status = ?',
47			'SELECT name FROM users WHERE id = :param1 AND status = :param2',
48			[1 => ':param1', 2 => ':param2'],
49			],
50			[
51			"UPDATE users SET name = '???', status = ?",
52			"UPDATE users SET name = '???', status = :param1",
53			[1 => ':param1'],
54			],
55			[
56			"UPDATE users SET status = ?, name = '???'",
57			"UPDATE users SET status = :param1, name = '???'",
58			[1 => ':param1'],
59			],
60			[
61			"UPDATE users SET foo = ?, name = '???', status = ?",
62			"UPDATE users SET foo = :param1, name = '???', status = :param2",
63			[1 => ':param1', 2 => ':param2'],
64			],
65			[
66			'UPDATE users SET name = "???", status = ?',
67			'UPDATE users SET name = "???", status = :param1',
68			[1 => ':param1'],
69			],
70			[
71			'UPDATE users SET status = ?, name = "???"',
72			'UPDATE users SET status = :param1, name = "???"',
73			[1 => ':param1'],
74			],
75			[
76			'UPDATE users SET foo = ?, name = "???", status = ?',
77			'UPDATE users SET foo = :param1, name = "???", status = :param2',
78			[1 => ':param1', 2 => ':param2'],
79			],
80			[
81			'SELECT * FROM users WHERE id = ? AND name = "" AND status = ?',
82			'SELECT * FROM users WHERE id = :param1 AND name = "" AND status = :param2',
83			[1 => ':param1', 2 => ':param2'],
84			],
85			[
86			"SELECT * FROM users WHERE id = ? AND name = '' AND status = ?",
87			"SELECT * FROM users WHERE id = :param1 AND name = '' AND status = :param2",
88			[1 => ':param1', 2 => ':param2'],
89			],
90			];
91			}
92
93			/**
94			* @dataProvider nonTerminatedLiteralProvider
95			*/
96			public function testConvertNonTerminatedLiteral(string $sql, string $expectedExceptionMessageRegExp) : void
97			{
98			$this->expectException(OCI8Exception::class);
99			$this->expectExceptionMessageMatches($expectedExceptionMessageRegExp);
100			($this->convertPositionalToNamedPlaceholders)($sql);
101			}
102
103			/**
104			* @return array<string, array<int, mixed>>
105			*/
106			public static function nonTerminatedLiteralProvider() : iterable
107			{
108			return [
109			'no-matching-quote' => [
110			"SELECT 'literal FROM DUAL",
111			'/offset 7./',
112			],
113			'no-matching-double-quote' => [
114			'SELECT 1 "COL1 FROM DUAL',
115			'/offset 9./',
116			],
117			'incorrect-escaping-syntax' => [
118			"SELECT 'quoted \\'string' FROM DUAL",
119			'/offset 23./',
120			],
121			];
122			}
123			}
124

doctrine / dbal

Pull Request — master (#3820)

positionalToNamedPlaceholdersProvider() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like