| Conditions | 1 |
| Paths | 1 |
| Total Lines | 313 |
| Code Lines | 231 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 110 | public static function dataExpandListParameters() : iterable |
||
| 111 | { |
||
| 112 | return [ |
||
| 113 | 'Positional: Very simple with one needle' => [ |
||
| 114 | 'SELECT * FROM Foo WHERE foo IN (?)', |
||
| 115 | [[1, 2, 3]], |
||
| 116 | [Connection::PARAM_INT_ARRAY], |
||
| 117 | 'SELECT * FROM Foo WHERE foo IN (?, ?, ?)', |
||
| 118 | [1, 2, 3], |
||
| 119 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER], |
||
| 120 | ], |
||
| 121 | 'Positional: One non-list before d one after list-needle' => [ |
||
| 122 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?)', |
||
| 123 | ['string', [1, 2, 3]], |
||
| 124 | [ParameterType::STRING, Connection::PARAM_INT_ARRAY], |
||
| 125 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?, ?, ?)', |
||
| 126 | ['string', 1, 2, 3], |
||
| 127 | [ParameterType::STRING, ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER], |
||
| 128 | ], |
||
| 129 | 'Positional: One non-list after list-needle' => [ |
||
| 130 | 'SELECT * FROM Foo WHERE bar IN (?) AND baz = ?', |
||
| 131 | [[1, 2, 3], 'foo'], |
||
| 132 | [Connection::PARAM_INT_ARRAY, ParameterType::STRING], |
||
| 133 | 'SELECT * FROM Foo WHERE bar IN (?, ?, ?) AND baz = ?', |
||
| 134 | [1, 2, 3, 'foo'], |
||
| 135 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::STRING], |
||
| 136 | ], |
||
| 137 | 'Positional: One non-list before and one after list-needle' => [ |
||
| 138 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?) AND baz = ?', |
||
| 139 | [1, [1, 2, 3], 4], |
||
| 140 | [ParameterType::INTEGER, Connection::PARAM_INT_ARRAY, ParameterType::INTEGER], |
||
| 141 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?, ?, ?) AND baz = ?', |
||
| 142 | [1, 1, 2, 3, 4], |
||
| 143 | [ |
||
| 144 | ParameterType::INTEGER, |
||
| 145 | ParameterType::INTEGER, |
||
| 146 | ParameterType::INTEGER, |
||
| 147 | ParameterType::INTEGER, |
||
| 148 | ParameterType::INTEGER, |
||
| 149 | ], |
||
| 150 | ], |
||
| 151 | 'Positional: Two lists' => [ |
||
| 152 | 'SELECT * FROM Foo WHERE foo IN (?, ?)', |
||
| 153 | [[1, 2, 3], [4, 5]], |
||
| 154 | [Connection::PARAM_INT_ARRAY, Connection::PARAM_INT_ARRAY], |
||
| 155 | 'SELECT * FROM Foo WHERE foo IN (?, ?, ?, ?, ?)', |
||
| 156 | [1, 2, 3, 4, 5], |
||
| 157 | [ |
||
| 158 | ParameterType::INTEGER, |
||
| 159 | ParameterType::INTEGER, |
||
| 160 | ParameterType::INTEGER, |
||
| 161 | ParameterType::INTEGER, |
||
| 162 | ParameterType::INTEGER, |
||
| 163 | ], |
||
| 164 | ], |
||
| 165 | 'Positional: Empty "integer" array (DDC-1978)' => [ |
||
| 166 | 'SELECT * FROM Foo WHERE foo IN (?)', |
||
| 167 | [[]], |
||
| 168 | [Connection::PARAM_INT_ARRAY], |
||
| 169 | 'SELECT * FROM Foo WHERE foo IN (NULL)', |
||
| 170 | [], |
||
| 171 | [], |
||
| 172 | ], |
||
| 173 | 'Positional: Empty "str" array (DDC-1978)' => [ |
||
| 174 | 'SELECT * FROM Foo WHERE foo IN (?)', |
||
| 175 | [[]], |
||
| 176 | [Connection::PARAM_STR_ARRAY], |
||
| 177 | 'SELECT * FROM Foo WHERE foo IN (NULL)', |
||
| 178 | [], |
||
| 179 | [], |
||
| 180 | ], |
||
| 181 | 'Positional: explicit keys for params and types' => [ |
||
| 182 | 'SELECT * FROM Foo WHERE foo = ? AND bar = ? AND baz = ?', |
||
| 183 | [1 => 'bar', 2 => 'baz', 0 => 1], |
||
| 184 | [2 => ParameterType::STRING, 1 => ParameterType::STRING], |
||
| 185 | 'SELECT * FROM Foo WHERE foo = ? AND bar = ? AND baz = ?', |
||
| 186 | [1 => 'bar', 0 => 1, 2 => 'baz'], |
||
| 187 | [1 => ParameterType::STRING, 2 => ParameterType::STRING, 0 => null], |
||
| 188 | ], |
||
| 189 | 'Positional: explicit keys for array params and array types' => [ |
||
| 190 | 'SELECT * FROM Foo WHERE foo IN (?) AND bar IN (?) AND baz = ?', |
||
| 191 | [1 => ['bar1', 'bar2'], 2 => true, 0 => [1, 2, 3]], |
||
| 192 | [2 => ParameterType::BOOLEAN, 1 => Connection::PARAM_STR_ARRAY, 0 => Connection::PARAM_INT_ARRAY], |
||
| 193 | 'SELECT * FROM Foo WHERE foo IN (?, ?, ?) AND bar IN (?, ?) AND baz = ?', |
||
| 194 | [1, 2, 3, 'bar1', 'bar2', true], |
||
| 195 | [ |
||
| 196 | ParameterType::INTEGER, |
||
| 197 | ParameterType::INTEGER, |
||
| 198 | ParameterType::INTEGER, |
||
| 199 | ParameterType::STRING, |
||
| 200 | ParameterType::STRING, |
||
| 201 | ParameterType::BOOLEAN, |
||
| 202 | ], |
||
| 203 | ], |
||
| 204 | 'Positional starts from 1: One non-list before and one after list-needle' => [ |
||
| 205 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?) AND baz = ? AND foo IN (?)', |
||
| 206 | [1 => 1, 2 => [1, 2, 3], 3 => 4, 4 => [5, 6]], |
||
| 207 | [ |
||
| 208 | 1 => ParameterType::INTEGER, |
||
| 209 | 2 => Connection::PARAM_INT_ARRAY, |
||
| 210 | 3 => ParameterType::INTEGER, |
||
| 211 | 4 => Connection::PARAM_INT_ARRAY, |
||
| 212 | ], |
||
| 213 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?, ?, ?) AND baz = ? AND foo IN (?, ?)', |
||
| 214 | [1, 1, 2, 3, 4, 5, 6], |
||
| 215 | [ |
||
| 216 | ParameterType::INTEGER, |
||
| 217 | ParameterType::INTEGER, |
||
| 218 | ParameterType::INTEGER, |
||
| 219 | ParameterType::INTEGER, |
||
| 220 | ParameterType::INTEGER, |
||
| 221 | ParameterType::INTEGER, |
||
| 222 | ParameterType::INTEGER, |
||
| 223 | ], |
||
| 224 | ], |
||
| 225 | 'Named: Very simple with param int' => [ |
||
| 226 | 'SELECT * FROM Foo WHERE foo = :foo', |
||
| 227 | ['foo' => 1], |
||
| 228 | ['foo' => ParameterType::INTEGER], |
||
| 229 | 'SELECT * FROM Foo WHERE foo = ?', |
||
| 230 | [1], |
||
| 231 | [ParameterType::INTEGER], |
||
| 232 | ], |
||
| 233 | 'Named: Very simple with param int and string' => [ |
||
| 234 | 'SELECT * FROM Foo WHERE foo = :foo AND bar = :bar', |
||
| 235 | ['bar' => 'Some String','foo' => 1], |
||
| 236 | ['foo' => ParameterType::INTEGER, 'bar' => ParameterType::STRING], |
||
| 237 | 'SELECT * FROM Foo WHERE foo = ? AND bar = ?', |
||
| 238 | [1,'Some String'], |
||
| 239 | [ParameterType::INTEGER, ParameterType::STRING], |
||
| 240 | ], |
||
| 241 | 'Named: Very simple with one needle' => [ |
||
| 242 | 'SELECT * FROM Foo WHERE foo IN (:foo)', |
||
| 243 | ['foo' => [1, 2, 3]], |
||
| 244 | ['foo' => Connection::PARAM_INT_ARRAY], |
||
| 245 | 'SELECT * FROM Foo WHERE foo IN (?, ?, ?)', |
||
| 246 | [1, 2, 3], |
||
| 247 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER], |
||
| 248 | ], |
||
| 249 | 'Named: One non-list before d one after list-needle' => [ |
||
| 250 | 'SELECT * FROM Foo WHERE foo = :foo AND bar IN (:bar)', |
||
| 251 | ['foo' => 'string', 'bar' => [1, 2, 3]], |
||
| 252 | ['foo' => ParameterType::STRING, 'bar' => Connection::PARAM_INT_ARRAY], |
||
| 253 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?, ?, ?)', |
||
| 254 | ['string', 1, 2, 3], |
||
| 255 | [ParameterType::STRING, ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER], |
||
| 256 | ], |
||
| 257 | 'Named: One non-list after list-needle' => [ |
||
| 258 | 'SELECT * FROM Foo WHERE bar IN (:bar) AND baz = :baz', |
||
| 259 | ['bar' => [1, 2, 3], 'baz' => 'foo'], |
||
| 260 | ['bar' => Connection::PARAM_INT_ARRAY, 'baz' => ParameterType::STRING], |
||
| 261 | 'SELECT * FROM Foo WHERE bar IN (?, ?, ?) AND baz = ?', |
||
| 262 | [1, 2, 3, 'foo'], |
||
| 263 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::STRING], |
||
| 264 | ], |
||
| 265 | 'Named: One non-list before and one after list-needle' => [ |
||
| 266 | 'SELECT * FROM Foo WHERE foo = :foo AND bar IN (:bar) AND baz = :baz', |
||
| 267 | ['bar' => [1, 2, 3],'foo' => 1, 'baz' => 4], |
||
| 268 | [ |
||
| 269 | 'bar' => Connection::PARAM_INT_ARRAY, |
||
| 270 | 'foo' => ParameterType::INTEGER, |
||
| 271 | 'baz' => ParameterType::INTEGER, |
||
| 272 | ], |
||
| 273 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?, ?, ?) AND baz = ?', |
||
| 274 | [1, 1, 2, 3, 4], |
||
| 275 | [ |
||
| 276 | ParameterType::INTEGER, |
||
| 277 | ParameterType::INTEGER, |
||
| 278 | ParameterType::INTEGER, |
||
| 279 | ParameterType::INTEGER, |
||
| 280 | ParameterType::INTEGER, |
||
| 281 | ], |
||
| 282 | ], |
||
| 283 | 'Named: Two lists' => [ |
||
| 284 | 'SELECT * FROM Foo WHERE foo IN (:a, :b)', |
||
| 285 | ['b' => [4, 5],'a' => [1, 2, 3]], |
||
| 286 | ['a' => Connection::PARAM_INT_ARRAY, 'b' => Connection::PARAM_INT_ARRAY], |
||
| 287 | 'SELECT * FROM Foo WHERE foo IN (?, ?, ?, ?, ?)', |
||
| 288 | [1, 2, 3, 4, 5], |
||
| 289 | [ |
||
| 290 | ParameterType::INTEGER, |
||
| 291 | ParameterType::INTEGER, |
||
| 292 | ParameterType::INTEGER, |
||
| 293 | ParameterType::INTEGER, |
||
| 294 | ParameterType::INTEGER, |
||
| 295 | ], |
||
| 296 | ], |
||
| 297 | 'Named: With the same name arg type string' => [ |
||
| 298 | 'SELECT * FROM Foo WHERE foo <> :arg AND bar = :arg', |
||
| 299 | ['arg' => 'Some String'], |
||
| 300 | ['arg' => ParameterType::STRING], |
||
| 301 | 'SELECT * FROM Foo WHERE foo <> ? AND bar = ?', |
||
| 302 | ['Some String','Some String'], |
||
| 303 | [ParameterType::STRING,ParameterType::STRING], |
||
| 304 | ], |
||
| 305 | 'Named: With the same name arg' => [ |
||
| 306 | 'SELECT * FROM Foo WHERE foo IN (:arg) AND NOT bar IN (:arg)', |
||
| 307 | ['arg' => [1, 2, 3]], |
||
| 308 | ['arg' => Connection::PARAM_INT_ARRAY], |
||
| 309 | 'SELECT * FROM Foo WHERE foo IN (?, ?, ?) AND NOT bar IN (?, ?, ?)', |
||
| 310 | [1, 2, 3, 1, 2, 3], |
||
| 311 | [ |
||
| 312 | ParameterType::INTEGER, |
||
| 313 | ParameterType::INTEGER, |
||
| 314 | ParameterType::INTEGER, |
||
| 315 | ParameterType::INTEGER, |
||
| 316 | ParameterType::INTEGER, |
||
| 317 | ParameterType::INTEGER, |
||
| 318 | ], |
||
| 319 | ], |
||
| 320 | 'Named: Same name, other name in between (DBAL-299)' => [ |
||
| 321 | 'SELECT * FROM Foo WHERE (:foo = 2) AND (:bar = 3) AND (:foo = 2)', |
||
| 322 | ['foo' => 2,'bar' => 3], |
||
| 323 | ['foo' => ParameterType::INTEGER,'bar' => ParameterType::INTEGER], |
||
| 324 | 'SELECT * FROM Foo WHERE (? = 2) AND (? = 3) AND (? = 2)', |
||
| 325 | [2, 3, 2], |
||
| 326 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER], |
||
| 327 | ], |
||
| 328 | 'Named: Empty "integer" array (DDC-1978)' => [ |
||
| 329 | 'SELECT * FROM Foo WHERE foo IN (:foo)', |
||
| 330 | ['foo' => []], |
||
| 331 | ['foo' => Connection::PARAM_INT_ARRAY], |
||
| 332 | 'SELECT * FROM Foo WHERE foo IN (NULL)', |
||
| 333 | [], |
||
| 334 | [], |
||
| 335 | ], |
||
| 336 | 'Named: Two empty "str" array (DDC-1978)' => [ |
||
| 337 | 'SELECT * FROM Foo WHERE foo IN (:foo) OR bar IN (:bar)', |
||
| 338 | ['foo' => [], 'bar' => []], |
||
| 339 | ['foo' => Connection::PARAM_STR_ARRAY, 'bar' => Connection::PARAM_STR_ARRAY], |
||
| 340 | 'SELECT * FROM Foo WHERE foo IN (NULL) OR bar IN (NULL)', |
||
| 341 | [], |
||
| 342 | [], |
||
| 343 | ], |
||
| 344 | [ |
||
| 345 | 'SELECT * FROM Foo WHERE foo IN (:foo) OR bar = :bar OR baz = :baz', |
||
| 346 | ['foo' => [1, 2], 'bar' => 'bar', 'baz' => 'baz'], |
||
| 347 | ['foo' => Connection::PARAM_INT_ARRAY, 'baz' => 'string'], |
||
| 348 | 'SELECT * FROM Foo WHERE foo IN (?, ?) OR bar = ? OR baz = ?', |
||
| 349 | [1, 2, 'bar', 'baz'], |
||
| 350 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::STRING, 'string'], |
||
| 351 | ], |
||
| 352 | [ |
||
| 353 | 'SELECT * FROM Foo WHERE foo IN (:foo) OR bar = :bar', |
||
| 354 | ['foo' => [1, 2], 'bar' => 'bar'], |
||
| 355 | ['foo' => Connection::PARAM_INT_ARRAY], |
||
| 356 | 'SELECT * FROM Foo WHERE foo IN (?, ?) OR bar = ?', |
||
| 357 | [1, 2, 'bar'], |
||
| 358 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::STRING], |
||
| 359 | ], |
||
| 360 | 'Params/types with colons' => [ |
||
| 361 | 'SELECT * FROM Foo WHERE foo = :foo OR bar = :bar', |
||
| 362 | [':foo' => 'foo', ':bar' => 'bar'], |
||
| 363 | [':foo' => ParameterType::INTEGER], |
||
| 364 | 'SELECT * FROM Foo WHERE foo = ? OR bar = ?', |
||
| 365 | ['foo', 'bar'], |
||
| 366 | [ParameterType::INTEGER, ParameterType::STRING], |
||
| 367 | ], |
||
| 368 | [ |
||
| 369 | 'SELECT * FROM Foo WHERE foo = :foo OR bar = :bar', |
||
| 370 | [':foo' => 'foo', ':bar' => 'bar'], |
||
| 371 | [':foo' => ParameterType::INTEGER, 'bar' => ParameterType::INTEGER], |
||
| 372 | 'SELECT * FROM Foo WHERE foo = ? OR bar = ?', |
||
| 373 | ['foo', 'bar'], |
||
| 374 | [ParameterType::INTEGER, ParameterType::INTEGER], |
||
| 375 | ], |
||
| 376 | [ |
||
| 377 | 'SELECT * FROM Foo WHERE foo IN (:foo) OR bar = :bar', |
||
| 378 | [':foo' => [1, 2], ':bar' => 'bar'], |
||
| 379 | ['foo' => Connection::PARAM_INT_ARRAY], |
||
| 380 | 'SELECT * FROM Foo WHERE foo IN (?, ?) OR bar = ?', |
||
| 381 | [1, 2, 'bar'], |
||
| 382 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::STRING], |
||
| 383 | ], |
||
| 384 | [ |
||
| 385 | 'SELECT * FROM Foo WHERE foo IN (:foo) OR bar = :bar', |
||
| 386 | ['foo' => [1, 2], 'bar' => 'bar'], |
||
| 387 | [':foo' => Connection::PARAM_INT_ARRAY], |
||
| 388 | 'SELECT * FROM Foo WHERE foo IN (?, ?) OR bar = ?', |
||
| 389 | [1, 2, 'bar'], |
||
| 390 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::STRING], |
||
| 391 | ], |
||
| 392 | 'Null valued parameters (DBAL-522)' => [ |
||
| 393 | 'INSERT INTO Foo (foo, bar) values (:foo, :bar)', |
||
| 394 | ['foo' => 1, 'bar' => null], |
||
| 395 | [':foo' => ParameterType::INTEGER, ':bar' => ParameterType::NULL], |
||
| 396 | 'INSERT INTO Foo (foo, bar) values (?, ?)', |
||
| 397 | [1, null], |
||
| 398 | [ParameterType::INTEGER, ParameterType::NULL], |
||
| 399 | ], |
||
| 400 | [ |
||
| 401 | 'INSERT INTO Foo (foo, bar) values (?, ?)', |
||
| 402 | [1, null], |
||
| 403 | [ParameterType::INTEGER, ParameterType::NULL], |
||
| 404 | 'INSERT INTO Foo (foo, bar) values (?, ?)', |
||
| 405 | [1, null], |
||
| 406 | [ParameterType::INTEGER, ParameterType::NULL], |
||
| 407 | ], |
||
| 408 | 'Escaped single quotes SQL- and C-Style (DBAL-1205)' => [ |
||
| 409 | "SELECT * FROM Foo WHERE foo = :foo||''':not_a_param''\\'' OR bar = ''':not_a_param''\\'':bar", |
||
| 410 | [':foo' => 1, ':bar' => 2], |
||
| 411 | [':foo' => ParameterType::INTEGER, 'bar' => ParameterType::INTEGER], |
||
| 412 | 'SELECT * FROM Foo WHERE foo = ?||\'\'\':not_a_param\'\'\\\'\' OR bar = \'\'\':not_a_param\'\'\\\'\'?', |
||
| 413 | [1, 2], |
||
| 414 | [ParameterType::INTEGER, ParameterType::INTEGER], |
||
| 415 | ], |
||
| 416 | [ |
||
| 417 | 'SELECT NULL FROM dummy WHERE ? IN (?)', |
||
| 418 | ['foo', ['bar', 'baz']], |
||
| 419 | [1 => Connection::PARAM_STR_ARRAY], |
||
| 420 | 'SELECT NULL FROM dummy WHERE ? IN (?, ?)', |
||
| 421 | ['foo', 'bar', 'baz'], |
||
| 422 | [null, ParameterType::STRING, ParameterType::STRING], |
||
| 423 | ], |
||
| 503 |