MySqlSchemaManagerTest::testNullColumnDefaultWithTable() - Code Metrics - Inspection of "Fix for Mariadb 10.2.7 default column value and nu..." - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#2825)

by Sébastien

created 2017-08-28 17:46 UTC

testNullColumnDefaultWithTable() A

↳ Parent: MySqlSchemaManagerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	50
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	1	Features	0

Metric	Value
c	4
b	1
f	0
dl	0
loc	50
rs	9.3333
cc	1
eloc	30
nc	1
nop	0

<?php

namespace Doctrine\Tests\DBAL\Functional\Schema;

use Doctrine\DBAL\Platforms\MySqlPlatform;
use Doctrine\DBAL\Schema\Comparator;
use Doctrine\DBAL\Schema\Schema;
use Doctrine\DBAL\Schema\Table;
use Doctrine\DBAL\Types\Type;

class MySqlSchemaManagerTest extends SchemaManagerFunctionalTestCase
{
    protected function setUp()
    {
        parent::setUp();

        if (!Type::hasType('point')) {
            Type::addType('point', 'Doctrine\Tests\Types\MySqlPointType');
        }
    }

    public function testSwitchPrimaryKeyColumns()
    {
        $tableOld = new Table("switch_primary_key_columns");
        $tableOld->addColumn('foo_id', 'integer');
        $tableOld->addColumn('bar_id', 'integer');
        $tableNew = clone $tableOld;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->_sm->createTable($tableOld);
        $tableFetched = $this->_sm->listTableDetails("switch_primary_key_columns");
        $tableNew = clone $tableFetched;
        $tableNew->setPrimaryKey(array('bar_id', 'foo_id'));

        $comparator = new Comparator;
        $this->_sm->alterTable($comparator->diffTable($tableFetched, $tableNew));

    }

    public function testDiffTableBug()
    {
        $schema = new Schema();
        $table = $schema->createTable('diffbug_routing_translations');
        $table->addColumn('id', 'integer');
        $table->addColumn('route', 'string');
        $table->addColumn('locale', 'string');
        $table->addColumn('attribute', 'string');
        $table->addColumn('localized_value', 'string');
        $table->addColumn('original_value', 'string');
        $table->setPrimaryKey(array('id'));
        $table->addUniqueIndex(array('route', 'locale', 'attribute'));
        $table->addIndex(array('localized_value')); // this is much more selective than the unique index

        $this->_sm->createTable($table);
        $tableFetched = $this->_sm->listTableDetails("diffbug_routing_translations");

        $comparator = new Comparator;
        $diff = $comparator->diffTable($tableFetched, $table);

        $this->assertFalse($diff, "no changes expected.");
    }

    public function testFulltextIndex()

    {
        $table = new Table('fulltext_index');
        $table->addColumn('text', 'text');
        $table->addIndex(array('text'), 'f_index');
        $table->addOption('engine', 'MyISAM');

        $index = $table->getIndex('f_index');
        $index->addFlag('fulltext');

        $this->_sm->dropAndCreateTable($table);

        $indexes = $this->_sm->listTableIndexes('fulltext_index');
        $this->assertArrayHasKey('f_index', $indexes);
        $this->assertTrue($indexes['f_index']->hasFlag('fulltext'));
    }

    public function testSpatialIndex()

    {
        $table = new Table('spatial_index');
        $table->addColumn('point', 'point');
        $table->addIndex(array('point'), 's_index');
        $table->addOption('engine', 'MyISAM');

        $index = $table->getIndex('s_index');
        $index->addFlag('spatial');

        $this->_sm->dropAndCreateTable($table);

        $indexes = $this->_sm->listTableIndexes('spatial_index');
        $this->assertArrayHasKey('s_index', $indexes);
        $this->assertTrue($indexes['s_index']->hasFlag('spatial'));
    }

    /**
     * @group DBAL-400
     */
    public function testAlterTableAddPrimaryKey()
    {
        $table = new Table('alter_table_add_pk');
        $table->addColumn('id', 'integer');
        $table->addColumn('foo', 'integer');
        $table->addIndex(array('id'), 'idx_id');

        $this->_sm->createTable($table);

        $comparator = new Comparator();
        $diffTable  = clone $table;

        $diffTable->dropIndex('idx_id');
        $diffTable->setPrimaryKey(array('id'));

        $this->_sm->alterTable($comparator->diffTable($table, $diffTable));


        $table = $this->_sm->listTableDetails("alter_table_add_pk");

        $this->assertFalse($table->hasIndex('idx_id'));
        $this->assertTrue($table->hasPrimaryKey());
    }

    /**
     * @group DBAL-464
     */
    public function testDropPrimaryKeyWithAutoincrementColumn()
    {
        $table = new Table("drop_primary_key");
        $table->addColumn('id', 'integer', array('primary' => true, 'autoincrement' => true));
        $table->addColumn('foo', 'integer', array('primary' => true));
        $table->setPrimaryKey(array('id', 'foo'));

        $this->_sm->dropAndCreateTable($table);

        $diffTable = clone $table;

        $diffTable->dropPrimaryKey();

        $comparator = new Comparator();

        $this->_sm->alterTable($comparator->diffTable($table, $diffTable));


        $table = $this->_sm->listTableDetails("drop_primary_key");

        $this->assertFalse($table->hasPrimaryKey());
        $this->assertFalse($table->getColumn('id')->getAutoincrement());
    }

    /**
     * @group DBAL-789
     */
    public function testDoesNotPropagateDefaultValuesForUnsupportedColumnTypes()
    {
        $table = new Table("text_blob_default_value");
        $table->addColumn('def_text', 'text', array('default' => 'def'));
        $table->addColumn('def_text_null', 'text', array('notnull' => false, 'default' => 'def'));
        $table->addColumn('def_blob', 'blob', array('default' => 'def'));
        $table->addColumn('def_blob_null', 'blob', array('notnull' => false, 'default' => 'def'));

        $this->_sm->dropAndCreateTable($table);

        $onlineTable = $this->_sm->listTableDetails("text_blob_default_value");

        $this->assertNull($onlineTable->getColumn('def_text')->getDefault());
        $this->assertNull($onlineTable->getColumn('def_text_null')->getDefault());
        $this->assertFalse($onlineTable->getColumn('def_text_null')->getNotnull());
        $this->assertNull($onlineTable->getColumn('def_blob')->getDefault());
        $this->assertNull($onlineTable->getColumn('def_blob_null')->getDefault());
        $this->assertFalse($onlineTable->getColumn('def_blob_null')->getNotnull());

        $comparator = new Comparator();

        $this->_sm->alterTable($comparator->diffTable($table, $onlineTable));


        $onlineTable = $this->_sm->listTableDetails("text_blob_default_value");

        $this->assertNull($onlineTable->getColumn('def_text')->getDefault());
        $this->assertNull($onlineTable->getColumn('def_text_null')->getDefault());
        $this->assertFalse($onlineTable->getColumn('def_text_null')->getNotnull());
        $this->assertNull($onlineTable->getColumn('def_blob')->getDefault());
        $this->assertNull($onlineTable->getColumn('def_blob_null')->getDefault());
        $this->assertFalse($onlineTable->getColumn('def_blob_null')->getNotnull());
    }

    public function testColumnCollation()

    {
        $table = new Table('test_collation');
        $table->addOption('collate', $collation = 'latin1_swedish_ci');
        $table->addOption('charset', 'latin1');
        $table->addColumn('id', 'integer');
        $table->addColumn('text', 'text');
        $table->addColumn('foo', 'text')->setPlatformOption('collation', 'latin1_swedish_ci');
        $table->addColumn('bar', 'text')->setPlatformOption('collation', 'utf8_general_ci');
        $this->_sm->dropAndCreateTable($table);

        $columns = $this->_sm->listTableColumns('test_collation');

        $this->assertArrayNotHasKey('collation', $columns['id']->getPlatformOptions());
        $this->assertEquals('latin1_swedish_ci', $columns['text']->getPlatformOption('collation'));
        $this->assertEquals('latin1_swedish_ci', $columns['foo']->getPlatformOption('collation'));
        $this->assertEquals('utf8_general_ci', $columns['bar']->getPlatformOption('collation'));
    }

    /**
     * @group DBAL-843
     */
    public function testListLobTypeColumns()
    {
        $tableName = 'lob_type_columns';
        $table = new Table($tableName);

        $table->addColumn('col_tinytext', 'text', array('length' => MySqlPlatform::LENGTH_LIMIT_TINYTEXT));
        $table->addColumn('col_text', 'text', array('length' => MySqlPlatform::LENGTH_LIMIT_TEXT));
        $table->addColumn('col_mediumtext', 'text', array('length' => MySqlPlatform::LENGTH_LIMIT_MEDIUMTEXT));
        $table->addColumn('col_longtext', 'text');

        $table->addColumn('col_tinyblob', 'text', array('length' => MySqlPlatform::LENGTH_LIMIT_TINYBLOB));
        $table->addColumn('col_blob', 'blob', array('length' => MySqlPlatform::LENGTH_LIMIT_BLOB));
        $table->addColumn('col_mediumblob', 'blob', array('length' => MySqlPlatform::LENGTH_LIMIT_MEDIUMBLOB));
        $table->addColumn('col_longblob', 'blob');

        $this->_sm->dropAndCreateTable($table);

        $platform = $this->_sm->getDatabasePlatform();
        $offlineColumns = $table->getColumns();
        $onlineColumns = $this->_sm->listTableColumns($tableName);

        $this->assertSame(
            $platform->getClobTypeDeclarationSQL($offlineColumns['col_tinytext']->toArray()),
            $platform->getClobTypeDeclarationSQL($onlineColumns['col_tinytext']->toArray())
        );
        $this->assertSame(
            $platform->getClobTypeDeclarationSQL($offlineColumns['col_text']->toArray()),
            $platform->getClobTypeDeclarationSQL($onlineColumns['col_text']->toArray())
        );
        $this->assertSame(
            $platform->getClobTypeDeclarationSQL($offlineColumns['col_mediumtext']->toArray()),
            $platform->getClobTypeDeclarationSQL($onlineColumns['col_mediumtext']->toArray())
        );
        $this->assertSame(
            $platform->getClobTypeDeclarationSQL($offlineColumns['col_longtext']->toArray()),
            $platform->getClobTypeDeclarationSQL($onlineColumns['col_longtext']->toArray())
        );

        $this->assertSame(
            $platform->getBlobTypeDeclarationSQL($offlineColumns['col_tinyblob']->toArray()),
            $platform->getBlobTypeDeclarationSQL($onlineColumns['col_tinyblob']->toArray())
        );
        $this->assertSame(
            $platform->getBlobTypeDeclarationSQL($offlineColumns['col_blob']->toArray()),
            $platform->getBlobTypeDeclarationSQL($onlineColumns['col_blob']->toArray())
        );
        $this->assertSame(
            $platform->getBlobTypeDeclarationSQL($offlineColumns['col_mediumblob']->toArray()),
            $platform->getBlobTypeDeclarationSQL($onlineColumns['col_mediumblob']->toArray())
        );
        $this->assertSame(
            $platform->getBlobTypeDeclarationSQL($offlineColumns['col_longblob']->toArray()),
            $platform->getBlobTypeDeclarationSQL($onlineColumns['col_longblob']->toArray())
        );
    }

    /**
     * @group DBAL-423
     */
    public function testDiffListGuidTableColumn()
    {
        $offlineTable = new Table('list_guid_table_column');
        $offlineTable->addColumn('col_guid', 'guid');

        $this->_sm->dropAndCreateTable($offlineTable);

        $onlineTable = $this->_sm->listTableDetails('list_guid_table_column');

        $comparator = new Comparator();

        $this->assertFalse(
            $comparator->diffTable($offlineTable, $onlineTable),
            "No differences should be detected with the offline vs online schema."
        );
    }

    /**
     * @group DBAL-1082
     */
    public function testListDecimalTypeColumns()

    {
        $tableName = 'test_list_decimal_columns';
        $table = new Table($tableName);

        $table->addColumn('col', 'decimal');
        $table->addColumn('col_unsigned', 'decimal', array('unsigned' => true));

        $this->_sm->dropAndCreateTable($table);

        $columns = $this->_sm->listTableColumns($tableName);

        $this->assertArrayHasKey('col', $columns);
        $this->assertArrayHasKey('col_unsigned', $columns);
        $this->assertFalse($columns['col']->getUnsigned());
        $this->assertTrue($columns['col_unsigned']->getUnsigned());
    }

    /**
     * @group DBAL-1082
     */
    public function testListFloatTypeColumns()

    {
        $tableName = 'test_list_float_columns';
        $table = new Table($tableName);

        $table->addColumn('col', 'float');
        $table->addColumn('col_unsigned', 'float', array('unsigned' => true));

        $this->_sm->dropAndCreateTable($table);

        $columns = $this->_sm->listTableColumns($tableName);

        $this->assertArrayHasKey('col', $columns);
        $this->assertArrayHasKey('col_unsigned', $columns);
        $this->assertFalse($columns['col']->getUnsigned());
        $this->assertTrue($columns['col_unsigned']->getUnsigned());
    }

    /**
     * Test default null values (especially for mariadb 10.2.7+)
     * @link https://github.com/doctrine/dbal/issues/2817
     */
    public function testNullColumnDefaultWithTable()
    {

        $table = new Table("test_column_defaults_with_table");
        $table->addColumn('col0', 'integer', ['notnull' => false]);
        $table->addColumn('col1', 'integer', ['notnull' => false, 'default' => null]);
        $table->addColumn('col2', 'string', ['notnull' => false, 'default' => null]);
        $table->addColumn('col3', 'string', ['notnull' => false, 'default' => 'NULL']);
        $table->addColumn('col4', 'string', ['notnull' => false, 'default' => 'Hello world']);
        $table->addColumn('col5', 'datetime', ['notnull' => false, 'default' => null]);
        $table->addColumn('col6', 'decimal', ['scale' => 3, 'precision' => 6, 'notnull' => false, 'default' => -2.3]);
        $table->addColumn('col7', 'date', ['notnull' => false, 'default' => '2012-12-12']);
        $table->addColumn('col8', 'string', ['notnull' => true, 'default' => '']);
        $table->addColumn('col9', 'integer', ['notnull' => false, 'default' => 0]);
        $table->addColumn('col10', 'string', ['notnull' => false, 'default' => 'He"ll"o world']);

        $this->_sm->dropAndCreateTable($table);

        $onlineTable = $this->_sm->listTableDetails("test_column_defaults_with_table");
        $this->assertNull($onlineTable->getColumn('col0')->getDefault());
        $this->assertNull($onlineTable->getColumn('col1')->getDefault());
        $this->assertNull($onlineTable->getColumn('col2')->getDefault());
        $this->assertEquals('NULL', $onlineTable->getColumn('col3')->getDefault());
        $this->assertEquals('Hello world', $onlineTable->getColumn('col4')->getDefault());
        $this->assertNull($onlineTable->getColumn('col5')->getDefault());
        $this->assertEquals(-2.3, $onlineTable->getColumn('col6')->getDefault());
        $this->assertEquals('2012-12-12', $onlineTable->getColumn('col7')->getDefault());
        $this->assertTrue($onlineTable->getColumn('col8')->getNotnull());
        $this->assertEquals('', $onlineTable->getColumn('col8')->getDefault());
        $this->assertEquals(0, $onlineTable->getColumn('col9')->getDefault());
        $this->assertEquals('He"ll"o world', $onlineTable->getColumn('col10')->getDefault());

        $comparator = new Comparator();

        $diff = $comparator->diffTable($table, $onlineTable);
        $this->assertFalse($diff, "Tables should be identical with column defaults");

        /*

        // For later tests, otherwise cleanup

        $this->_sm->alterTable($diff);

        $this->_sm->listTableDetails("text_null_default_value");

        $this->assertNull($onlineTable->getColumn('txt_def_null')->getDefault());
        $this->assertEquals('NULL', $onlineTable->getColumn('txt_def_null_as_string')->getDefault());
        $this->assertEquals('NULL', $onlineTable->getColumn('txt_def_null_as_quoted_string')->getDefault());
        $this->assertEquals('"NULL"', $onlineTable->getColumn('txt_def_null_as_doublequoted_string')->getDefault());
        */
    }

    /**
     * For testing MariaDB 10.2+ / MySQL differences
     */
    public function testColumnDefaultsWithCreate() {

        $this->_conn->query('DROP TABLE IF EXISTS `test_column_defaults_with_create`');
        $sql = sprintf("
            CREATE TABLE `test_column_defaults_with_create` (
                `col0` INT(11) NULL,
                `col1` INT(10) UNSIGNED NULL DEFAULT NULL,
                `col2` VARCHAR(10) CHARACTER SET UTF8MB4 COLLATE UTF8MB4_GENERAL_CI NULL DEFAULT NULL,
                `col3` VARCHAR(10) CHARACTER SET UTF8MB4 COLLATE UTF8MB4_GENERAL_CI NULL DEFAULT 'NULL',
                `col4` VARCHAR(20) NULL DEFAULT 'Hello world',
                `col5` DATETIME NULL DEFAULT NULL,
                `col6` DECIMAL(6, 3) NULL DEFAULT -2.3,
                `col7` DATE NULL DEFAULT '2012-12-12',
                `col8` VARCHAR(20) NOT NULL DEFAULT '',
                `col9` INT(11) NULL DEFAULT 0,
                `col10` VARCHAR(20) NULL DEFAULT '%s'                                                
                ) ENGINE=INNODB;
        ", 'He"ll"o world');

        $this->_conn->query($sql);
        $t = $this->_sm->listTableDetails("test_column_defaults_with_create");
        $this->assertNull($t->getColumn('col0')->getDefault());
        $this->assertNull($t->getColumn('col1')->getDefault());
        $this->assertNull($t->getColumn('col2')->getDefault());
        $this->assertEquals('NULL', $t->getColumn('col3')->getDefault());
        $this->assertEquals('Hello world', $t->getColumn('col4')->getDefault());
        $this->assertNull($t->getColumn('col5')->getDefault());
        $this->assertEquals(-2.3, $t->getColumn('col6')->getDefault());
        $this->assertEquals('2012-12-12', $t->getColumn('col7')->getDefault());
        $this->assertTrue($t->getColumn('col8')->getNotnull());
        $this->assertEquals('', $t->getColumn('col8')->getDefault());
        $this->assertEquals(0, $t->getColumn('col9')->getDefault());
        $this->assertEquals('He"ll"o world', $t->getColumn('col10')->getDefault());

        // @todo mariadb returns 'current_timestamp()'
        //   `col10` DATETIME NULL DEFAULT CURRENT_TIMESTAMP
        //    $this->assertEquals('current_timestamp', strtolower($t->getColumn('col10')->getDefault()));

    }

}


1			<?php
2
3			namespace Doctrine\Tests\DBAL\Functional\Schema;
4
5			use Doctrine\DBAL\Platforms\MySqlPlatform;
6			use Doctrine\DBAL\Schema\Comparator;
7			use Doctrine\DBAL\Schema\Schema;
8			use Doctrine\DBAL\Schema\Table;
9			use Doctrine\DBAL\Types\Type;
10
11			class MySqlSchemaManagerTest extends SchemaManagerFunctionalTestCase
12			{
13			protected function setUp()
14			{
15			parent::setUp();
16
17			if (!Type::hasType('point')) {
18			Type::addType('point', 'Doctrine\Tests\Types\MySqlPointType');
19			}
20			}
21
22			public function testSwitchPrimaryKeyColumns()
23			{
24			$tableOld = new Table("switch_primary_key_columns");
25			$tableOld->addColumn('foo_id', 'integer');
26			$tableOld->addColumn('bar_id', 'integer');
27			$tableNew = clone $tableOld;
			0 ignored issues – show Unused Code introduced 2017-06-29 19:35 UTC by Report Bug Copy Issue Report `$tableNew` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
28
29			$this->_sm->createTable($tableOld);
30			$tableFetched = $this->_sm->listTableDetails("switch_primary_key_columns");
31			$tableNew = clone $tableFetched;
32			$tableNew->setPrimaryKey(array('bar_id', 'foo_id'));
33
34			$comparator = new Comparator;
35			$this->_sm->alterTable($comparator->diffTable($tableFetched, $tableNew));
			0 ignored issues – show Security Bug introduced 2017-06-29 19:35 UTC by Report Bug Copy Issue Report It seems like `$comparator->diffTable($tableFetched, $tableNew)` targeting `Doctrine\DBAL\Schema\Comparator::diffTable()` can also be of type `false`; however, `Doctrine\DBAL\Schema\Abs...maManager::alterTable()` does only seem to accept `object<Doctrine\DBAL\Schema\TableDiff>`, did you maybe forget to handle an error condition? Loading history...
36			}
37
38			public function testDiffTableBug()

doctrine / dbal

Pull Request — master (#2825)

testNullColumnDefaultWithTable() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like