doctrine /
dbal
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like AbstractMySQLDriver often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractMySQLDriver, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 39 | abstract class AbstractMySQLDriver implements Driver, ExceptionConverterDriver, VersionAwarePlatformDriver |
||
| 40 | { |
||
| 41 | /** |
||
| 42 | * {@inheritdoc} |
||
| 43 | * |
||
| 44 | * @link http://dev.mysql.com/doc/refman/5.7/en/error-messages-client.html |
||
| 45 | * @link http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html |
||
| 46 | */ |
||
| 47 | 4 | public function convertException($message, DriverException $exception) |
|
| 48 | { |
||
| 49 | 4 | switch ($exception->getErrorCode()) { |
|
| 50 | 4 | case '1213': |
|
| 51 | 4 | return new Exception\DeadlockException($message, $exception); |
|
| 52 | 4 | case '1205': |
|
| 53 | 4 | return new Exception\LockWaitTimeoutException($message, $exception); |
|
| 54 | 4 | case '1050': |
|
| 55 | 4 | return new Exception\TableExistsException($message, $exception); |
|
| 56 | |||
| 57 | 4 | case '1051': |
|
| 58 | 4 | case '1146': |
|
| 59 | 4 | return new Exception\TableNotFoundException($message, $exception); |
|
| 60 | |||
| 61 | 4 | case '1216': |
|
| 62 | 4 | case '1217': |
|
| 63 | 4 | case '1451': |
|
| 64 | 4 | case '1452': |
|
| 65 | 4 | case '1701': |
|
| 66 | 4 | return new Exception\ForeignKeyConstraintViolationException($message, $exception); |
|
| 67 | |||
| 68 | 4 | case '1062': |
|
| 69 | 4 | case '1557': |
|
| 70 | 4 | case '1569': |
|
| 71 | 4 | case '1586': |
|
| 72 | 4 | return new Exception\UniqueConstraintViolationException($message, $exception); |
|
| 73 | |||
| 74 | 4 | case '1054': |
|
| 75 | 4 | case '1166': |
|
| 76 | 4 | case '1611': |
|
| 77 | 4 | return new Exception\InvalidFieldNameException($message, $exception); |
|
| 78 | |||
| 79 | 4 | case '1052': |
|
| 80 | 4 | case '1060': |
|
| 81 | 4 | case '1110': |
|
| 82 | 4 | return new Exception\NonUniqueFieldNameException($message, $exception); |
|
| 83 | |||
| 84 | 4 | case '1064': |
|
| 85 | 4 | case '1149': |
|
| 86 | 4 | case '1287': |
|
| 87 | 4 | case '1341': |
|
| 88 | 4 | case '1342': |
|
| 89 | 4 | case '1343': |
|
| 90 | 4 | case '1344': |
|
| 91 | 4 | case '1382': |
|
| 92 | 4 | case '1479': |
|
| 93 | 4 | case '1541': |
|
| 94 | 4 | case '1554': |
|
| 95 | 4 | case '1626': |
|
| 96 | 4 | return new Exception\SyntaxErrorException($message, $exception); |
|
| 97 | |||
| 98 | 4 | case '1044': |
|
| 99 | 4 | case '1045': |
|
| 100 | 4 | case '1046': |
|
| 101 | 4 | case '1049': |
|
| 102 | 4 | case '1095': |
|
| 103 | 4 | case '1142': |
|
| 104 | 4 | case '1143': |
|
| 105 | 4 | case '1227': |
|
| 106 | 4 | case '1370': |
|
| 107 | 4 | case '1429': |
|
| 108 | 4 | case '2002': |
|
| 109 | 4 | case '2005': |
|
| 110 | 4 | return new Exception\ConnectionException($message, $exception); |
|
| 111 | |||
| 112 | 4 | case '1048': |
|
| 113 | 4 | case '1121': |
|
| 114 | 4 | case '1138': |
|
| 115 | 4 | case '1171': |
|
| 116 | 4 | case '1252': |
|
| 117 | 4 | case '1263': |
|
| 118 | 4 | case '1364': |
|
| 119 | 4 | case '1566': |
|
| 120 | 4 | return new Exception\NotNullConstraintViolationException($message, $exception); |
|
| 121 | } |
||
| 122 | |||
| 123 | 4 | return new Exception\DriverException($message, $exception); |
|
| 124 | } |
||
| 125 | |||
| 126 | /** |
||
| 127 | * {@inheritdoc} |
||
| 128 | * |
||
| 129 | * @return AbstractPlatform |
||
| 130 | * @throws DBALException |
||
| 131 | */ |
||
| 132 | 6 | public function createDatabasePlatformForVersion($version) |
|
| 133 | { |
||
| 134 | 6 | $mariadb = false !== stripos($version, 'mariadb'); |
|
| 135 | 6 | if ($mariadb && version_compare($this->getMariaDbMysqlVersionNumber($version), '10.2.7', '>=')) { |
|
| 136 | 3 | return new MariaDb1027Platform(); |
|
| 137 | } |
||
| 138 | |||
| 139 | 6 | if ( ! $mariadb && version_compare($this->getOracleMysqlVersionNumber($version), '5.7.9', '>=')) { |
|
| 140 | 3 | return new MySQL57Platform(); |
|
| 141 | } |
||
| 142 | |||
| 143 | 3 | return $this->getDatabasePlatform(); |
|
| 144 | } |
||
| 145 | |||
| 146 | /** |
||
| 147 | * Get a normalized 'version number' from the server string |
||
| 148 | * returned by Oracle MySQL servers. |
||
| 149 | * |
||
| 150 | * @param string $versionString Version string returned by the driver, i.e. '5.7.10' |
||
| 151 | * @throws DBALException |
||
| 152 | */ |
||
| 153 | 6 | private function getOracleMysqlVersionNumber(string $versionString) : string |
|
| 154 | { |
||
| 155 | 6 | if ( ! preg_match('/^(?P<major>\d+)(?:\.(?P<minor>\d+)(?:\.(?P<patch>\d+))?)?/', $versionString, $versionParts)) { |
|
| 156 | 3 | throw DBALException::invalidPlatformVersionSpecified( |
|
| 157 | 3 | $versionString, |
|
| 158 | 3 | '<major_version>.<minor_version>.<patch_version>' |
|
| 159 | ); |
||
| 160 | } |
||
| 161 | 3 | $majorVersion = $versionParts['major']; |
|
| 162 | 3 | $minorVersion = $versionParts['minor'] ?? 0; |
|
| 163 | 3 | $patchVersion = $versionParts['patch'] ?? null; |
|
| 164 | |||
| 165 | 3 | if ('5' === $majorVersion && '7' === $minorVersion && null === $patchVersion) { |
|
| 166 | 3 | $patchVersion = '9'; |
|
| 167 | } |
||
| 168 | |||
| 169 | 3 | return $majorVersion . '.' . $minorVersion . '.' . $patchVersion; |
|
| 170 | } |
||
| 171 | |||
| 172 | /** |
||
| 173 | * Detect MariaDB server version, including hack for some mariadb distributions |
||
| 174 | * that starts with the prefix '5.5.5-' |
||
| 175 | * |
||
| 176 | * @param string $versionString Version string as returned by mariadb server, i.e. '5.5.5-Mariadb-10.0.8-xenial' |
||
| 177 | * @throws DBALException |
||
| 178 | */ |
||
| 179 | 3 | private function getMariaDbMysqlVersionNumber(string $versionString) : string |
|
| 180 | { |
||
| 181 | 3 | if ( ! preg_match('/^(?:5\.5\.5-)?(mariadb-)?(?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)/i', $versionString, $versionParts)) { |
|
| 182 | throw DBALException::invalidPlatformVersionSpecified( |
||
| 183 | $versionString, |
||
| 184 | '^(?:5\.5\.5-)?(mariadb-)?<major_version>.<minor_version>.<patch_version>' |
||
| 185 | ); |
||
| 186 | } |
||
| 187 | |||
| 188 | 3 | return $versionParts['major'] . '.' . $versionParts['minor'] . '.' . $versionParts['patch']; |
|
| 189 | } |
||
| 190 | |||
| 191 | /** |
||
| 192 | * {@inheritdoc} |
||
| 193 | */ |
||
| 194 | 4 | View Code Duplication | public function getDatabase(\Doctrine\DBAL\Connection $conn) |
|
|
|||
| 195 | { |
||
| 196 | 4 | $params = $conn->getParams(); |
|
| 197 | |||
| 198 | 4 | if (isset($params['dbname'])) { |
|
| 199 | 4 | return $params['dbname']; |
|
| 200 | } |
||
| 201 | |||
| 202 | 4 | return $conn->query('SELECT DATABASE()')->fetchColumn(); |
|
| 203 | } |
||
| 204 | |||
| 205 | /** |
||
| 206 | * {@inheritdoc} |
||
| 207 | * @return MySqlPlatform |
||
| 208 | */ |
||
| 209 | 6 | public function getDatabasePlatform() |
|
| 210 | { |
||
| 211 | 6 | return new MySqlPlatform(); |
|
| 212 | } |
||
| 213 | |||
| 214 | /** |
||
| 215 | * {@inheritdoc} |
||
| 216 | * @return MySqlSchemaManager |
||
| 217 | */ |
||
| 218 | 3 | public function getSchemaManager(\Doctrine\DBAL\Connection $conn) |
|
| 222 | } |
||
| 223 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.