Passed
Pull Request — master (#2839)
by Grégoire
05:00
created
tests/Doctrine/Tests/DBAL/Platforms/AbstractPlatformTestCase.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -273,6 +273,10 @@  discard block
 block discarded – undo
273 273
         }
274 274
     }
275 275
 
276
+    /**
277
+     * @param integer $value1
278
+     * @param integer $value2
279
+     */
276 280
     protected function getBitAndComparisonExpressionSql($value1, $value2)
277 281
     {
278 282
         return '(' . $value1 . ' & ' . $value2 . ')';
@@ -287,6 +291,10 @@  discard block
 block discarded – undo
287 291
         $this->assertEquals($this->getBitAndComparisonExpressionSql(2, 4), $sql);
288 292
     }
289 293
 
294
+    /**
295
+     * @param integer $value1
296
+     * @param integer $value2
297
+     */
290 298
     protected  function getBitOrComparisonExpressionSql($value1, $value2)
291 299
     {
292 300
         return '(' . $value1 . ' | ' . $value2 . ')';
Please login to merge, or discard this patch.
tests/Doctrine/Tests/DBAL/Schema/Visitor/CreateSchemaSqlCollectorTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
     }
139 139
 
140 140
     /**
141
-     * @return \Doctrine\DBAL\Schema\Sequence|\PHPUnit_Framework_MockObject_MockObject
141
+     * @return \Doctrine\DBAL\Schema\Sequence
142 142
      */
143 143
     private function createSequenceMock()
144 144
     {
Please login to merge, or discard this patch.
tests/Doctrine/Tests/DBAL/Schema/Visitor/DropSchemaSqlCollectorTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -45,11 +45,17 @@
 block discarded – undo
45 45
         return $this->getMockWithoutArguments('Doctrine\DBAL\Schema\Table');
46 46
     }
47 47
 
48
+    /**
49
+     * @param string $className
50
+     */
48 51
     private function getMockWithoutArguments($className)
49 52
     {
50 53
         return $this->getMockBuilder($className)->disableOriginalConstructor()->getMock();
51 54
     }
52 55
 
56
+    /**
57
+     * @param string $name
58
+     */
53 59
     private function getStubKeyConstraint($name)
54 60
     {
55 61
         $constraint = $this->getMockWithoutArguments('Doctrine\DBAL\Schema\ForeignKeyConstraint');
Please login to merge, or discard this patch.
tests/Doctrine/Tests/DBAL/Sharding/SQLAzure/SQLAzureShardManagerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -83,6 +83,9 @@
 block discarded – undo
83 83
         $sm->selectShard(null);
84 84
     }
85 85
 
86
+    /**
87
+     * @return \Doctrine\DBAL\Connection
88
+     */
86 89
     private function createConnection(array $params)
87 90
     {
88 91
         $conn = $this->getMockBuilder('Doctrine\DBAL\Connection')
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Driver/OCI8/OCI8Connection.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
 
22 22
 use Doctrine\DBAL\Driver\Connection;
23 23
 use Doctrine\DBAL\Driver\ServerInfoAwareConnection;
24
-use Doctrine\DBAL\Platforms\OraclePlatform;
25 24
 
26 25
 /**
27 26
  * OCI8 implementation of the Connection interface.
Please login to merge, or discard this patch.
tests/Doctrine/Tests/DBAL/Driver/AbstractDriverTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 use Doctrine\DBAL\Driver\ExceptionConverterDriver;
8 8
 use Doctrine\DBAL\VersionAwarePlatformDriver;
9 9
 use Doctrine\Tests\DbalTestCase;
10
-use Throwable;
11 10
 
12 11
 abstract class AbstractDriverTest extends DbalTestCase
13 12
 {
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Platforms/AbstractPlatform.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -487,7 +487,7 @@  discard block
 block discarded – undo
487 487
     /**
488 488
      * Marks this type as to be commented in ALTER TABLE and CREATE TABLE statements.
489 489
      *
490
-     * @param string|\Doctrine\DBAL\Types\Type $doctrineType
490
+     * @param Type $doctrineType
491 491
      *
492 492
      * @return void
493 493
      */
@@ -603,7 +603,7 @@  discard block
 block discarded – undo
603 603
     /**
604 604
      * Gets all SQL wildcard characters of the platform.
605 605
      *
606
-     * @return array
606
+     * @return string[]
607 607
      */
608 608
     public function getWildcards()
609 609
     {
@@ -855,7 +855,7 @@  discard block
 block discarded – undo
855 855
      *
856 856
      * @param string          $str      Literal string.
857 857
      * @param string          $substr   Literal string to find.
858
-     * @param integer|boolean $startPos Position to start at, beginning of string by default.
858
+     * @param integer $startPos Position to start at, beginning of string by default.
859 859
      *
860 860
      * @return string
861 861
      *
@@ -1416,7 +1416,7 @@  discard block
 block discarded – undo
1416 1416
     /**
1417 1417
      * Returns the SQL to safely drop a temporary table WITHOUT implicitly committing an open transaction.
1418 1418
      *
1419
-     * @param \Doctrine\DBAL\Schema\Table|string $table
1419
+     * @param string $table
1420 1420
      *
1421 1421
      * @return string
1422 1422
      */
@@ -1639,7 +1639,7 @@  discard block
 block discarded – undo
1639 1639
      * @param array  $columns
1640 1640
      * @param array  $options
1641 1641
      *
1642
-     * @return array
1642
+     * @return string[]
1643 1643
      */
1644 1644
     protected function _getCreateTableSQL($tableName, array $columns, array $options = [])
1645 1645
     {
@@ -1822,7 +1822,7 @@  discard block
 block discarded – undo
1822 1822
      * Returns the SQL to create an unnamed primary key constraint.
1823 1823
      *
1824 1824
      * @param \Doctrine\DBAL\Schema\Index        $index
1825
-     * @param \Doctrine\DBAL\Schema\Table|string $table
1825
+     * @param string $table
1826 1826
      *
1827 1827
      * @return string
1828 1828
      */
@@ -2120,7 +2120,7 @@  discard block
 block discarded – undo
2120 2120
      * @param \Doctrine\DBAL\Schema\Index $index        The definition of the index to rename to.
2121 2121
      * @param string                      $tableName    The table to rename the given index on.
2122 2122
      *
2123
-     * @return array The sequence of SQL statements for renaming the given index.
2123
+     * @return string[] The sequence of SQL statements for renaming the given index.
2124 2124
      */
2125 2125
     protected function getRenameIndexSQL($oldIndexName, Index $index, $tableName)
2126 2126
     {
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Connection.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -581,7 +581,7 @@  discard block
 block discarded – undo
581 581
      * @param integer $column    The 0-indexed column number to retrieve.
582 582
      * @param array  $types      The query parameter types.
583 583
      *
584
-     * @return mixed|bool False is returned if no rows are found.
584
+     * @return string|boolean False is returned if no rows are found.
585 585
      *
586 586
      * @throws \Doctrine\DBAL\DBALException
587 587
      */
@@ -1126,7 +1126,7 @@  discard block
 block discarded – undo
1126 1126
     /**
1127 1127
      * Fetches the SQLSTATE associated with the last database operation.
1128 1128
      *
1129
-     * @return integer The last error code.
1129
+     * @return string|null The last error code.
1130 1130
      */
1131 1131
     public function errorCode()
1132 1132
     {
@@ -1233,7 +1233,7 @@  discard block
 block discarded – undo
1233 1233
      * Returns the savepoint name to use for nested transactions are false if they are not supported
1234 1234
      * "savepointFormat" parameter is not set
1235 1235
      *
1236
-     * @return mixed A string with the savepoint name or false.
1236
+     * @return string A string with the savepoint name or false.
1237 1237
      */
1238 1238
     protected function _getNestedTransactionSavePointName()
1239 1239
     {
Please login to merge, or discard this patch.