Passed
Pull Request — master (#2839)
by Grégoire
05:00
created
lib/Doctrine/DBAL/Query/QueryBuilder.php 1 patch
Doc Comments   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -458,7 +458,7 @@  discard block
 block discarded – undo
458 458
      *         ->leftJoin('u', 'phonenumbers', 'p', 'u.id = p.user_id');
459 459
      * </code>
460 460
      *
461
-     * @param mixed $select The selection expressions.
461
+     * @param string $select The selection expressions.
462 462
      *
463 463
      * @return $this This QueryBuilder instance.
464 464
      */
@@ -486,7 +486,7 @@  discard block
 block discarded – undo
486 486
      *         ->leftJoin('u', 'phonenumbers', 'u.id = p.user_id');
487 487
      * </code>
488 488
      *
489
-     * @param mixed $select The selection expression.
489
+     * @param string $select The selection expression.
490 490
      *
491 491
      * @return $this This QueryBuilder instance.
492 492
      */
@@ -794,7 +794,7 @@  discard block
 block discarded – undo
794 794
      *         ->andWhere('u.is_active = 1');
795 795
      * </code>
796 796
      *
797
-     * @param mixed $where The query restrictions.
797
+     * @param string $where The query restrictions.
798 798
      *
799 799
      * @return $this This QueryBuilder instance.
800 800
      *
@@ -827,7 +827,7 @@  discard block
 block discarded – undo
827 827
      *         ->orWhere('u.id = 2');
828 828
      * </code>
829 829
      *
830
-     * @param mixed $where The WHERE statement.
830
+     * @param string $where The WHERE statement.
831 831
      *
832 832
      * @return $this This QueryBuilder instance.
833 833
      *
@@ -955,7 +955,7 @@  discard block
 block discarded – undo
955 955
      * Specifies a restriction over the groups of the query.
956 956
      * Replaces any previous having restrictions, if any.
957 957
      *
958
-     * @param mixed $having The restriction over the groups.
958
+     * @param string $having The restriction over the groups.
959 959
      *
960 960
      * @return $this This QueryBuilder instance.
961 961
      */
@@ -972,7 +972,7 @@  discard block
 block discarded – undo
972 972
      * Adds a restriction over the groups of the query, forming a logical
973 973
      * conjunction with any existing having restrictions.
974 974
      *
975
-     * @param mixed $having The restriction to append.
975
+     * @param string $having The restriction to append.
976 976
      *
977 977
      * @return $this This QueryBuilder instance.
978 978
      */
@@ -995,7 +995,7 @@  discard block
 block discarded – undo
995 995
      * Adds a restriction over the groups of the query, forming a logical
996 996
      * disjunction with any existing having restrictions.
997 997
      *
998
-     * @param mixed $having The restriction to add.
998
+     * @param string $having The restriction to add.
999 999
      *
1000 1000
      * @return $this This QueryBuilder instance.
1001 1001
      */
@@ -1066,7 +1066,7 @@  discard block
 block discarded – undo
1066 1066
     /**
1067 1067
      * Resets SQL parts.
1068 1068
      *
1069
-     * @param array|null $queryPartNames
1069
+     * @param string[] $queryPartNames
1070 1070
      *
1071 1071
      * @return $this This QueryBuilder instance.
1072 1072
      */
@@ -1250,7 +1250,7 @@  discard block
 block discarded – undo
1250 1250
      * @license New BSD License
1251 1251
      * @link http://www.zetacomponents.org
1252 1252
      *
1253
-     * @param mixed  $value
1253
+     * @param integer  $value
1254 1254
      * @param mixed  $type
1255 1255
      * @param string $placeHolder The name to bind with. The string must start with a colon ':'.
1256 1256
      *
@@ -1284,7 +1284,7 @@  discard block
 block discarded – undo
1284 1284
      *     ->orWhere('u.username = ' . $qb->createPositionalParameter('Bar', PDO::PARAM_STR))
1285 1285
      * </code>
1286 1286
      *
1287
-     * @param mixed   $value
1287
+     * @param integer   $value
1288 1288
      * @param integer $type
1289 1289
      *
1290 1290
      * @return string
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
     /**
197 197
      * Returns true if all the given tables exist.
198 198
      *
199
-     * @param array $tableNames
199
+     * @param string $tableNames
200 200
      *
201 201
      * @return boolean
202 202
      */
@@ -972,7 +972,7 @@  discard block
 block discarded – undo
972 972
     /**
973 973
      * @param array $view
974 974
      *
975
-     * @return mixed
975
+     * @return boolean
976 976
      */
977 977
     protected function _getPortableViewDefinition($view)
978 978
     {
@@ -1075,7 +1075,7 @@  discard block
 block discarded – undo
1075 1075
      * For databases that don't support subschema/namespaces this method
1076 1076
      * returns the name of the currently connected database.
1077 1077
      *
1078
-     * @return array
1078
+     * @return string[]
1079 1079
      */
1080 1080
     public function getSchemaSearchPaths()
1081 1081
     {
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Schema/Schema.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -263,7 +263,7 @@
 block discarded – undo
263 263
     /**
264 264
      * Gets all table names, prefixed with a schema name, even the default one if present.
265 265
      *
266
-     * @return array
266
+     * @return integer[]
267 267
      */
268 268
     public function getTableNames()
269 269
     {
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Schema/Table.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -401,8 +401,8 @@
 block discarded – undo
401 401
      * @deprecated Use {@link addForeignKeyConstraint}
402 402
      *
403 403
      * @param Table|string $foreignTable Table schema instance or table name
404
-     * @param array        $localColumnNames
405
-     * @param array        $foreignColumnNames
404
+     * @param string[]        $localColumnNames
405
+     * @param string[]        $foreignColumnNames
406 406
      * @param array        $options
407 407
      *
408 408
      * @return self
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Sharding/PoolingShardManager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -99,8 +99,8 @@
 block discarded – undo
99 99
 
100 100
     /**
101 101
      * @param string $sql
102
-     * @param array  $params
103
-     * @param array  $types
102
+     * @param integer[]  $params
103
+     * @param integer[]  $types
104 104
      *
105 105
      * @return array
106 106
      *
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Sharding/SQLAzure/SQLAzureFederationsSynchronizer.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@
 block discarded – undo
179 179
     /**
180 180
      * @param \Doctrine\DBAL\Schema\Schema $schema
181 181
      *
182
-     * @return array
182
+     * @return Schema[]
183 183
      */
184 184
     private function partitionSchema(Schema $schema)
185 185
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 use Doctrine\DBAL\Schema\Schema;
23 23
 use Doctrine\DBAL\Connection;
24 24
 use Doctrine\DBAL\Types\Type;
25
-
26 25
 use Doctrine\DBAL\Schema\Synchronizer\AbstractSchemaSynchronizer;
27 26
 use Doctrine\DBAL\Schema\Synchronizer\SingleDatabaseSynchronizer;
28 27
 use Doctrine\DBAL\Schema\Synchronizer\SchemaSynchronizer;
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Statement.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -276,7 +276,7 @@
 block discarded – undo
276 276
      *
277 277
      * @param integer $columnIndex
278 278
      *
279
-     * @return mixed A single column from the next row of a result set or FALSE if there are no more rows.
279
+     * @return string|boolean A single column from the next row of a result set or FALSE if there are no more rows.
280 280
      */
281 281
     public function fetchColumn($columnIndex = 0)
282 282
     {
Please login to merge, or discard this patch.
tests/Doctrine/Tests/DBAL/Functional/BlobTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -71,6 +71,9 @@  discard block
 block discarded – undo
71 71
         $this->assertBinaryContains('test2');
72 72
     }
73 73
 
74
+    /**
75
+     * @param string $text
76
+     */
74 77
     private function assertBinaryContains($text)
75 78
     {
76 79
         $rows = $this->_conn->fetchAll('SELECT * FROM blob_table');
@@ -84,6 +87,9 @@  discard block
 block discarded – undo
84 87
         $this->assertEquals($text, stream_get_contents($blobValue));
85 88
     }
86 89
 
90
+    /**
91
+     * @param string $text
92
+     */
87 93
     private function assertBlobContains($text)
88 94
     {
89 95
         $rows = $this->_conn->fetchAll('SELECT * FROM blob_table');
Please login to merge, or discard this patch.
tests/Doctrine/Tests/DBAL/Functional/ResultCacheTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -184,6 +184,9 @@  discard block
 block discarded – undo
184 184
         $this->assertEquals(1, count($secondCache->fetch("emptycachekey")));
185 185
     }
186 186
 
187
+    /**
188
+     * @param \Doctrine\DBAL\Driver\Statement $stmt
189
+     */
187 190
     private function hydrateStmt($stmt, $fetchMode = \PDO::FETCH_ASSOC)
188 191
     {
189 192
         $data = array();
@@ -194,6 +197,9 @@  discard block
 block discarded – undo
194 197
         return $data;
195 198
     }
196 199
 
200
+    /**
201
+     * @param \Doctrine\DBAL\Driver\Statement $stmt
202
+     */
197 203
     private function hydrateStmtIterator($stmt, $fetchMode = \PDO::FETCH_ASSOC)
198 204
     {
199 205
         $data = array();
Please login to merge, or discard this patch.