Completed
Pull Request — 2.5 (#3073)
by
unknown
05:41
created
lib/Doctrine/DBAL/Connection.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -534,7 +534,7 @@  discard block
 block discarded – undo
534 534
      * @param integer $column    The 0-indexed column number to retrieve.
535 535
      * @param array  $types      The query parameter types.
536 536
      *
537
-     * @return mixed
537
+     * @return string|boolean
538 538
      */
539 539
     public function fetchColumn($statement, array $params = array(), $column = 0, array $types = array())
540 540
     {
@@ -1066,7 +1066,7 @@  discard block
 block discarded – undo
1066 1066
     /**
1067 1067
      * Fetches the SQLSTATE associated with the last database operation.
1068 1068
      *
1069
-     * @return integer The last error code.
1069
+     * @return string|null The last error code.
1070 1070
      */
1071 1071
     public function errorCode()
1072 1072
     {
@@ -1168,7 +1168,7 @@  discard block
 block discarded – undo
1168 1168
      * Returns the savepoint name to use for nested transactions are false if they are not supported
1169 1169
      * "savepointFormat" parameter is not set
1170 1170
      *
1171
-     * @return mixed A string with the savepoint name or false.
1171
+     * @return string A string with the savepoint name or false.
1172 1172
      */
1173 1173
     protected function _getNestedTransactionSavePointName()
1174 1174
     {
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Platforms/AbstractPlatform.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -597,7 +597,7 @@  discard block
 block discarded – undo
597 597
     /**
598 598
      * Gets all SQL wildcard characters of the platform.
599 599
      *
600
-     * @return array
600
+     * @return string[]
601 601
      */
602 602
     public function getWildcards()
603 603
     {
@@ -849,7 +849,7 @@  discard block
 block discarded – undo
849 849
      *
850 850
      * @param string          $str      Literal string.
851 851
      * @param string          $substr   Literal string to find.
852
-     * @param integer|boolean $startPos Position to start at, beginning of string by default.
852
+     * @param integer $startPos Position to start at, beginning of string by default.
853 853
      *
854 854
      * @return string
855 855
      *
@@ -1410,7 +1410,7 @@  discard block
 block discarded – undo
1410 1410
     /**
1411 1411
      * Returns the SQL to safely drop a temporary table WITHOUT implicitly committing an open transaction.
1412 1412
      *
1413
-     * @param \Doctrine\DBAL\Schema\Table|string $table
1413
+     * @param string $table
1414 1414
      *
1415 1415
      * @return string
1416 1416
      */
@@ -1615,7 +1615,7 @@  discard block
 block discarded – undo
1615 1615
      * @param array  $columns
1616 1616
      * @param array  $options
1617 1617
      *
1618
-     * @return array
1618
+     * @return string[]
1619 1619
      */
1620 1620
     protected function _getCreateTableSQL($tableName, array $columns, array $options = array())
1621 1621
     {
@@ -1798,7 +1798,7 @@  discard block
 block discarded – undo
1798 1798
      * Returns the SQL to create an unnamed primary key constraint.
1799 1799
      *
1800 1800
      * @param \Doctrine\DBAL\Schema\Index        $index
1801
-     * @param \Doctrine\DBAL\Schema\Table|string $table
1801
+     * @param string $table
1802 1802
      *
1803 1803
      * @return string
1804 1804
      */
@@ -2096,7 +2096,7 @@  discard block
 block discarded – undo
2096 2096
      * @param \Doctrine\DBAL\Schema\Index $index        The definition of the index to rename to.
2097 2097
      * @param string                      $tableName    The table to rename the given index on.
2098 2098
      *
2099
-     * @return array The sequence of SQL statements for renaming the given index.
2099
+     * @return string[] The sequence of SQL statements for renaming the given index.
2100 2100
      */
2101 2101
     protected function getRenameIndexSQL($oldIndexName, Index $index, $tableName)
2102 2102
     {
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/SQLParserUtils.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@
 block discarded – undo
197 197
      * 1 => offset of fragment in $statement
198 198
      *
199 199
      * @param string $statement
200
-     * @return array
200
+     * @return string[]
201 201
      */
202 202
     static private function getUnquotedStatementFragments($statement)
203 203
     {
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Statement.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
      * being bound.
98 98
      *
99 99
      * @param string $name  The name or position of the parameter.
100
-     * @param mixed  $value The value of the parameter.
100
+     * @param string  $value The value of the parameter.
101 101
      * @param mixed  $type  Either a PDO binding type or a DBAL mapping type name or instance.
102 102
      *
103 103
      * @return boolean TRUE on success, FALSE on failure.
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
      * Binding a parameter by reference does not support DBAL mapping types.
130 130
      *
131 131
      * @param string       $name   The name or position of the parameter.
132
-     * @param mixed        $var    The reference to the variable to bind.
132
+     * @param string        $var    The reference to the variable to bind.
133 133
      * @param integer      $type   The PDO binding type.
134 134
      * @param integer|null $length Must be specified when using an OUT bind
135 135
      *                             so that PHP allocates enough memory to hold the returned value.
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
      * Returns an array containing all of the result set rows.
269 269
      *
270 270
      * @param integer|null $fetchMode
271
-     * @param mixed        $fetchArgument
271
+     * @param integer        $fetchArgument
272 272
      *
273 273
      * @return array An array containing all of the remaining rows in the result set.
274 274
      */
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
      *
287 287
      * @param integer $columnIndex
288 288
      *
289
-     * @return mixed A single column from the next row of a result set or FALSE if there are no more rows.
289
+     * @return string|boolean A single column from the next row of a result set or FALSE if there are no more rows.
290 290
      */
291 291
     public function fetchColumn($columnIndex = 0)
292 292
     {
Please login to merge, or discard this patch.
tests/Doctrine/Tests/DBAL/Platforms/AbstractPostgreSqlPlatformTestCase.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
311 311
      * @dataProvider pgBooleanProvider
312 312
      *
313 313
      * @param string $databaseValue
314
-     * @param string $prepareStatementValue
314
+     * @param string $preparedStatementValue
315 315
      * @param integer $integerValue
316 316
      * @param boolean $booleanValue
317 317
      */
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
      * @dataProvider pgBooleanProvider
347 347
      *
348 348
      * @param string $databaseValue
349
-     * @param string $prepareStatementValue
349
+     * @param string $preparedStatementValue
350 350
      * @param integer $integerValue
351 351
      * @param boolean $booleanValue
352 352
      */
Please login to merge, or discard this patch.
tests/Doctrine/Tests/DBAL/Sharding/SQLAzure/SQLAzureShardManagerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -83,6 +83,9 @@
 block discarded – undo
83 83
         $sm->selectShard(null);
84 84
     }
85 85
 
86
+    /**
87
+     * @return \Doctrine\DBAL\Connection
88
+     */
86 89
     private function createConnection(array $params)
87 90
     {
88 91
         $conn = $this->getMock('Doctrine\DBAL\Connection', array('getParams', 'exec', 'isTransactionActive'), array(), '', false);
Please login to merge, or discard this patch.