Completed
Pull Request — 2.5 (#3073)
by
unknown
05:41
created
lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
     /**
197 197
      * Returns true if all the given tables exist.
198 198
      *
199
-     * @param array $tableNames
199
+     * @param string $tableNames
200 200
      *
201 201
      * @return boolean
202 202
      */
@@ -972,7 +972,7 @@  discard block
 block discarded – undo
972 972
     /**
973 973
      * @param array $view
974 974
      *
975
-     * @return mixed
975
+     * @return boolean
976 976
      */
977 977
     protected function _getPortableViewDefinition($view)
978 978
     {
@@ -1075,7 +1075,7 @@  discard block
 block discarded – undo
1075 1075
      * For databases that don't support subschema/namespaces this method
1076 1076
      * returns the name of the currently connected database.
1077 1077
      *
1078
-     * @return array
1078
+     * @return string[]
1079 1079
      */
1080 1080
     public function getSchemaSearchPaths()
1081 1081
     {
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Schema/Schema.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -263,7 +263,7 @@
 block discarded – undo
263 263
     /**
264 264
      * Gets all table names, prefixed with a schema name, even the default one if present.
265 265
      *
266
-     * @return array
266
+     * @return integer[]
267 267
      */
268 268
     public function getTableNames()
269 269
     {
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Schema/Table.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -401,8 +401,8 @@
 block discarded – undo
401 401
      * @deprecated Use {@link addForeignKeyConstraint}
402 402
      *
403 403
      * @param Table|string $foreignTable Table schema instance or table name
404
-     * @param array        $localColumnNames
405
-     * @param array        $foreignColumnNames
404
+     * @param string[]        $localColumnNames
405
+     * @param string[]        $foreignColumnNames
406 406
      * @param array        $options
407 407
      *
408 408
      * @return self
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Sharding/PoolingShardManager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -99,8 +99,8 @@
 block discarded – undo
99 99
 
100 100
     /**
101 101
      * @param string $sql
102
-     * @param array  $params
103
-     * @param array  $types
102
+     * @param integer[]  $params
103
+     * @param integer[]  $types
104 104
      *
105 105
      * @return array
106 106
      *
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Sharding/SQLAzure/SQLAzureFederationsSynchronizer.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@
 block discarded – undo
179 179
     /**
180 180
      * @param \Doctrine\DBAL\Schema\Schema $schema
181 181
      *
182
-     * @return array
182
+     * @return Schema[]
183 183
      */
184 184
     private function partitionSchema(Schema $schema)
185 185
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 use Doctrine\DBAL\Schema\Schema;
23 23
 use Doctrine\DBAL\Connection;
24 24
 use Doctrine\DBAL\Types\Type;
25
-
26 25
 use Doctrine\DBAL\Schema\Synchronizer\AbstractSchemaSynchronizer;
27 26
 use Doctrine\DBAL\Schema\Synchronizer\SingleDatabaseSynchronizer;
28 27
 use Doctrine\DBAL\Schema\Synchronizer\SchemaSynchronizer;
Please login to merge, or discard this patch.
tests/Doctrine/Tests/DBAL/Functional/BlobTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -71,6 +71,9 @@  discard block
 block discarded – undo
71 71
         $this->assertBinaryContains('test2');
72 72
     }
73 73
 
74
+    /**
75
+     * @param string $text
76
+     */
74 77
     private function assertBinaryContains($text)
75 78
     {
76 79
         $rows = $this->_conn->fetchAll('SELECT * FROM blob_table');
@@ -84,6 +87,9 @@  discard block
 block discarded – undo
84 87
         $this->assertEquals($text, stream_get_contents($blobValue));
85 88
     }
86 89
 
90
+    /**
91
+     * @param string $text
92
+     */
87 93
     private function assertBlobContains($text)
88 94
     {
89 95
         $rows = $this->_conn->fetchAll('SELECT * FROM blob_table');
Please login to merge, or discard this patch.
tests/Doctrine/Tests/DBAL/Functional/ResultCacheTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -184,6 +184,9 @@  discard block
 block discarded – undo
184 184
         $this->assertEquals(1, count($secondCache->fetch("emptycachekey")));
185 185
     }
186 186
 
187
+    /**
188
+     * @param \Doctrine\DBAL\Driver\Statement $stmt
189
+     */
187 190
     private function hydrateStmt($stmt, $fetchMode = \PDO::FETCH_ASSOC)
188 191
     {
189 192
         $data = array();
@@ -194,6 +197,9 @@  discard block
 block discarded – undo
194 197
         return $data;
195 198
     }
196 199
 
200
+    /**
201
+     * @param \Doctrine\DBAL\Driver\Statement $stmt
202
+     */
197 203
     private function hydrateStmtIterator($stmt, $fetchMode = \PDO::FETCH_ASSOC)
198 204
     {
199 205
         $data = array();
Please login to merge, or discard this patch.
Doctrine/Tests/DBAL/Functional/Schema/SchemaManagerFunctionalTestCase.php 1 patch
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -857,6 +857,9 @@  discard block
 block discarded – undo
857 857
         return $table;
858 858
     }
859 859
 
860
+    /**
861
+     * @param string $name
862
+     */
860 863
     protected function getTestTable($name, $options=array())
861 864
     {
862 865
         $table = new Table($name, array(), array(), array(), false, $options);
@@ -868,6 +871,9 @@  discard block
 block discarded – undo
868 871
         return $table;
869 872
     }
870 873
 
874
+    /**
875
+     * @param string $name
876
+     */
871 877
     protected function getTestCompositeTable($name)
872 878
     {
873 879
         $table = new Table($name, array(), array(), array(), false, array());
@@ -879,6 +885,10 @@  discard block
 block discarded – undo
879 885
         return $table;
880 886
     }
881 887
 
888
+    /**
889
+     * @param Table[] $tables
890
+     * @param string $tableName
891
+     */
882 892
     protected function assertHasTable($tables, $tableName)
883 893
     {
884 894
         $foundTable = false;
Please login to merge, or discard this patch.
tests/Doctrine/Tests/DBAL/Platforms/AbstractPlatformTestCase.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -273,6 +273,10 @@  discard block
 block discarded – undo
273 273
         }
274 274
     }
275 275
 
276
+    /**
277
+     * @param integer $value1
278
+     * @param integer $value2
279
+     */
276 280
     protected function getBitAndComparisonExpressionSql($value1, $value2)
277 281
     {
278 282
         return '(' . $value1 . ' & ' . $value2 . ')';
@@ -287,6 +291,10 @@  discard block
 block discarded – undo
287 291
         $this->assertEquals($this->getBitAndComparisonExpressionSql(2, 4), $sql);
288 292
     }
289 293
 
294
+    /**
295
+     * @param integer $value1
296
+     * @param integer $value2
297
+     */
290 298
     protected  function getBitOrComparisonExpressionSql($value1, $value2)
291 299
     {
292 300
         return '(' . $value1 . ' | ' . $value2 . ')';
Please login to merge, or discard this patch.