DB2SchemaManager::_getPortableTableColumnDefinition() - Code Metrics - Inspection of "Enforce parameter and return value types in the co..." - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — develop (#3348)

by Sergei

created 2019-05-24 21:23 UTC

_getPortableTableColumnDefinition() F

↳ Parent: DB2SchemaManager

Complexity

Conditions	15
Paths	336

Size

Total Lines	60
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	206.3298

Importance

Changes

Metric	Value
eloc	43
dl	0
loc	60
ccs	2
cts	38
cp	0.0526
rs	3.3833
c	0
b	0
f	0
cc	15
nc	336
nop	1
crap	206.3298

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace Doctrine\DBAL\Schema;

use Doctrine\DBAL\Types\Type;
use const CASE_LOWER;
use function array_change_key_case;
use function assert;
use function is_resource;
use function is_string;
use function preg_match;
use function str_replace;
use function strpos;
use function strtolower;
use function substr;

/**
 * IBM Db2 Schema Manager.
 */
class DB2SchemaManager extends AbstractSchemaManager
{
    /**
     * {@inheritdoc}
     *
     * Apparently creator is the schema not the user who created it:
     * {@link http://publib.boulder.ibm.com/infocenter/dzichelp/v2r2/index.jsp?topic=/com.ibm.db29.doc.sqlref/db2z_sysibmsystablestable.htm}
     */
    public function listTableNames() : array
    {
        $username = $this->_conn->getUsername();
        assert(is_string($username));

        $sql = $this->_platform->getListTablesSQL() . ' AND CREATOR = UPPER(?)';

        $tables = $this->_conn->fetchAll($sql, [$username]);

        return $this->filterAssetNames($this->_getPortableTablesList($tables));
    }

    /**
     * {@inheritdoc}
     */
    protected function _getPortableTableColumnDefinition(array $tableColumn) : Column
    {
        $tableColumn = array_change_key_case($tableColumn, CASE_LOWER);

        $length = $precision = $default = null;
        $scale  = 0;
        $fixed  = false;

        if ($tableColumn['default'] !== null && $tableColumn['default'] !== 'NULL') {
            $default = $tableColumn['default'];

            if (preg_match('/^\'(.*)\'$/s', $default, $matches)) {
                $default = str_replace("''", "'", $matches[1]);
            }
        }

        $type = $this->extractDoctrineTypeFromComment($tableColumn['comment'])
            ?? $this->_platform->getDoctrineTypeMapping($tableColumn['typename']);

        switch (strtolower($tableColumn['typename'])) {
            case 'varchar':
                $length = $tableColumn['length'];
                break;
            case 'character':
                $length = $tableColumn['length'];
                $fixed  = true;
                break;
            case 'clob':
                $length = $tableColumn['length'];
                break;
            case 'decimal':
            case 'double':
            case 'real':
                $scale     = $tableColumn['scale'];
                $precision = $tableColumn['length'];
                break;
        }

        $options = [
            'length'        => $length,
            'unsigned'      => false,
            'default'       => $default,
            'autoincrement' => (bool) $tableColumn['autoincrement'],
            'notnull'       => $tableColumn['nulls'] === 'N',
            'comment'       => isset($tableColumn['comment']) && $tableColumn['comment'] !== ''
                ? $tableColumn['comment']
                : null,
            'platformOptions' => [],
        ];

        if ($fixed !== null) {

            $options['fixed'] = $fixed;
        }

        if ($scale !== null && $precision !== null) {
            $options['scale']     = $scale;
            $options['precision'] = $precision;
        }

        return new Column($tableColumn['colname'], Type::getType($type), $options);
    }

    /**
     * {@inheritdoc}
     */
    protected function _getPortableTablesList(array $tables) : array
    {
        $tableNames = [];
        foreach ($tables as $tableRow) {
            $tableRow     = array_change_key_case($tableRow, CASE_LOWER);
            $tableNames[] = $tableRow['name'];
        }

        return $tableNames;
    }

    /**
     * {@inheritdoc}
     */
    protected function _getPortableTableIndexesList(array $tableIndexRows, string $tableName) : array
    {
        foreach ($tableIndexRows as &$tableIndexRow) {
            $tableIndexRow            = array_change_key_case($tableIndexRow, CASE_LOWER);
            $tableIndexRow['primary'] = (bool) $tableIndexRow['primary'];
        }

        return parent::_getPortableTableIndexesList($tableIndexRows, $tableName);
    }

    /**
     * {@inheritdoc}
     */
    protected function _getPortableTableForeignKeyDefinition($tableForeignKey) : ForeignKeyConstraint
    {
        return new ForeignKeyConstraint(
            $tableForeignKey['local_columns'],
            $tableForeignKey['foreign_table'],
            $tableForeignKey['foreign_columns'],
            $tableForeignKey['name'],
            $tableForeignKey['options']
        );
    }

    /**
     * {@inheritdoc}
     */
    protected function _getPortableTableForeignKeysList(array $tableForeignKeys) : array
    {
        $foreignKeys = [];

        foreach ($tableForeignKeys as $tableForeignKey) {
            $tableForeignKey = array_change_key_case($tableForeignKey, CASE_LOWER);

            if (! isset($foreignKeys[$tableForeignKey['index_name']])) {
                $foreignKeys[$tableForeignKey['index_name']] = [
                    'local_columns'   => [$tableForeignKey['local_column']],
                    'foreign_table'   => $tableForeignKey['foreign_table'],
                    'foreign_columns' => [$tableForeignKey['foreign_column']],
                    'name'            => $tableForeignKey['index_name'],
                    'options'         => [
                        'onUpdate' => $tableForeignKey['on_update'],
                        'onDelete' => $tableForeignKey['on_delete'],
                    ],
                ];
            } else {
                $foreignKeys[$tableForeignKey['index_name']]['local_columns'][]   = $tableForeignKey['local_column'];
                $foreignKeys[$tableForeignKey['index_name']]['foreign_columns'][] = $tableForeignKey['foreign_column'];
            }
        }

        return parent::_getPortableTableForeignKeysList($foreignKeys);
    }

    /**
     * {@inheritdoc}
     */
    protected function _getPortableViewDefinition(array $view) : View
    {
        $view = array_change_key_case($view, CASE_LOWER);
        // sadly this still segfaults on PDO_IBM, see http://pecl.php.net/bugs/bug.php?id=17199
        //$view['text'] = (is_resource($view['text']) ? stream_get_contents($view['text']) : $view['text']);
        if (! is_resource($view['text'])) {
            $pos = strpos($view['text'], ' AS ');
            $sql = substr($view['text'], $pos+4);
        } else {
            $sql = '';
        }

        return new View($view['name'], $sql);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\DBAL\Schema;
6
7		use Doctrine\DBAL\Types\Type;
8		use const CASE_LOWER;
9		use function array_change_key_case;
10		use function assert;
11		use function is_resource;
12		use function is_string;
13		use function preg_match;
14		use function str_replace;
15		use function strpos;
16		use function strtolower;
17		use function substr;
18
19		/**
20		* IBM Db2 Schema Manager.
21		*/
22		class DB2SchemaManager extends AbstractSchemaManager
23		{
24		/**
25		* {@inheritdoc}
26		*
27		* Apparently creator is the schema not the user who created it:
28		* {@link http://publib.boulder.ibm.com/infocenter/dzichelp/v2r2/index.jsp?topic=/com.ibm.db29.doc.sqlref/db2z_sysibmsystablestable.htm}
29	135	*/
30		public function listTableNames() : array
31	135	{
32	135	$username = $this->_conn->getUsername();
33		assert(is_string($username));
34	135
35		$sql = $this->_platform->getListTablesSQL() . ' AND CREATOR = UPPER(?)';
36	135
37		$tables = $this->_conn->fetchAll($sql, [$username]);
38	135
39		return $this->filterAssetNames($this->_getPortableTablesList($tables));
40		}
41
42		/**
43		* {@inheritdoc}
44		*/
45		protected function _getPortableTableColumnDefinition(array $tableColumn) : Column
46		{
47		$tableColumn = array_change_key_case($tableColumn, CASE_LOWER);
48
49		$length = $precision = $default = null;
50		$scale = 0;
51		$fixed = false;
52
53		if ($tableColumn['default'] !== null && $tableColumn['default'] !== 'NULL') {
54		$default = $tableColumn['default'];
55
56		if (preg_match('/^\'(.*)\'$/s', $default, $matches)) {
57		$default = str_replace("''", "'", $matches[1]);
58		}
59		}
60
61		$type = $this->extractDoctrineTypeFromComment($tableColumn['comment'])
62		?? $this->_platform->getDoctrineTypeMapping($tableColumn['typename']);
63
64		switch (strtolower($tableColumn['typename'])) {
65		case 'varchar':
66		$length = $tableColumn['length'];
67		break;
68		case 'character':
69		$length = $tableColumn['length'];
70		$fixed = true;
71		break;
72		case 'clob':
73		$length = $tableColumn['length'];
74		break;
75		case 'decimal':
76		case 'double':
77		case 'real':
78		$scale = $tableColumn['scale'];
79		$precision = $tableColumn['length'];
80		break;
81		}
82
83		$options = [
84		'length' => $length,
85		'unsigned' => false,
86		'default' => $default,
87		'autoincrement' => (bool) $tableColumn['autoincrement'],
88		'notnull' => $tableColumn['nulls'] === 'N',
89		'comment' => isset($tableColumn['comment']) && $tableColumn['comment'] !== ''
90		? $tableColumn['comment']
91		: null,
92		'platformOptions' => [],
93		];
94
95		if ($fixed !== null) {
		0 ignored issues – show introduced 2019-04-19 00:33 UTC by Report Bug Copy Issue Report The condition `$fixed !== null` is always `true`. Loading history...
96		$options['fixed'] = $fixed;
97		}
98
99		if ($scale !== null && $precision !== null) {
100		$options['scale'] = $scale;
101		$options['precision'] = $precision;
102	135	}
103
104	135	return new Column($tableColumn['colname'], Type::getType($type), $options);
105	135	}
106	135
107	135	/**
108		* {@inheritdoc}
109		*/
110	135	protected function _getPortableTablesList(array $tables) : array
111		{
112		$tableNames = [];
113		foreach ($tables as $tableRow) {
114		$tableRow = array_change_key_case($tableRow, CASE_LOWER);
115		$tableNames[] = $tableRow['name'];
116		}
117
118		return $tableNames;
119		}
120
121		/**
122		* {@inheritdoc}
123		*/
124		protected function _getPortableTableIndexesList(array $tableIndexRows, string $tableName) : array
125		{
126		foreach ($tableIndexRows as &$tableIndexRow) {
127		$tableIndexRow = array_change_key_case($tableIndexRow, CASE_LOWER);
128		$tableIndexRow['primary'] = (bool) $tableIndexRow['primary'];
129		}
130
131		return parent::_getPortableTableIndexesList($tableIndexRows, $tableName);
132		}
133
134		/**
135		* {@inheritdoc}
136		*/
137		protected function _getPortableTableForeignKeyDefinition($tableForeignKey) : ForeignKeyConstraint
138		{
139		return new ForeignKeyConstraint(
140		$tableForeignKey['local_columns'],
141		$tableForeignKey['foreign_table'],
142		$tableForeignKey['foreign_columns'],
143		$tableForeignKey['name'],
144		$tableForeignKey['options']
145		);
146		}
147
148		/**
149		* {@inheritdoc}
150		*/
151		protected function _getPortableTableForeignKeysList(array $tableForeignKeys) : array
152		{
153		$foreignKeys = [];
154
155		foreach ($tableForeignKeys as $tableForeignKey) {
156		$tableForeignKey = array_change_key_case($tableForeignKey, CASE_LOWER);
157
158		if (! isset($foreignKeys[$tableForeignKey['index_name']])) {
159		$foreignKeys[$tableForeignKey['index_name']] = [
160		'local_columns' => [$tableForeignKey['local_column']],
161		'foreign_table' => $tableForeignKey['foreign_table'],
162		'foreign_columns' => [$tableForeignKey['foreign_column']],
163		'name' => $tableForeignKey['index_name'],
164		'options' => [
165		'onUpdate' => $tableForeignKey['on_update'],
166		'onDelete' => $tableForeignKey['on_delete'],
167		],
168		];
169		} else {
170		$foreignKeys[$tableForeignKey['index_name']]['local_columns'][] = $tableForeignKey['local_column'];
171		$foreignKeys[$tableForeignKey['index_name']]['foreign_columns'][] = $tableForeignKey['foreign_column'];
172		}
173		}
174
175		return parent::_getPortableTableForeignKeysList($foreignKeys);
176		}
177
178		/**
179		* {@inheritdoc}
180		*/
181		protected function _getPortableViewDefinition(array $view) : View
182		{
183		$view = array_change_key_case($view, CASE_LOWER);
184		// sadly this still segfaults on PDO_IBM, see http://pecl.php.net/bugs/bug.php?id=17199
185		//$view['text'] = (is_resource($view['text']) ? stream_get_contents($view['text']) : $view['text']);
186		if (! is_resource($view['text'])) {
187		$pos = strpos($view['text'], ' AS ');
188		$sql = substr($view['text'], $pos+4);
189		} else {
190		$sql = '';
191		}
192
193		return new View($view['name'], $sql);
194		}
195		}
196

doctrine / dbal

Pull Request — develop (#3348)

_getPortableTableColumnDefinition() F

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like