DefaultValueTest::columnProvider() - Code Metrics - Inspection of "Handle default values as values, not SQL expressio..." - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2960)

by Sergei

created 2019-04-18 23:33 UTC

DefaultValueTest::columnProvider() A

↳ Parent: DefaultValueTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	70
Code Lines	52

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	52
dl	0
loc	70
rs	9.0472
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace Doctrine\Tests\DBAL\Functional\Schema;

use Doctrine\DBAL\Schema\Table;
use Doctrine\Tests\DbalFunctionalTestCase;
use function sprintf;

class DefaultValueTest extends DbalFunctionalTestCase
{
    /** @var bool */
    private static $initialized = false;

    protected function setUp() : void
    {
        parent::setUp();

        if (self::$initialized) {
            return;
        }

        self::$initialized = true;

        $table = new Table('default_value');
        $table->addColumn('id', 'integer');

        foreach (self::columnProvider() as [$name, $default]) {
            $table->addColumn($name, 'string', [
                'default' => $default,
                'notnull' => false,
            ]);
        }

        $this->connection->getSchemaManager()
            ->dropAndCreateTable($table);

        $this->connection->insert('default_value', ['id' => 1]);
    }

    /**
     * @dataProvider columnProvider
     */
    public function testEscapedDefaultValueCanBeIntrospected(string $name, $expectedDefault) : void
    {
        self::assertSame(
            $expectedDefault,
            $this->connection
                ->getSchemaManager()
                ->listTableDetails('default_value')
                ->getColumn($name)
                ->getDefault()
        );
    }

    /**
     * @dataProvider columnProvider
     */
    public function testEscapedDefaultValueCanBeInserted(string $name, $expectedDefault) : void
    {
        $value = $this->connection->fetchColumn(
            sprintf('SELECT %s FROM default_value', $name)
        );

        self::assertSame($expectedDefault, $value);
    }

    /**
     * Returns potential escaped literals from all platforms combined.
     *
     * @see https://dev.mysql.com/doc/refman/5.7/en/string-literals.html
     * @see http://www.sqlite.org/lang_expr.html
     * @see https://www.postgresql.org/docs/9.6/static/sql-syntax-lexical.html#SQL-SYNTAX-STRINGS-ESCAPE
     *
     * @return mixed[][]
     */
    public static function columnProvider() : iterable
    {
        return [
            'Single quote' => [
                'single_quote',
                "foo'bar",
            ],
            'Single quote, doubled' => [
                'single_quote_doubled',
                "foo''bar",
            ],
            'Double quote' => [
                'double_quote',
                'foo"bar',
            ],
            'Double quote, doubled' => [
                'double_quote_doubled',
                'foo""bar',
            ],
            'Backspace' => [
                'backspace',
                "foo\x08bar",
            ],
            'New line' => [
                'new_line',
                "foo\nbar",
            ],
            'Carriage return' => [
                'carriage_return',
                "foo\rbar",
            ],
            'Tab' => [
                'tab',
                "foo\tbar",
            ],
            'Substitute' => [
                'substitute',
                "foo\x1abar",
            ],
            'Backslash' => [
                'backslash',
                'foo\\bar',
            ],
            'Backslash, doubled' => [
                'backslash_doubled',
                'foo\\\\bar',
            ],
            'Percent' => [
                'percent_sign',
                'foo%bar',
            ],
            'Underscore' => [
                'underscore',
                'foo_bar',
            ],
            'NULL string' => [
                'null_string',
                'NULL',
            ],
            'NULL value' => [
                'null_value',
                null,
            ],
            'SQL expression' => [
                'sql_expression',
                "'; DROP DATABASE doctrine --",
            ],
            'No double conversion' => [
                'no_double_conversion',
                "\\'",
            ],
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Doctrine\Tests\DBAL\Functional\Schema;
6
7			use Doctrine\DBAL\Schema\Table;
8			use Doctrine\Tests\DbalFunctionalTestCase;
9			use function sprintf;
10
11			class DefaultValueTest extends DbalFunctionalTestCase
12			{
13			/** @var bool */
14			private static $initialized = false;
15
16			protected function setUp() : void
17			{
18			parent::setUp();
19
20			if (self::$initialized) {
21			return;
22			}
23
24			self::$initialized = true;
25
26			$table = new Table('default_value');
27			$table->addColumn('id', 'integer');
28
29			foreach (self::columnProvider() as [$name, $default]) {
30			$table->addColumn($name, 'string', [
31			'default' => $default,
32			'notnull' => false,
33			]);
34			}
35
36			$this->connection->getSchemaManager()
37			->dropAndCreateTable($table);
38
39			$this->connection->insert('default_value', ['id' => 1]);
40			}
41
42			/**
43			* @dataProvider columnProvider
44			*/
45			public function testEscapedDefaultValueCanBeIntrospected(string $name, $expectedDefault) : void
46			{
47			self::assertSame(
48			$expectedDefault,
49			$this->connection
50			->getSchemaManager()
51			->listTableDetails('default_value')
52			->getColumn($name)
53			->getDefault()
54			);
55			}
56
57			/**
58			* @dataProvider columnProvider
59			*/
60			public function testEscapedDefaultValueCanBeInserted(string $name, $expectedDefault) : void
61			{
62			$value = $this->connection->fetchColumn(
63			sprintf('SELECT %s FROM default_value', $name)
64			);
65
66			self::assertSame($expectedDefault, $value);
67			}
68
69			/**
70			* Returns potential escaped literals from all platforms combined.
71			*
72			* @see https://dev.mysql.com/doc/refman/5.7/en/string-literals.html
73			* @see http://www.sqlite.org/lang_expr.html
74			* @see https://www.postgresql.org/docs/9.6/static/sql-syntax-lexical.html#SQL-SYNTAX-STRINGS-ESCAPE
75			*
76			* @return mixed[][]
77			*/
78			public static function columnProvider() : iterable
79			{
80			return [
81			'Single quote' => [
82			'single_quote',
83			"foo'bar",
84			],
85			'Single quote, doubled' => [
86			'single_quote_doubled',
87			"foo''bar",
88			],
89			'Double quote' => [
90			'double_quote',
91			'foo"bar',
92			],
93			'Double quote, doubled' => [
94			'double_quote_doubled',
95			'foo""bar',
96			],
97			'Backspace' => [
98			'backspace',
99			"foo\x08bar",
100			],
101			'New line' => [
102			'new_line',
103			"foo\nbar",
104			],
105			'Carriage return' => [
106			'carriage_return',
107			"foo\rbar",
108			],
109			'Tab' => [
110			'tab',
111			"foo\tbar",
112			],
113			'Substitute' => [
114			'substitute',
115			"foo\x1abar",
116			],
117			'Backslash' => [
118			'backslash',
119			'foo\\bar',
120			],
121			'Backslash, doubled' => [
122			'backslash_doubled',
123			'foo\\\\bar',
124			],
125			'Percent' => [
126			'percent_sign',
127			'foo%bar',
128			],
129			'Underscore' => [
130			'underscore',
131			'foo_bar',
132			],
133			'NULL string' => [
134			'null_string',
135			'NULL',
136			],
137			'NULL value' => [
138			'null_value',
139			null,
140			],
141			'SQL expression' => [
142			'sql_expression',
143			"'; DROP DATABASE doctrine --",
144			],
145			'No double conversion' => [
146			'no_double_conversion',
147			"\\'",
148			],
149			];
150			}
151			}
152

doctrine / dbal

Pull Request — master (#2960)

DefaultValueTest::columnProvider() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like