| Conditions | 1 | 
| Paths | 1 | 
| Total Lines | 309 | 
| Code Lines | 185 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php | ||
| 138 | public static function dataExpandListParameters() : iterable | ||
| 139 |     { | ||
| 140 | return [ | ||
| 141 | // Positional: Very simple with one needle | ||
| 142 | [ | ||
| 143 | 'SELECT * FROM Foo WHERE foo IN (?)', | ||
| 144 | [[1, 2, 3]], | ||
| 145 | [Connection::PARAM_INT_ARRAY], | ||
| 146 | 'SELECT * FROM Foo WHERE foo IN (?, ?, ?)', | ||
| 147 | [1, 2, 3], | ||
| 148 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER], | ||
| 149 | ], | ||
| 150 | // Positional: One non-list before d one after list-needle | ||
| 151 | [ | ||
| 152 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?)', | ||
| 153 | ['string', [1, 2, 3]], | ||
| 154 | [ParameterType::STRING, Connection::PARAM_INT_ARRAY], | ||
| 155 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?, ?, ?)', | ||
| 156 | ['string', 1, 2, 3], | ||
| 157 | [ParameterType::STRING, ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER], | ||
| 158 | ], | ||
| 159 | // Positional: One non-list after list-needle | ||
| 160 | [ | ||
| 161 | 'SELECT * FROM Foo WHERE bar IN (?) AND baz = ?', | ||
| 162 | [[1, 2, 3], 'foo'], | ||
| 163 | [Connection::PARAM_INT_ARRAY, ParameterType::STRING], | ||
| 164 | 'SELECT * FROM Foo WHERE bar IN (?, ?, ?) AND baz = ?', | ||
| 165 | [1, 2, 3, 'foo'], | ||
| 166 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::STRING], | ||
| 167 | ], | ||
| 168 | // Positional: One non-list before and one after list-needle | ||
| 169 | [ | ||
| 170 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?) AND baz = ?', | ||
| 171 | [1, [1, 2, 3], 4], | ||
| 172 | [ParameterType::INTEGER, Connection::PARAM_INT_ARRAY, ParameterType::INTEGER], | ||
| 173 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?, ?, ?) AND baz = ?', | ||
| 174 | [1, 1, 2, 3, 4], | ||
| 175 | [ | ||
| 176 | ParameterType::INTEGER, | ||
| 177 | ParameterType::INTEGER, | ||
| 178 | ParameterType::INTEGER, | ||
| 179 | ParameterType::INTEGER, | ||
| 180 | ParameterType::INTEGER, | ||
| 181 | ], | ||
| 182 | ], | ||
| 183 | // Positional: Two lists | ||
| 184 | [ | ||
| 185 | 'SELECT * FROM Foo WHERE foo IN (?, ?)', | ||
| 186 | [[1, 2, 3], [4, 5]], | ||
| 187 | [Connection::PARAM_INT_ARRAY, Connection::PARAM_INT_ARRAY], | ||
| 188 | 'SELECT * FROM Foo WHERE foo IN (?, ?, ?, ?, ?)', | ||
| 189 | [1, 2, 3, 4, 5], | ||
| 190 | [ | ||
| 191 | ParameterType::INTEGER, | ||
| 192 | ParameterType::INTEGER, | ||
| 193 | ParameterType::INTEGER, | ||
| 194 | ParameterType::INTEGER, | ||
| 195 | ParameterType::INTEGER, | ||
| 196 | ], | ||
| 197 | ], | ||
| 198 | // Positional: Empty "integer" array DDC-1978 | ||
| 199 | [ | ||
| 200 | 'SELECT * FROM Foo WHERE foo IN (?)', | ||
| 201 | [[]], | ||
| 202 | [Connection::PARAM_INT_ARRAY], | ||
| 203 | 'SELECT * FROM Foo WHERE foo IN (NULL)', | ||
| 204 | [], | ||
| 205 | [], | ||
| 206 | ], | ||
| 207 | // Positional: Empty "str" array DDC-1978 | ||
| 208 | [ | ||
| 209 | 'SELECT * FROM Foo WHERE foo IN (?)', | ||
| 210 | [[]], | ||
| 211 | [Connection::PARAM_STR_ARRAY], | ||
| 212 | 'SELECT * FROM Foo WHERE foo IN (NULL)', | ||
| 213 | [], | ||
| 214 | [], | ||
| 215 | ], | ||
| 216 | // Positional: explicit keys for params and types | ||
| 217 | [ | ||
| 218 | 'SELECT * FROM Foo WHERE foo = ? AND bar = ? AND baz = ?', | ||
| 219 | [1 => 'bar', 2 => 'baz', 0 => 1], | ||
| 220 | [2 => ParameterType::STRING, 1 => ParameterType::STRING], | ||
| 221 | 'SELECT * FROM Foo WHERE foo = ? AND bar = ? AND baz = ?', | ||
| 222 | [1 => 'bar', 0 => 1, 2 => 'baz'], | ||
| 223 | [1 => ParameterType::STRING, 2 => ParameterType::STRING], | ||
| 224 | ], | ||
| 225 | // Positional: explicit keys for array params and array types | ||
| 226 | [ | ||
| 227 | 'SELECT * FROM Foo WHERE foo IN (?) AND bar IN (?) AND baz = ?', | ||
| 228 | [1 => ['bar1', 'bar2'], 2 => true, 0 => [1, 2, 3]], | ||
| 229 | [2 => ParameterType::BOOLEAN, 1 => Connection::PARAM_STR_ARRAY, 0 => Connection::PARAM_INT_ARRAY], | ||
| 230 | 'SELECT * FROM Foo WHERE foo IN (?, ?, ?) AND bar IN (?, ?) AND baz = ?', | ||
| 231 | [1, 2, 3, 'bar1', 'bar2', true], | ||
| 232 | [ | ||
| 233 | ParameterType::INTEGER, | ||
| 234 | ParameterType::INTEGER, | ||
| 235 | ParameterType::INTEGER, | ||
| 236 | ParameterType::STRING, | ||
| 237 | ParameterType::STRING, | ||
| 238 | ParameterType::BOOLEAN, | ||
| 239 | ], | ||
| 240 | ], | ||
| 241 | // Positional starts from 1: One non-list before and one after list-needle | ||
| 242 | [ | ||
| 243 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?) AND baz = ? AND foo IN (?)', | ||
| 244 | [1 => 1, 2 => [1, 2, 3], 3 => 4, 4 => [5, 6]], | ||
| 245 | [ | ||
| 246 | 1 => ParameterType::INTEGER, | ||
| 247 | 2 => Connection::PARAM_INT_ARRAY, | ||
| 248 | 3 => ParameterType::INTEGER, | ||
| 249 | 4 => Connection::PARAM_INT_ARRAY, | ||
| 250 | ], | ||
| 251 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?, ?, ?) AND baz = ? AND foo IN (?, ?)', | ||
| 252 | [1, 1, 2, 3, 4, 5, 6], | ||
| 253 | [ | ||
| 254 | ParameterType::INTEGER, | ||
| 255 | ParameterType::INTEGER, | ||
| 256 | ParameterType::INTEGER, | ||
| 257 | ParameterType::INTEGER, | ||
| 258 | ParameterType::INTEGER, | ||
| 259 | ParameterType::INTEGER, | ||
| 260 | ParameterType::INTEGER, | ||
| 261 | ], | ||
| 262 | ], | ||
| 263 | // Named parameters : Very simple with param int | ||
| 264 | [ | ||
| 265 | 'SELECT * FROM Foo WHERE foo = :foo', | ||
| 266 | ['foo' => 1], | ||
| 267 | ['foo' => ParameterType::INTEGER], | ||
| 268 | 'SELECT * FROM Foo WHERE foo = ?', | ||
| 269 | [1], | ||
| 270 | [ParameterType::INTEGER], | ||
| 271 | ], | ||
| 272 | |||
| 273 | // Named parameters : Very simple with param int and string | ||
| 274 | [ | ||
| 275 | 'SELECT * FROM Foo WHERE foo = :foo AND bar = :bar', | ||
| 276 | ['bar' => 'Some String','foo' => 1], | ||
| 277 | ['foo' => ParameterType::INTEGER, 'bar' => ParameterType::STRING], | ||
| 278 | 'SELECT * FROM Foo WHERE foo = ? AND bar = ?', | ||
| 279 | [1,'Some String'], | ||
| 280 | [ParameterType::INTEGER, ParameterType::STRING], | ||
| 281 | ], | ||
| 282 | // Named parameters : Very simple with one needle | ||
| 283 | [ | ||
| 284 | 'SELECT * FROM Foo WHERE foo IN (:foo)', | ||
| 285 | ['foo' => [1, 2, 3]], | ||
| 286 | ['foo' => Connection::PARAM_INT_ARRAY], | ||
| 287 | 'SELECT * FROM Foo WHERE foo IN (?, ?, ?)', | ||
| 288 | [1, 2, 3], | ||
| 289 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER], | ||
| 290 | ], | ||
| 291 | // Named parameters: One non-list before d one after list-needle | ||
| 292 | [ | ||
| 293 | 'SELECT * FROM Foo WHERE foo = :foo AND bar IN (:bar)', | ||
| 294 | ['foo' => 'string', 'bar' => [1, 2, 3]], | ||
| 295 | ['foo' => ParameterType::STRING, 'bar' => Connection::PARAM_INT_ARRAY], | ||
| 296 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?, ?, ?)', | ||
| 297 | ['string', 1, 2, 3], | ||
| 298 | [ParameterType::STRING, ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER], | ||
| 299 | ], | ||
| 300 | // Named parameters: One non-list after list-needle | ||
| 301 | [ | ||
| 302 | 'SELECT * FROM Foo WHERE bar IN (:bar) AND baz = :baz', | ||
| 303 | ['bar' => [1, 2, 3], 'baz' => 'foo'], | ||
| 304 | ['bar' => Connection::PARAM_INT_ARRAY, 'baz' => ParameterType::STRING], | ||
| 305 | 'SELECT * FROM Foo WHERE bar IN (?, ?, ?) AND baz = ?', | ||
| 306 | [1, 2, 3, 'foo'], | ||
| 307 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::STRING], | ||
| 308 | ], | ||
| 309 | // Named parameters: One non-list before and one after list-needle | ||
| 310 | [ | ||
| 311 | 'SELECT * FROM Foo WHERE foo = :foo AND bar IN (:bar) AND baz = :baz', | ||
| 312 | ['bar' => [1, 2, 3],'foo' => 1, 'baz' => 4], | ||
| 313 | ['bar' => Connection::PARAM_INT_ARRAY, 'foo' => ParameterType::INTEGER, 'baz' => ParameterType::INTEGER], | ||
| 314 | 'SELECT * FROM Foo WHERE foo = ? AND bar IN (?, ?, ?) AND baz = ?', | ||
| 315 | [1, 1, 2, 3, 4], | ||
| 316 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER], | ||
| 317 | ], | ||
| 318 | // Named parameters: Two lists | ||
| 319 | [ | ||
| 320 | 'SELECT * FROM Foo WHERE foo IN (:a, :b)', | ||
| 321 | ['b' => [4, 5],'a' => [1, 2, 3]], | ||
| 322 | ['a' => Connection::PARAM_INT_ARRAY, 'b' => Connection::PARAM_INT_ARRAY], | ||
| 323 | 'SELECT * FROM Foo WHERE foo IN (?, ?, ?, ?, ?)', | ||
| 324 | [1, 2, 3, 4, 5], | ||
| 325 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER], | ||
| 326 | ], | ||
| 327 | // Named parameters : With the same name arg type string | ||
| 328 | [ | ||
| 329 | 'SELECT * FROM Foo WHERE foo <> :arg AND bar = :arg', | ||
| 330 | ['arg' => 'Some String'], | ||
| 331 | ['arg' => ParameterType::STRING], | ||
| 332 | 'SELECT * FROM Foo WHERE foo <> ? AND bar = ?', | ||
| 333 | ['Some String','Some String'], | ||
| 334 | [ParameterType::STRING,ParameterType::STRING], | ||
| 335 | ], | ||
| 336 | // Named parameters : With the same name arg | ||
| 337 | [ | ||
| 338 | 'SELECT * FROM Foo WHERE foo IN (:arg) AND NOT bar IN (:arg)', | ||
| 339 | ['arg' => [1, 2, 3]], | ||
| 340 | ['arg' => Connection::PARAM_INT_ARRAY], | ||
| 341 | 'SELECT * FROM Foo WHERE foo IN (?, ?, ?) AND NOT bar IN (?, ?, ?)', | ||
| 342 | [1, 2, 3, 1, 2, 3], | ||
| 343 | [ParameterType::INTEGER,ParameterType::INTEGER, ParameterType::INTEGER,ParameterType::INTEGER,ParameterType::INTEGER, ParameterType::INTEGER], | ||
| 344 | ], | ||
| 345 | |||
| 346 | // Named parameters : Same name, other name in between DBAL-299 | ||
| 347 | [ | ||
| 348 | 'SELECT * FROM Foo WHERE (:foo = 2) AND (:bar = 3) AND (:foo = 2)', | ||
| 349 | ['foo' => 2,'bar' => 3], | ||
| 350 | ['foo' => ParameterType::INTEGER,'bar' => ParameterType::INTEGER], | ||
| 351 | 'SELECT * FROM Foo WHERE (? = 2) AND (? = 3) AND (? = 2)', | ||
| 352 | [2, 3, 2], | ||
| 353 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::INTEGER], | ||
| 354 | ], | ||
| 355 | // Named parameters : Empty "integer" array DDC-1978 | ||
| 356 | [ | ||
| 357 | 'SELECT * FROM Foo WHERE foo IN (:foo)', | ||
| 358 | ['foo' => []], | ||
| 359 | ['foo' => Connection::PARAM_INT_ARRAY], | ||
| 360 | 'SELECT * FROM Foo WHERE foo IN (NULL)', | ||
| 361 | [], | ||
| 362 | [], | ||
| 363 | ], | ||
| 364 | // Named parameters : Two empty "str" array DDC-1978 | ||
| 365 | [ | ||
| 366 | 'SELECT * FROM Foo WHERE foo IN (:foo) OR bar IN (:bar)', | ||
| 367 | ['foo' => [], 'bar' => []], | ||
| 368 | ['foo' => Connection::PARAM_STR_ARRAY, 'bar' => Connection::PARAM_STR_ARRAY], | ||
| 369 | 'SELECT * FROM Foo WHERE foo IN (NULL) OR bar IN (NULL)', | ||
| 370 | [], | ||
| 371 | [], | ||
| 372 | ], | ||
| 373 | [ | ||
| 374 | 'SELECT * FROM Foo WHERE foo IN (:foo) OR bar = :bar OR baz = :baz', | ||
| 375 | ['foo' => [1, 2], 'bar' => 'bar', 'baz' => 'baz'], | ||
| 376 | ['foo' => Connection::PARAM_INT_ARRAY, 'baz' => 'string'], | ||
| 377 | 'SELECT * FROM Foo WHERE foo IN (?, ?) OR bar = ? OR baz = ?', | ||
| 378 | [1, 2, 'bar', 'baz'], | ||
| 379 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::STRING, 'string'], | ||
| 380 | ], | ||
| 381 | [ | ||
| 382 | 'SELECT * FROM Foo WHERE foo IN (:foo) OR bar = :bar', | ||
| 383 | ['foo' => [1, 2], 'bar' => 'bar'], | ||
| 384 | ['foo' => Connection::PARAM_INT_ARRAY], | ||
| 385 | 'SELECT * FROM Foo WHERE foo IN (?, ?) OR bar = ?', | ||
| 386 | [1, 2, 'bar'], | ||
| 387 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::STRING], | ||
| 388 | ], | ||
| 389 | // Params/types with colons | ||
| 390 | [ | ||
| 391 | 'SELECT * FROM Foo WHERE foo = :foo OR bar = :bar', | ||
| 392 | [':foo' => 'foo', ':bar' => 'bar'], | ||
| 393 | [':foo' => ParameterType::INTEGER], | ||
| 394 | 'SELECT * FROM Foo WHERE foo = ? OR bar = ?', | ||
| 395 | ['foo', 'bar'], | ||
| 396 | [ParameterType::INTEGER, ParameterType::STRING], | ||
| 397 | ], | ||
| 398 | [ | ||
| 399 | 'SELECT * FROM Foo WHERE foo = :foo OR bar = :bar', | ||
| 400 | [':foo' => 'foo', ':bar' => 'bar'], | ||
| 401 | [':foo' => ParameterType::INTEGER, 'bar' => ParameterType::INTEGER], | ||
| 402 | 'SELECT * FROM Foo WHERE foo = ? OR bar = ?', | ||
| 403 | ['foo', 'bar'], | ||
| 404 | [ParameterType::INTEGER, ParameterType::INTEGER], | ||
| 405 | ], | ||
| 406 | [ | ||
| 407 | 'SELECT * FROM Foo WHERE foo IN (:foo) OR bar = :bar', | ||
| 408 | [':foo' => [1, 2], ':bar' => 'bar'], | ||
| 409 | ['foo' => Connection::PARAM_INT_ARRAY], | ||
| 410 | 'SELECT * FROM Foo WHERE foo IN (?, ?) OR bar = ?', | ||
| 411 | [1, 2, 'bar'], | ||
| 412 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::STRING], | ||
| 413 | ], | ||
| 414 | [ | ||
| 415 | 'SELECT * FROM Foo WHERE foo IN (:foo) OR bar = :bar', | ||
| 416 | ['foo' => [1, 2], 'bar' => 'bar'], | ||
| 417 | [':foo' => Connection::PARAM_INT_ARRAY], | ||
| 418 | 'SELECT * FROM Foo WHERE foo IN (?, ?) OR bar = ?', | ||
| 419 | [1, 2, 'bar'], | ||
| 420 | [ParameterType::INTEGER, ParameterType::INTEGER, ParameterType::STRING], | ||
| 421 | ], | ||
| 422 | // DBAL-522 - null valued parameters are not considered | ||
| 423 | [ | ||
| 424 | 'INSERT INTO Foo (foo, bar) values (:foo, :bar)', | ||
| 425 | ['foo' => 1, 'bar' => null], | ||
| 426 | [':foo' => ParameterType::INTEGER, ':bar' => ParameterType::NULL], | ||
| 427 | 'INSERT INTO Foo (foo, bar) values (?, ?)', | ||
| 428 | [1, null], | ||
| 429 | [ParameterType::INTEGER, ParameterType::NULL], | ||
| 430 | ], | ||
| 431 | [ | ||
| 432 | 'INSERT INTO Foo (foo, bar) values (?, ?)', | ||
| 433 | [1, null], | ||
| 434 | [ParameterType::INTEGER, ParameterType::NULL], | ||
| 435 | 'INSERT INTO Foo (foo, bar) values (?, ?)', | ||
| 436 | [1, null], | ||
| 437 | [ParameterType::INTEGER, ParameterType::NULL], | ||
| 438 | ], | ||
| 439 | // DBAL-1205 - Escaped single quotes SQL- and C-Style | ||
| 440 | [ | ||
| 441 | "SELECT * FROM Foo WHERE foo = :foo||''':not_a_param''\\'' OR bar = ''':not_a_param''\\'':bar", | ||
| 442 | [':foo' => 1, ':bar' => 2], | ||
| 443 | [':foo' => ParameterType::INTEGER, 'bar' => ParameterType::INTEGER], | ||
| 444 | 'SELECT * FROM Foo WHERE foo = ?||\'\'\':not_a_param\'\'\\\'\' OR bar = \'\'\':not_a_param\'\'\\\'\'?', | ||
| 445 | [1, 2], | ||
| 446 | [ParameterType::INTEGER, ParameterType::INTEGER], | ||
| 447 | ], | ||
| 527 |