Connection::lastInsertId() - Code Metrics - Inspection of "Extract getSequenceNumber() from lastInsertId()" - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#3759)

by Benjamin

created 2019-12-01 21:46 UTC

Connection::lastInsertId() A

↳ Parent: Connection

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.1481

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	5
dl	0
loc	10
ccs	4
cts	6
cp	0.6667
rs	10
c	1
b	0
f	0
cc	2
nc	2
nop	1
crap	2.1481

<?php

declare(strict_types=1);

namespace Doctrine\DBAL\Driver\PDOSqlsrv;

use Doctrine\DBAL\Driver\PDOConnection;
use Doctrine\DBAL\Driver\PDOException;
use Doctrine\DBAL\Driver\PDOStatement;
use function strpos;
use function substr;

/**
 * Sqlsrv Connection implementation.
 */
class Connection extends PDOConnection
{
    /**
     * {@inheritDoc}
     */
    public function getSequenceNumber(string $name) : string
    {
        $stmt = $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?');
        $stmt->execute([$name]);

        $sequenceNumber = $stmt->fetchColumn();

        if ($sequenceNumber === false) {
            throw new PDOException('No sequence with name "' . $name . '" found.');
        }

        return (string) $sequenceNumber;
    }

    /**
     * {@inheritDoc}
     */
    public function quote(string $input) : string
    {
        $val = parent::quote($input);

        // Fix for a driver version terminating all values with null byte
        if (strpos($val, "\0") !== false) {
            $val = substr($val, 0, -1);
        }

        return $val;
    }

    /**
     * {@inheritDoc}
     */
    protected function createStatement(\PDOStatement $stmt) : PDOStatement
    {
        return new Statement($stmt);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\DBAL\Driver\PDOSqlsrv;
6
7		use Doctrine\DBAL\Driver\PDOConnection;
8		use Doctrine\DBAL\Driver\PDOException;
9		use Doctrine\DBAL\Driver\PDOStatement;
10		use function strpos;
11		use function substr;
12
13		/**
14		* Sqlsrv Connection implementation.
15		*/
16		class Connection extends PDOConnection
17		{
18		/**
19	42	* {@inheritDoc}
20		*/
21	42	public function getSequenceNumber(string $name) : string
22	42	{
23	42	$stmt = $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?');
24		$stmt->execute([$name]);
25
26		$sequenceNumber = $stmt->fetchColumn();
27
28	3	if ($sequenceNumber === false) {
29		throw new PDOException('No sequence with name "' . $name . '" found.');
30	3	}
31	3
32		return (string) $sequenceNumber;
33		}
34	2
35	2	/**
36		* {@inheritDoc}
37	2	*/
38		public function quote(string $input) : string
39		{
40		$val = parent::quote($input);
41
42		// Fix for a driver version terminating all values with null byte
43	31	if (strpos($val, "\0") !== false) {
44		$val = substr($val, 0, -1);
45	31	}
46
47		return $val;
48	31	}
49
50		/**
51		* {@inheritDoc}
52	31	*/
53		protected function createStatement(\PDOStatement $stmt) : PDOStatement
54		{
55		return new Statement($stmt);
56		}
57		}
58

doctrine / dbal

Pull Request — master (#3759)

Connection::lastInsertId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like