doctrine / dbal

lib/Doctrine/DBAL/Driver/OCI8/OCI8Connection.php

Unused Use Statements -1 removed lines

@@ -21,7 +21,6 @@
 
 use Doctrine\DBAL\Driver\Connection;
 use Doctrine\DBAL\Driver\ServerInfoAwareConnection;
-use Doctrine\DBAL\Platforms\OraclePlatform;
 
 /**
  * OCI8 implementation of the Connection interface.

tests/Doctrine/Tests/DBAL/Driver/AbstractDriverTest.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Doctrine\DBAL\Driver\ExceptionConverterDriver;
 use Doctrine\DBAL\VersionAwarePlatformDriver;
 use Doctrine\Tests\DbalTestCase;
-use Throwable;
 
 abstract class AbstractDriverTest extends DbalTestCase
 {

lib/Doctrine/DBAL/Platforms/AbstractPlatform.php

Doc Comments +7 added lines, -7 removed lines

@@ -487,7 +487,7 @@ 
     /**
      * Marks this type as to be commented in ALTER TABLE and CREATE TABLE statements.
      *
-     * @param string|\Doctrine\DBAL\Types\Type $doctrineType
+     * @param Type $doctrineType
      *
      * @return void
      */
@@ -603,7 +603,7 @@ 
     /**
      * Gets all SQL wildcard characters of the platform.
      *
-     * @return array
+     * @return string[]
      */
     public function getWildcards()
     {
@@ -855,7 +855,7 @@ 
      *
      * @param string          $str      Literal string.
      * @param string          $substr   Literal string to find.
-     * @param integer|boolean $startPos Position to start at, beginning of string by default.
+     * @param integer $startPos Position to start at, beginning of string by default.
      *
      * @return string
      *
@@ -1416,7 +1416,7 @@ 
     /**
      * Returns the SQL to safely drop a temporary table WITHOUT implicitly committing an open transaction.
      *
-     * @param \Doctrine\DBAL\Schema\Table|string $table
+     * @param string $table
      *
      * @return string
      */
@@ -1639,7 +1639,7 @@ 
      * @param array  $columns
      * @param array  $options
      *
-     * @return array
+     * @return string[]
      */
     protected function _getCreateTableSQL($tableName, array $columns, array $options = [])
     {
@@ -1822,7 +1822,7 @@ 
      * Returns the SQL to create an unnamed primary key constraint.
      *
      * @param \Doctrine\DBAL\Schema\Index        $index
-     * @param \Doctrine\DBAL\Schema\Table|string $table
+     * @param string $table
      *
      * @return string
      */
@@ -2120,7 +2120,7 @@ 
      * @param \Doctrine\DBAL\Schema\Index $index        The definition of the index to rename to.
      * @param string                      $tableName    The table to rename the given index on.
      *
-     * @return array The sequence of SQL statements for renaming the given index.
+     * @return string[] The sequence of SQL statements for renaming the given index.
      */
     protected function getRenameIndexSQL($oldIndexName, Index $index, $tableName)
     {

lib/Doctrine/DBAL/Connection.php

Doc Comments +3 added lines, -3 removed lines

@@ -581,7 +581,7 @@ 
      * @param integer $column    The 0-indexed column number to retrieve.
      * @param array  $types      The query parameter types.
      *
-     * @return mixed|bool False is returned if no rows are found.
+     * @return string|boolean False is returned if no rows are found.
      *
      * @throws \Doctrine\DBAL\DBALException
      */
@@ -1126,7 +1126,7 @@ 
     /**
      * Fetches the SQLSTATE associated with the last database operation.
      *
-     * @return integer The last error code.
+     * @return string|null The last error code.
      */
     public function errorCode()
     {
@@ -1233,7 +1233,7 @@ 
      * Returns the savepoint name to use for nested transactions are false if they are not supported
      * "savepointFormat" parameter is not set
      *
-     * @return mixed A string with the savepoint name or false.
+     * @return string A string with the savepoint name or false.
      */
     protected function _getNestedTransactionSavePointName()
     {

tests/Doctrine/Tests/DBAL/Functional/BlobTest.php

Doc Comments +6 added lines

@@ -74,6 +74,9 @@ 
         $this->assertBinaryContains('test2');
     }
 
+    /**
+     * @param string $text
+     */
     private function assertBinaryContains($text)
     {
         $rows = $this->_conn->fetchAll('SELECT * FROM blob_table');
@@ -87,6 +90,9 @@ 
         self::assertEquals($text, stream_get_contents($blobValue));
     }
 
+    /**
+     * @param string $text
+     */
     private function assertBlobContains($text)
     {
         $rows = $this->_conn->fetchAll('SELECT * FROM blob_table');

tests/Doctrine/Tests/DBAL/Functional/ResultCacheTest.php

Doc Comments +6 added lines

@@ -185,6 +185,9 @@ 
         self::assertEquals(1, count($secondCache->fetch("emptycachekey")));
     }
 
+    /**
+     * @param \Doctrine\DBAL\Driver\Statement $stmt
+     */
     private function hydrateStmt($stmt, $fetchMode = \PDO::FETCH_ASSOC)
     {
         $data = array();
@@ -195,6 +198,9 @@ 
         return $data;
     }
 
+    /**
+     * @param \Doctrine\DBAL\Driver\Statement $stmt
+     */
     private function hydrateStmtIterator($stmt, $fetchMode = \PDO::FETCH_ASSOC)
     {
         $data = array();

tests/Doctrine/Tests/DBAL/Platforms/AbstractPlatformTestCase.php

Doc Comments +8 added lines

@@ -273,6 +273,10 @@ 
         }
     }
 
+    /**
+     * @param integer $value1
+     * @param integer $value2
+     */
     protected function getBitAndComparisonExpressionSql($value1, $value2)
     {
         return '(' . $value1 . ' & ' . $value2 . ')';
@@ -287,6 +291,10 @@ 
         self::assertEquals($this->getBitAndComparisonExpressionSql(2, 4), $sql);
     }
 
+    /**
+     * @param integer $value1
+     * @param integer $value2
+     */
     protected  function getBitOrComparisonExpressionSql($value1, $value2)
     {
         return '(' . $value1 . ' | ' . $value2 . ')';