Connection.php$0 ➔ lastInsertId() - Code Metrics - Inspection of "DBAL 3.0: suggestions to improve the Driver\Connec..." - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — develop (#3335)

unknown

created 2018-11-25 17:09 UTC

Connection.php$0 ➔ lastInsertId() A

↳ Parent: Connection

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3.1825

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	8
cts	11
cp	0.7272
rs	9.6333
c	0
b	0
f	0
cc	3
crap	3.1825

<?php

namespace Doctrine\DBAL\Driver\PDOSqlsrv;

use Doctrine\DBAL\Driver\AbstractDriverException;
use Doctrine\DBAL\Driver\PDOConnection;
use Doctrine\DBAL\Driver\PDOStatement;
use function strpos;
use function substr;

/**
 * Sqlsrv Connection implementation.
 */
class Connection extends PDOConnection implements \Doctrine\DBAL\Driver\Connection
{
    /**
     * {@inheritDoc}
     */
    public function lastInsertId(?string $name = null) : string
    {
        if ($name === null) {
            return parent::lastInsertId($name);
        }

        $stmt = $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?');
        $stmt->execute([$name]);

        $result = $stmt->fetchColumn();

        if ($result === false) {
            // WIP regarding exceptions, see:
            // https://github.com/doctrine/dbal/pull/3335#discussion_r234381175
            throw new class ('No sequence with name "' . $name . '" found.') extends AbstractDriverException {
            };
        }

        return (string) $result;
    }

    /**
     * {@inheritDoc}
     */
    public function quote(string $value) : string
    {
        $val = parent::quote($value);

        // Fix for a driver version terminating all values with null byte
        if (strpos($val, "\0") !== false) {
            $val = substr($val, 0, -1);
        }

        return $val;
    }

    /**
     * {@inheritDoc}
     */
    protected function createStatement(\PDOStatement $stmt) : PDOStatement
    {
        return new Statement($stmt);
    }
}


1		<?php
2
3		namespace Doctrine\DBAL\Driver\PDOSqlsrv;
4
5		use Doctrine\DBAL\Driver\AbstractDriverException;
6		use Doctrine\DBAL\Driver\PDOConnection;
7		use Doctrine\DBAL\Driver\PDOStatement;
8		use function strpos;
9		use function substr;
10
11		/**
12		* Sqlsrv Connection implementation.
13		*/
14		class Connection extends PDOConnection implements \Doctrine\DBAL\Driver\Connection
15		{
16		/**
17		* {@inheritDoc}
18		*/
19	3	public function lastInsertId(?string $name = null) : string
20		{
21	3	if ($name === null) {
22	2	return parent::lastInsertId($name);
23		}
24
25	1	$stmt = $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?');
26	1	$stmt->execute([$name]);
27
28	1	$result = $stmt->fetchColumn();
29
30	1	if ($result === false) {
31		// WIP regarding exceptions, see:
32		// https://github.com/doctrine/dbal/pull/3335#discussion_r234381175
33		throw new class ('No sequence with name "' . $name . '" found.') extends AbstractDriverException {
34		};
35		}
36
37	1	return (string) $result;
38		}
39
40		/**
41		* {@inheritDoc}
42		*/
43	7	public function quote(string $value) : string
44		{
45	7	$val = parent::quote($value);
46
47		// Fix for a driver version terminating all values with null byte
48	7	if (strpos($val, "\0") !== false) {
49		$val = substr($val, 0, -1);
50		}
51
52	7	return $val;
53		}
54
55		/**
56		* {@inheritDoc}
57		*/
58	245	protected function createStatement(\PDOStatement $stmt) : PDOStatement
59		{
60	245	return new Statement($stmt);
61		}
62		}
63

doctrine / dbal

Pull Request — develop (#3335)

Connection.php$0 ➔ lastInsertId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like