SimpleArrayTest::testArrayConvertsToPHPValue() - Code Metrics - Inspection of "Provide for existing type to be of same output typ..." - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3291)

by Tom

created 2018-11-23 22:19 UTC

SimpleArrayTest::testArrayConvertsToPHPValue() A

↳ Parent: SimpleArrayTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	3
dl	0
loc	5
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Doctrine\Tests\DBAL\Types;

use Doctrine\DBAL\Platforms\AbstractPlatform;
use Doctrine\DBAL\Types\Type;
use Doctrine\Tests\DBAL\Mocks\MockPlatform;
use Doctrine\Tests\DbalTestCase;

class SimpleArrayTest extends DbalTestCase
{
    /** @var AbstractPlatform */
    private $platform;

    /** @var Type */
    private $type;

    protected function setUp()
    {
        $this->platform = new MockPlatform();
        $this->type     = Type::getType('simple_array');
    }

    public function testArrayConvertsToDatabaseValue()
    {
        self::assertInternalType(
            'string',
            $this->type->convertToDatabaseValue(['one', 'two', 'three'], $this->platform)
        );
    }

    public function testArrayConvertsToPHPValue()
    {
        self::assertInternalType(
            'array',
            $this->type->convertToPHPValue('one,two,three', $this->platform)
        );
    }

    public function testArrayNormalizesToPHPValue()
    {
        self::assertInternalType(
            'array',
            $this->type->normalizeToPHPValue([], $this->platform)
        );

        self::assertInternalType(
            'null',
            $this->type->normalizeToPHPValue(null, $this->platform)
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        );

        self::assertInternalType(
            'array',
            $this->type->convertToPHPValue('one,two,three', $this->platform)
        );
    }

    public function testNullConversion()
    {
        self::assertNull($this->type->convertToPHPValue(null, $this->platform));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }
}


1			<?php
2
3			namespace Doctrine\Tests\DBAL\Types;
4
5			use Doctrine\DBAL\Platforms\AbstractPlatform;
6			use Doctrine\DBAL\Types\Type;
7			use Doctrine\Tests\DBAL\Mocks\MockPlatform;
8			use Doctrine\Tests\DbalTestCase;
9
10			class SimpleArrayTest extends DbalTestCase
11			{
12			/** @var AbstractPlatform */
13			private $platform;
14
15			/** @var Type */
16			private $type;
17
18			protected function setUp()
19			{
20			$this->platform = new MockPlatform();
21			$this->type = Type::getType('simple_array');
22			}
23
24			public function testArrayConvertsToDatabaseValue()
25			{
26			self::assertInternalType(
27			'string',
28			$this->type->convertToDatabaseValue(['one', 'two', 'three'], $this->platform)
29			);
30			}
31
32			public function testArrayConvertsToPHPValue()
33			{
34			self::assertInternalType(
35			'array',
36			$this->type->convertToPHPValue('one,two,three', $this->platform)
37			);
38			}
39
40			public function testArrayNormalizesToPHPValue()
41			{
42			self::assertInternalType(
43			'array',
44			$this->type->normalizeToPHPValue([], $this->platform)
45			);
46
47			self::assertInternalType(
48			'null',
49			$this->type->normalizeToPHPValue(null, $this->platform)
			0 ignored issues – show Bug introduced 2018-11-23 21:53 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->type->normalizeTo...(null, $this->platform)` targeting `Doctrine\DBAL\Types\Type::normalizeToPHPValue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
50			);
51
52			self::assertInternalType(
53			'array',
54			$this->type->convertToPHPValue('one,two,three', $this->platform)
55			);
56			}
57
58			public function testNullConversion()
59			{
60			self::assertNull($this->type->convertToPHPValue(null, $this->platform));
			0 ignored issues – show Bug introduced 2018-09-27 07:35 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->type->convertToPH...(null, $this->platform)` targeting `Doctrine\DBAL\Types\Type::convertToPHPValue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
61			}
62			}
63

doctrine / dbal

Pull Request — master (#3291)

SimpleArrayTest::testArrayConvertsToPHPValue() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like