Connection::lastInsertId() - Code Metrics - Inspection of "Fix DebugStack#queries docblock type" - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 2.10 (#3812)

by Gabriel

created 2020-01-05 14:55 UTC

Connection::lastInsertId() A

↳ Parent: Connection

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2.0625

Importance

Changes

Metric	Value
eloc	5
dl	0
loc	10
ccs	6
cts	8
cp	0.75
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2.0625

<?php

namespace Doctrine\DBAL\Driver\PDOSqlsrv;

use Doctrine\DBAL\Driver\PDOConnection;
use Doctrine\DBAL\ParameterType;
use PDO;
use function strpos;
use function substr;

/**
 * Sqlsrv Connection implementation.
 */
class Connection extends PDOConnection
{
    /**
     * {@inheritdoc}
     */
    public function __construct($dsn, $user = null, $password = null, ?array $options = null)
    {
        parent::__construct($dsn, $user, $password, $options);
        $this->setAttribute(PDO::ATTR_STATEMENT_CLASS, [Statement::class, []]);
    }

    /**
     * {@inheritDoc}
     */
    public function lastInsertId($name = null)
    {
        if ($name === null) {
            return parent::lastInsertId($name);
        }

        $stmt = $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?');
        $stmt->execute([$name]);

        return $stmt->fetchColumn();
    }

    /**
     * {@inheritDoc}
     */
    public function quote($value, $type = ParameterType::STRING)
    {
        $val = parent::quote($value, $type);

        // Fix for a driver version terminating all values with null byte
        if (strpos($val, "\0") !== false) {
            $val = substr($val, 0, -1);
        }

        return $val;
    }
}


1		<?php
2
3		namespace Doctrine\DBAL\Driver\PDOSqlsrv;
4
5		use Doctrine\DBAL\Driver\PDOConnection;
6		use Doctrine\DBAL\ParameterType;
7		use PDO;
8		use function strpos;
9		use function substr;
10
11		/**
12		* Sqlsrv Connection implementation.
13		*/
14		class Connection extends PDOConnection
15		{
16		/**
17		* {@inheritdoc}
18		*/
19	41	public function __construct($dsn, $user = null, $password = null, ?array $options = null)
20		{
21	41	parent::__construct($dsn, $user, $password, $options);
22	41	$this->setAttribute(PDO::ATTR_STATEMENT_CLASS, [Statement::class, []]);
23	41	}
24
25		/**
26		* {@inheritDoc}
27		*/
28	3	public function lastInsertId($name = null)
29		{
30	3	if ($name === null) {
31	3	return parent::lastInsertId($name);
32		}
33
34	2	$stmt = $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?');
35	2	$stmt->execute([$name]);
36
37	2	return $stmt->fetchColumn();
38		}
39
40		/**
41		* {@inheritDoc}
42		*/
43	30	public function quote($value, $type = ParameterType::STRING)
44		{
45	30	$val = parent::quote($value, $type);
46
47		// Fix for a driver version terminating all values with null byte
48	30	if (strpos($val, "\0") !== false) {
49		$val = substr($val, 0, -1);
50		}
51
52	30	return $val;
53		}
54		}
55

doctrine / dbal

Pull Request — 2.10 (#3812)

Connection::lastInsertId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like