PoolingShardManagerTest::testSelectShard() - Code Metrics - Inspection of "Merge pull request #3303 from morozov/doctrine-cod..." - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 9355a2...379085 )

by Sergei

created 2018-09-28 18:49 UTC

PoolingShardManagerTest::testSelectShard() A

↳ Parent: PoolingShardManagerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	7
dl	0
loc	11
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php
/*
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the LGPL. For more information, see
 * <http://www.doctrine-project.org>.
 */
namespace Doctrine\Tests\DBAL\Sharding;

use Doctrine\DBAL\Sharding\PoolingShardConnection;
use Doctrine\DBAL\Sharding\PoolingShardManager;
use Doctrine\DBAL\Sharding\ShardChoser\ShardChoser;
use PHPUnit\Framework\TestCase;

class PoolingShardManagerTest extends TestCase
{
    private function createConnectionMock()
    {
        return $this->getMockBuilder(PoolingShardConnection::class)
            ->setMethods(['connect', 'getParams', 'fetchAll'])
            ->disableOriginalConstructor()
            ->getMock();
    }

    private function createPassthroughShardChoser()
    {
        $mock = $this->createMock(ShardChoser::class);
        $mock->expects($this->any())
             ->method('pickShard')
             ->will($this->returnCallback(static function ($value) {
                return $value;
             }));
        return $mock;
    }

    private function createStaticShardChooser()
    {
        $mock = $this->createMock(ShardChoser::class);
        $mock->expects($this->any())
            ->method('pickShard')
            ->willReturn(1);
        return $mock;
    }

    public function testSelectGlobal()
    {
        $conn = $this->createConnectionMock();
        $conn->expects($this->once())->method('connect')->with($this->equalTo(0));

        $shardManager = new PoolingShardManager($conn);
        $shardManager->selectGlobal();

        self::assertNull($shardManager->getCurrentDistributionValue());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    public function testSelectShard()
    {
        $shardId = 10;
        $conn    = $this->createConnectionMock();
        $conn->expects($this->at(0))->method('getParams')->will($this->returnValue(['shardChoser' => $this->createPassthroughShardChoser()]));
        $conn->expects($this->at(1))->method('connect')->with($this->equalTo($shardId));

        $shardManager = new PoolingShardManager($conn);
        $shardManager->selectShard($shardId);

        self::assertEquals($shardId, $shardManager->getCurrentDistributionValue());
    }

    public function testGetShards()
    {
        $conn = $this->createConnectionMock();
        $conn->expects($this->any())->method('getParams')->will(
            $this->returnValue(
                ['shards' => [ ['id' => 1], ['id' => 2] ], 'shardChoser' => $this->createPassthroughShardChoser()]
            )
        );

        $shardManager = new PoolingShardManager($conn);
        $shards       = $shardManager->getShards();

        self::assertEquals([['id' => 1], ['id' => 2]], $shards);
    }

    public function testQueryAll()
    {
        $sql    = 'SELECT * FROM table';
        $params = [1];
        $types  = [1];

        $conn = $this->createConnectionMock();
        $conn->expects($this->at(0))->method('getParams')->will($this->returnValue(
            ['shards' => [ ['id' => 1], ['id' => 2] ], 'shardChoser' => $this->createPassthroughShardChoser()]
        ));
        $conn->expects($this->at(1))->method('getParams')->will($this->returnValue(
            ['shards' => [ ['id' => 1], ['id' => 2] ], 'shardChoser' => $this->createPassthroughShardChoser()]
        ));
        $conn->expects($this->at(2))->method('connect')->with($this->equalTo(1));
        $conn->expects($this->at(3))
             ->method('fetchAll')
             ->with($this->equalTo($sql), $this->equalTo($params), $this->equalTo($types))
             ->will($this->returnValue([ ['id' => 1] ]));
        $conn->expects($this->at(4))->method('connect')->with($this->equalTo(2));
        $conn->expects($this->at(5))
             ->method('fetchAll')
             ->with($this->equalTo($sql), $this->equalTo($params), $this->equalTo($types))
             ->will($this->returnValue([ ['id' => 2] ]));

        $shardManager = new PoolingShardManager($conn);
        $result       = $shardManager->queryAll($sql, $params, $types);

        self::assertEquals([['id' => 1], ['id' => 2]], $result);
    }

    public function testQueryAllWithStaticShardChoser()
    {
        $sql    = 'SELECT * FROM table';
        $params = [1];
        $types  = [1];

        $conn = $this->createConnectionMock();
        $conn->expects($this->at(0))->method('getParams')->will($this->returnValue(
            ['shards' => [ ['id' => 1], ['id' => 2] ], 'shardChoser' => $this->createStaticShardChooser()]
        ));
        $conn->expects($this->at(1))->method('getParams')->will($this->returnValue(
            ['shards' => [ ['id' => 1], ['id' => 2] ], 'shardChoser' => $this->createStaticShardChooser()]
        ));
        $conn->expects($this->at(2))->method('connect')->with($this->equalTo(1));
        $conn->expects($this->at(3))
            ->method('fetchAll')
            ->with($this->equalTo($sql), $this->equalTo($params), $this->equalTo($types))
            ->will($this->returnValue([ ['id' => 1] ]));
        $conn->expects($this->at(4))->method('connect')->with($this->equalTo(2));
        $conn->expects($this->at(5))
            ->method('fetchAll')
            ->with($this->equalTo($sql), $this->equalTo($params), $this->equalTo($types))
            ->will($this->returnValue([ ['id' => 2] ]));

        $shardManager = new PoolingShardManager($conn);
        $result       = $shardManager->queryAll($sql, $params, $types);

        self::assertEquals([['id' => 1], ['id' => 2]], $result);
    }
}


1			<?php
2			/*
3			* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
4			* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
5			* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
6			* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
7			* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
8			* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
9			* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
10			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
11			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
12			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
13			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
14			*
15			* This software consists of voluntary contributions made by many individuals
16			* and is licensed under the LGPL. For more information, see
17			* <http://www.doctrine-project.org>.
18			*/
19			namespace Doctrine\Tests\DBAL\Sharding;
20
21			use Doctrine\DBAL\Sharding\PoolingShardConnection;
22			use Doctrine\DBAL\Sharding\PoolingShardManager;
23			use Doctrine\DBAL\Sharding\ShardChoser\ShardChoser;
24			use PHPUnit\Framework\TestCase;
25
26			class PoolingShardManagerTest extends TestCase
27			{
28			private function createConnectionMock()
29			{
30			return $this->getMockBuilder(PoolingShardConnection::class)
31			->setMethods(['connect', 'getParams', 'fetchAll'])
32			->disableOriginalConstructor()
33			->getMock();
34			}
35
36			private function createPassthroughShardChoser()
37			{
38			$mock = $this->createMock(ShardChoser::class);
39			$mock->expects($this->any())
40			->method('pickShard')
41			->will($this->returnCallback(static function ($value) {
42			return $value;
43			}));
44			return $mock;
45			}
46
47			private function createStaticShardChooser()
48			{
49			$mock = $this->createMock(ShardChoser::class);
50			$mock->expects($this->any())
51			->method('pickShard')
52			->willReturn(1);
53			return $mock;
54			}
55
56			public function testSelectGlobal()
57			{
58			$conn = $this->createConnectionMock();
59			$conn->expects($this->once())->method('connect')->with($this->equalTo(0));
60
61			$shardManager = new PoolingShardManager($conn);
62			$shardManager->selectGlobal();
63
64			self::assertNull($shardManager->getCurrentDistributionValue());
			0 ignored issues – show Bug introduced 2017-12-17 13:02 UTC by Report Bug Copy Issue Report Are you sure the usage of `$shardManager->getCurrentDistributionValue()` targeting `Doctrine\DBAL\Sharding\P...rentDistributionValue()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
65			}
66
67			public function testSelectShard()
68			{
69			$shardId = 10;
70			$conn = $this->createConnectionMock();
71			$conn->expects($this->at(0))->method('getParams')->will($this->returnValue(['shardChoser' => $this->createPassthroughShardChoser()]));
72			$conn->expects($this->at(1))->method('connect')->with($this->equalTo($shardId));
73
74			$shardManager = new PoolingShardManager($conn);
75			$shardManager->selectShard($shardId);
76
77			self::assertEquals($shardId, $shardManager->getCurrentDistributionValue());
78			}
79
80			public function testGetShards()
81			{
82			$conn = $this->createConnectionMock();
83			$conn->expects($this->any())->method('getParams')->will(
84			$this->returnValue(
85			['shards' => [ ['id' => 1], ['id' => 2] ], 'shardChoser' => $this->createPassthroughShardChoser()]
86			)
87			);
88
89			$shardManager = new PoolingShardManager($conn);
90			$shards = $shardManager->getShards();
91
92			self::assertEquals([['id' => 1], ['id' => 2]], $shards);
93			}
94
95			public function testQueryAll()
96			{
97			$sql = 'SELECT * FROM table';
98			$params = [1];
99			$types = [1];
100
101			$conn = $this->createConnectionMock();
102			$conn->expects($this->at(0))->method('getParams')->will($this->returnValue(
103			['shards' => [ ['id' => 1], ['id' => 2] ], 'shardChoser' => $this->createPassthroughShardChoser()]
104			));
105			$conn->expects($this->at(1))->method('getParams')->will($this->returnValue(
106			['shards' => [ ['id' => 1], ['id' => 2] ], 'shardChoser' => $this->createPassthroughShardChoser()]
107			));
108			$conn->expects($this->at(2))->method('connect')->with($this->equalTo(1));
109			$conn->expects($this->at(3))
110			->method('fetchAll')
111			->with($this->equalTo($sql), $this->equalTo($params), $this->equalTo($types))
112			->will($this->returnValue([ ['id' => 1] ]));
113			$conn->expects($this->at(4))->method('connect')->with($this->equalTo(2));
114			$conn->expects($this->at(5))
115			->method('fetchAll')
116			->with($this->equalTo($sql), $this->equalTo($params), $this->equalTo($types))
117			->will($this->returnValue([ ['id' => 2] ]));
118
119			$shardManager = new PoolingShardManager($conn);
120			$result = $shardManager->queryAll($sql, $params, $types);
121
122			self::assertEquals([['id' => 1], ['id' => 2]], $result);
123			}
124
125			public function testQueryAllWithStaticShardChoser()
126			{
127			$sql = 'SELECT * FROM table';
128			$params = [1];
129			$types = [1];
130
131			$conn = $this->createConnectionMock();
132			$conn->expects($this->at(0))->method('getParams')->will($this->returnValue(
133			['shards' => [ ['id' => 1], ['id' => 2] ], 'shardChoser' => $this->createStaticShardChooser()]
134			));
135			$conn->expects($this->at(1))->method('getParams')->will($this->returnValue(
136			['shards' => [ ['id' => 1], ['id' => 2] ], 'shardChoser' => $this->createStaticShardChooser()]
137			));
138			$conn->expects($this->at(2))->method('connect')->with($this->equalTo(1));
139			$conn->expects($this->at(3))
140			->method('fetchAll')
141			->with($this->equalTo($sql), $this->equalTo($params), $this->equalTo($types))
142			->will($this->returnValue([ ['id' => 1] ]));
143			$conn->expects($this->at(4))->method('connect')->with($this->equalTo(2));
144			$conn->expects($this->at(5))
145			->method('fetchAll')
146			->with($this->equalTo($sql), $this->equalTo($params), $this->equalTo($types))
147			->will($this->returnValue([ ['id' => 2] ]));
148
149			$shardManager = new PoolingShardManager($conn);
150			$result = $shardManager->queryAll($sql, $params, $types);
151
152			self::assertEquals([['id' => 1], ['id' => 2]], $result);
153			}
154			}
155

doctrine / dbal

Push — master ( 9355a2...379085 )

PoolingShardManagerTest::testSelectShard() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like