MysqliConnectionTest::testHostnameIsRequiredForPersistentConnection() - Code Metrics - Inspection of "Manually merge 3.0.x into master" - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#3945)

by Sergei

created 2020-04-12 18:38 UTC

testHostnameIsRequiredForPersistentConnection() A

↳ Parent: MysqliConnectionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	4
rs	10

<?php

declare(strict_types=1);

namespace Doctrine\DBAL\Tests\Driver\Mysqli;

use Doctrine\DBAL\Driver\Mysqli\Exception\ConnectionError;
use Doctrine\DBAL\Driver\Mysqli\HostRequired;
use Doctrine\DBAL\Driver\Mysqli\MysqliConnection;
use Doctrine\DBAL\Platforms\MySqlPlatform;
use Doctrine\DBAL\Tests\FunctionalTestCase;
use function extension_loaded;
use function restore_error_handler;
use function set_error_handler;

class MysqliConnectionTest extends FunctionalTestCase
{
    protected function setUp() : void
    {
        if (! extension_loaded('mysqli')) {
            self::markTestSkipped('mysqli is not installed.');
        }

        parent::setUp();

        if ($this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
            return;
        }

        self::markTestSkipped('MySQL only test.');
    }

    public function testRestoresErrorHandlerOnException() : void
    {
        $handler = static function () : bool {
            self::fail('Never expected this to be called');
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
        };
        set_error_handler($handler);

        try {
            new MysqliConnection(['host' => '255.255.255.255'], 'user', 'pass');
            self::fail('An exception was supposed to be raised');
        } catch (ConnectionError $e) {
            // Do nothing
        }

        self::assertSame($handler, set_error_handler($handler), 'Restoring error handler failed.');
        restore_error_handler();
        restore_error_handler();
    }

    public function testHostnameIsRequiredForPersistentConnection() : void
    {
        $this->expectException(HostRequired::class);
        new MysqliConnection(['persistent' => 'true'], '', '');
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Doctrine\DBAL\Tests\Driver\Mysqli;
6
7			use Doctrine\DBAL\Driver\Mysqli\Exception\ConnectionError;
8			use Doctrine\DBAL\Driver\Mysqli\HostRequired;
9			use Doctrine\DBAL\Driver\Mysqli\MysqliConnection;
10			use Doctrine\DBAL\Platforms\MySqlPlatform;
11			use Doctrine\DBAL\Tests\FunctionalTestCase;
12			use function extension_loaded;
13			use function restore_error_handler;
14			use function set_error_handler;
15
16			class MysqliConnectionTest extends FunctionalTestCase
17			{
18			protected function setUp() : void
19			{
20			if (! extension_loaded('mysqli')) {
21			self::markTestSkipped('mysqli is not installed.');
22			}
23
24			parent::setUp();
25
26			if ($this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
27			return;
28			}
29
30			self::markTestSkipped('MySQL only test.');
31			}
32
33			public function testRestoresErrorHandlerOnException() : void
34			{
35			$handler = static function () : bool {
36			self::fail('Never expected this to be called');
			0 ignored issues – show Bug Best Practice introduced 2019-08-27 06:10 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `boolean`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
37			};
38			set_error_handler($handler);
39
40			try {
41			new MysqliConnection(['host' => '255.255.255.255'], 'user', 'pass');
42			self::fail('An exception was supposed to be raised');
43			} catch (ConnectionError $e) {
44			// Do nothing
45			}
46
47			self::assertSame($handler, set_error_handler($handler), 'Restoring error handler failed.');
48			restore_error_handler();
49			restore_error_handler();
50			}
51
52			public function testHostnameIsRequiredForPersistentConnection() : void
53			{
54			$this->expectException(HostRequired::class);
55			new MysqliConnection(['persistent' => 'true'], '', '');
56			}
57			}
58

doctrine / dbal

Pull Request — master (#3945)

testHostnameIsRequiredForPersistentConnection() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like