SchemaDiffTest::createPlatform() - Code Metrics - Inspection of "Bump cs libs" - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — 2.10.x (#3983)

by Grégoire

created 2020-05-02 13:47 UTC

SchemaDiffTest::createPlatform() B

↳ Parent: SchemaDiffTest

Complexity

Conditions	5
Paths	8

Size

Total Lines	63
Code Lines	53

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	53
dl	0
loc	63
rs	8.7143
c	0
b	0
f	0
cc	5
nc	8
nop	1

How to fix Long Method

<?php

namespace Doctrine\Tests\DBAL\Schema;

use Doctrine\DBAL\Platforms\AbstractPlatform;
use Doctrine\DBAL\Schema\ForeignKeyConstraint;
use Doctrine\DBAL\Schema\SchemaDiff;
use Doctrine\DBAL\Schema\Sequence;
use Doctrine\DBAL\Schema\Table;
use Doctrine\DBAL\Schema\TableDiff;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use function assert;

class SchemaDiffTest extends TestCase
{
    public function testSchemaDiffToSql() : void
    {
        $diff     = $this->createSchemaDiff();
        $platform = $this->createPlatform(true);

        $sql = $diff->toSql($platform);

        $expected = ['create_schema', 'drop_orphan_fk', 'alter_seq', 'drop_seq', 'create_seq', 'create_table', 'create_foreign_key', 'drop_table', 'alter_table'];

        self::assertEquals($expected, $sql);
    }

    public function testSchemaDiffToSaveSql() : void
    {
        $diff     = $this->createSchemaDiff();
        $platform = $this->createPlatform(false);

        $sql = $diff->toSaveSql($platform);

        $expected = ['create_schema', 'alter_seq', 'create_seq', 'create_table', 'create_foreign_key', 'alter_table'];

        self::assertEquals($expected, $sql);
    }

    /**
     * @return AbstractPlatform|MockObject
     */
    private function createPlatform(bool $unsafe)
    {
        $platform = $this->createMock(AbstractPlatform::class);
        assert($platform instanceof AbstractPlatform || $platform instanceof MockObject);
        $platform->expects($this->exactly(1))
            ->method('getCreateSchemaSQL')
            ->with('foo_ns')
            ->will($this->returnValue('create_schema'));
        if ($unsafe) {
            $platform->expects($this->exactly(1))
                 ->method('getDropSequenceSql')
                 ->with($this->isInstanceOf(Sequence::class))
                 ->will($this->returnValue('drop_seq'));
        }

        $platform->expects($this->exactly(1))
                 ->method('getAlterSequenceSql')
                 ->with($this->isInstanceOf(Sequence::class))
                 ->will($this->returnValue('alter_seq'));
        $platform->expects($this->exactly(1))
                 ->method('getCreateSequenceSql')
                 ->with($this->isInstanceOf(Sequence::class))
                 ->will($this->returnValue('create_seq'));
        if ($unsafe) {
            $platform->expects($this->exactly(1))
                     ->method('getDropTableSql')
                     ->with($this->isInstanceOf(Table::class))
                     ->will($this->returnValue('drop_table'));
        }

        $platform->expects($this->exactly(1))
                 ->method('getCreateTableSql')
                 ->with($this->isInstanceOf(Table::class))
                 ->will($this->returnValue(['create_table']));
        $platform->expects($this->exactly(1))
                 ->method('getCreateForeignKeySQL')
                 ->with($this->isInstanceOf(ForeignKeyConstraint::class))
                 ->will($this->returnValue('create_foreign_key'));
        $platform->expects($this->exactly(1))
                 ->method('getAlterTableSql')
                 ->with($this->isInstanceOf(TableDiff::class))
                 ->will($this->returnValue(['alter_table']));
        if ($unsafe) {
            $platform->expects($this->exactly(1))
                     ->method('getDropForeignKeySql')
                     ->with(
                         $this->isInstanceOf(ForeignKeyConstraint::class),
                         $this->isInstanceOf(Table::class)
                     )
                     ->will($this->returnValue('drop_orphan_fk'));
        }

        $platform->expects($this->exactly(1))
                ->method('supportsSchemas')
                ->will($this->returnValue(true));
        $platform->expects($this->exactly(1))
                ->method('supportsSequences')
                ->will($this->returnValue(true));
        $platform->expects($this->exactly(2))
                ->method('supportsForeignKeyConstraints')
                ->will($this->returnValue(true));

        return $platform;
    }

    public function createSchemaDiff() : SchemaDiff
    {
        $diff                              = new SchemaDiff();
        $diff->newNamespaces['foo_ns']     = 'foo_ns';
        $diff->removedNamespaces['bar_ns'] = 'bar_ns';
        $diff->changedSequences['foo_seq'] = new Sequence('foo_seq');
        $diff->newSequences['bar_seq']     = new Sequence('bar_seq');
        $diff->removedSequences['baz_seq'] = new Sequence('baz_seq');
        $diff->newTables['foo_table']      = new Table('foo_table');
        $diff->removedTables['bar_table']  = new Table('bar_table');
        $diff->changedTables['baz_table']  = new TableDiff('baz_table');
        $diff->newTables['foo_table']->addColumn('foreign_id', 'integer');
        $diff->newTables['foo_table']->addForeignKeyConstraint('foreign_table', ['foreign_id'], ['id']);
        $fk = new ForeignKeyConstraint(['id'], 'foreign_table', ['id']);
        $fk->setLocalTable(new Table('local_table'));
        $diff->orphanedForeignKeys[] = $fk;

        return $diff;
    }
}


1			<?php
2
3			namespace Doctrine\Tests\DBAL\Schema;
4
5			use Doctrine\DBAL\Platforms\AbstractPlatform;
6			use Doctrine\DBAL\Schema\ForeignKeyConstraint;
7			use Doctrine\DBAL\Schema\SchemaDiff;
8			use Doctrine\DBAL\Schema\Sequence;
9			use Doctrine\DBAL\Schema\Table;
10			use Doctrine\DBAL\Schema\TableDiff;
11			use PHPUnit\Framework\MockObject\MockObject;
12			use PHPUnit\Framework\TestCase;
13			use function assert;
14
15			class SchemaDiffTest extends TestCase
16			{
17			public function testSchemaDiffToSql() : void
18			{
19			$diff = $this->createSchemaDiff();
20			$platform = $this->createPlatform(true);
21
22			$sql = $diff->toSql($platform);
23
24			$expected = ['create_schema', 'drop_orphan_fk', 'alter_seq', 'drop_seq', 'create_seq', 'create_table', 'create_foreign_key', 'drop_table', 'alter_table'];
25
26			self::assertEquals($expected, $sql);
27			}
28
29			public function testSchemaDiffToSaveSql() : void
30			{
31			$diff = $this->createSchemaDiff();
32			$platform = $this->createPlatform(false);
33
34			$sql = $diff->toSaveSql($platform);
35
36			$expected = ['create_schema', 'alter_seq', 'create_seq', 'create_table', 'create_foreign_key', 'alter_table'];
37
38			self::assertEquals($expected, $sql);
39			}
40
41			/**
42			* @return AbstractPlatform\|MockObject
43			*/
44			private function createPlatform(bool $unsafe)
45			{
46			$platform = $this->createMock(AbstractPlatform::class);
47			assert($platform instanceof AbstractPlatform \|\| $platform instanceof MockObject);
48			$platform->expects($this->exactly(1))
49			->method('getCreateSchemaSQL')
50			->with('foo_ns')
51			->will($this->returnValue('create_schema'));
52			if ($unsafe) {
53			$platform->expects($this->exactly(1))
54			->method('getDropSequenceSql')
55			->with($this->isInstanceOf(Sequence::class))
56			->will($this->returnValue('drop_seq'));
57			}
58
59			$platform->expects($this->exactly(1))
60			->method('getAlterSequenceSql')
61			->with($this->isInstanceOf(Sequence::class))
62			->will($this->returnValue('alter_seq'));
63			$platform->expects($this->exactly(1))
64			->method('getCreateSequenceSql')
65			->with($this->isInstanceOf(Sequence::class))
66			->will($this->returnValue('create_seq'));
67			if ($unsafe) {
68			$platform->expects($this->exactly(1))
69			->method('getDropTableSql')
70			->with($this->isInstanceOf(Table::class))
71			->will($this->returnValue('drop_table'));
72			}
73
74			$platform->expects($this->exactly(1))
75			->method('getCreateTableSql')
76			->with($this->isInstanceOf(Table::class))
77			->will($this->returnValue(['create_table']));
78			$platform->expects($this->exactly(1))
79			->method('getCreateForeignKeySQL')
80			->with($this->isInstanceOf(ForeignKeyConstraint::class))
81			->will($this->returnValue('create_foreign_key'));
82			$platform->expects($this->exactly(1))
83			->method('getAlterTableSql')
84			->with($this->isInstanceOf(TableDiff::class))
85			->will($this->returnValue(['alter_table']));
86			if ($unsafe) {
87			$platform->expects($this->exactly(1))
88			->method('getDropForeignKeySql')
89			->with(
90			$this->isInstanceOf(ForeignKeyConstraint::class),
91			$this->isInstanceOf(Table::class)
92			)
93			->will($this->returnValue('drop_orphan_fk'));
94			}
95
96			$platform->expects($this->exactly(1))
97			->method('supportsSchemas')
98			->will($this->returnValue(true));
99			$platform->expects($this->exactly(1))
100			->method('supportsSequences')
101			->will($this->returnValue(true));
102			$platform->expects($this->exactly(2))
103			->method('supportsForeignKeyConstraints')
104			->will($this->returnValue(true));
105
106			return $platform;
107			}
108
109			public function createSchemaDiff() : SchemaDiff
110			{
111			$diff = new SchemaDiff();
112			$diff->newNamespaces['foo_ns'] = 'foo_ns';
113			$diff->removedNamespaces['bar_ns'] = 'bar_ns';
114			$diff->changedSequences['foo_seq'] = new Sequence('foo_seq');
115			$diff->newSequences['bar_seq'] = new Sequence('bar_seq');
116			$diff->removedSequences['baz_seq'] = new Sequence('baz_seq');
117			$diff->newTables['foo_table'] = new Table('foo_table');
118			$diff->removedTables['bar_table'] = new Table('bar_table');
119			$diff->changedTables['baz_table'] = new TableDiff('baz_table');
120			$diff->newTables['foo_table']->addColumn('foreign_id', 'integer');
121			$diff->newTables['foo_table']->addForeignKeyConstraint('foreign_table', ['foreign_id'], ['id']);
122			$fk = new ForeignKeyConstraint(['id'], 'foreign_table', ['id']);
123			$fk->setLocalTable(new Table('local_table'));
124			$diff->orphanedForeignKeys[] = $fk;
125
126			return $diff;
127			}
128			}
129

doctrine / dbal

Pull Request — 2.10.x (#3983)

SchemaDiffTest::createPlatform() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like