AbstractMasterSlaveConnector::updateFromMasterConnfiguration() - Code Metrics - Inspection of "Fallback to other slaves if connection is not poss..." - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 2.11.x (#2448)

unknown

created 2020-05-09 13:06 UTC

updateFromMasterConnfiguration() A

↳ Parent: AbstractMasterSlaveConnector

Complexity

Conditions	3
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	3
c	1
b	0
f	0
dl	0
loc	7
rs	10
ccs	4
cts	4
cp	1
cc	3
nc	2
nop	1
crap	3

<?php

namespace Doctrine\DBAL\Connections\Connector;

use Doctrine\DBAL\Driver;
use Doctrine\DBAL\Driver\Connection as DriverConnection;

abstract class AbstractMasterSlaveConnector implements Connector
{
    /** @var array */
    protected $_params;

    /** @var Driver */
    protected $_driver;

    /**
     * Creates HighAvailabilityConnector.
     *
     * @param array $params
     */
    public function __construct(array $params, Driver $driver)
    {
        $this->_params = $params;
        $this->_driver = $driver;
    }

    /**
     * Connects with arbitrary params to connection.
     *
     * @param array $connectionParams
     *
     * @return DriverConnection
     */
    protected function connectWithParams($connectionParams)
    {
        $driverOptions = $this->_params['driverOptions'] ?? [];

        $connectionParams = $this->updateFromMasterConnfiguration($connectionParams);

        $user     = $connectionParams['user'] ?? null;
        $password = $connectionParams['password'] ?? null;

        return $this->_driver->connect($connectionParams, $user, $password, $driverOptions);
    }

    /**
     * @param array $config
     *
     * @return array
     */
    protected function updateFromMasterConnfiguration($config)
    {
        if (! isset($config['charset']) && isset($this->_params['master']['charset'])) {
            $config['charset'] = $this->_params['master']['charset'];
        }

        return $config;
    }
}


1		<?php
2
3		namespace Doctrine\DBAL\Connections\Connector;
4
5		use Doctrine\DBAL\Driver;
6		use Doctrine\DBAL\Driver\Connection as DriverConnection;
7
8		abstract class AbstractMasterSlaveConnector implements Connector
9		{
10		/** @var array */
11		protected $_params;
12
13		/** @var Driver */
14		protected $_driver;
15
16		/**
17		* Creates HighAvailabilityConnector.
18		*
19		* @param array $params
20		*/
21	373	public function __construct(array $params, Driver $driver)
22		{
23	373	$this->_params = $params;
24	373	$this->_driver = $driver;
25	373	}
26
27		/**
28		* Connects with arbitrary params to connection.
29		*
30		* @param array $connectionParams
31		*
32		* @return DriverConnection
33		*/
34	369	protected function connectWithParams($connectionParams)
35		{
36	369	$driverOptions = $this->_params['driverOptions'] ?? [];
37
38	369	$connectionParams = $this->updateFromMasterConnfiguration($connectionParams);
39
40	369	$user = $connectionParams['user'] ?? null;
41	369	$password = $connectionParams['password'] ?? null;
42
43	369	return $this->_driver->connect($connectionParams, $user, $password, $driverOptions);
44		}
45
46		/**
47		* @param array $config
48		*
49		* @return array
50		*/
51	369	protected function updateFromMasterConnfiguration($config)
52		{
53	369	if (! isset($config['charset']) && isset($this->_params['master']['charset'])) {
54	108	$config['charset'] = $this->_params['master']['charset'];
55		}
56
57	369	return $config;
58		}
59		}
60

doctrine / dbal

Pull Request — 2.11.x (#2448)

updateFromMasterConnfiguration() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like