Issues in AbstractSQLServerDriver.php - All Issues - Inspection of "Merge pull request #3481 from morozov/phpstan-0.11..." - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5dd66e...5b5c2c )

by Marco

created 2019-03-15 07:21 UTC

Doctrine/DBAL/Driver/AbstractSQLServerDriver.php (2 issues)

Labels

Severity

Major 2

<?php

namespace Doctrine\DBAL\Driver;

use Doctrine\DBAL\Connection;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Doctrine\DBAL\DBALException;
use Doctrine\DBAL\Driver;
use Doctrine\DBAL\Platforms\SQLServer2005Platform;
use Doctrine\DBAL\Platforms\SQLServer2008Platform;
use Doctrine\DBAL\Platforms\SQLServer2012Platform;
use Doctrine\DBAL\Platforms\SQLServerPlatform;
use Doctrine\DBAL\Schema\SQLServerSchemaManager;
use Doctrine\DBAL\VersionAwarePlatformDriver;
use function preg_match;
use function version_compare;

/**
 * Abstract base implementation of the {@link Doctrine\DBAL\Driver} interface for Microsoft SQL Server based drivers.
 */
abstract class AbstractSQLServerDriver implements Driver, VersionAwarePlatformDriver
{
    /**
     * {@inheritdoc}
     */
    public function createDatabasePlatformForVersion($version)
    {
        if (! preg_match(
            '/^(?P<major>\d+)(?:\.(?P<minor>\d+)(?:\.(?P<patch>\d+)(?:\.(?P<build>\d+))?)?)?/',
            $version,
            $versionParts
        )) {
            throw DBALException::invalidPlatformVersionSpecified(
                $version,
                '<major_version>.<minor_version>.<patch_version>.<build_version>'
            );
        }

        $majorVersion = $versionParts['major'];
        $minorVersion = $versionParts['minor'] ?? 0;
        $patchVersion = $versionParts['patch'] ?? 0;
        $buildVersion = $versionParts['build'] ?? 0;
        $version      = $majorVersion . '.' . $minorVersion . '.' . $patchVersion . '.' . $buildVersion;

        switch (true) {
            case version_compare($version, '11.00.2100', '>='):
                return new SQLServer2012Platform();
            case version_compare($version, '10.00.1600', '>='):
                return new SQLServer2008Platform();
            case version_compare($version, '9.00.1399', '>='):
                return new SQLServer2005Platform();
            default:
                return new SQLServerPlatform();
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getDatabase(Connection $conn)
    {
        $params = $conn->getParams();

        return $params['dbname'] ?? $conn->query('SELECT DB_NAME()')->fetchColumn();

    }

    /**
     * {@inheritdoc}
     */
    public function getDatabasePlatform()
    {
        return new SQLServer2008Platform();
    }

    /**
     * {@inheritdoc}
     */
    public function getSchemaManager(Connection $conn)
    {
        return new SQLServerSchemaManager($conn);
    }
}


1		<?php
2
3		namespace Doctrine\DBAL\Driver;
4
5		use Doctrine\DBAL\Connection;
		0 ignored issues – show Bug introduced 2018-02-11 17:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Doctrine\DBAL\Driver\Connection`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
6		use Doctrine\DBAL\DBALException;
7		use Doctrine\DBAL\Driver;
8		use Doctrine\DBAL\Platforms\SQLServer2005Platform;
9		use Doctrine\DBAL\Platforms\SQLServer2008Platform;
10		use Doctrine\DBAL\Platforms\SQLServer2012Platform;
11		use Doctrine\DBAL\Platforms\SQLServerPlatform;
12		use Doctrine\DBAL\Schema\SQLServerSchemaManager;
13		use Doctrine\DBAL\VersionAwarePlatformDriver;
14		use function preg_match;
15		use function version_compare;
16
17		/**
18		* Abstract base implementation of the {@link Doctrine\DBAL\Driver} interface for Microsoft SQL Server based drivers.
19		*/
20		abstract class AbstractSQLServerDriver implements Driver, VersionAwarePlatformDriver
21		{
22		/**
23		* {@inheritdoc}
24		*/
25	531	public function createDatabasePlatformForVersion($version)
26		{
27	531	if (! preg_match(
28	12	'/^(?P<major>\d+)(?:\.(?P<minor>\d+)(?:\.(?P<patch>\d+)(?:\.(?P<build>\d+))?)?)?/',
29	531	$version,
30	531	$versionParts
31		)) {
32	500	throw DBALException::invalidPlatformVersionSpecified(
33	500	$version,
34	500	'<major_version>.<minor_version>.<patch_version>.<build_version>'
35		);
36		}
37
38	525	$majorVersion = $versionParts['major'];
39	525	$minorVersion = $versionParts['minor'] ?? 0;
40	525	$patchVersion = $versionParts['patch'] ?? 0;
41	525	$buildVersion = $versionParts['build'] ?? 0;
42	525	$version = $majorVersion . '.' . $minorVersion . '.' . $patchVersion . '.' . $buildVersion;
43
44		switch (true) {
45	525	case version_compare($version, '11.00.2100', '>='):
46	525	return new SQLServer2012Platform();
47	525	case version_compare($version, '10.00.1600', '>='):
48	525	return new SQLServer2008Platform();
49	525	case version_compare($version, '9.00.1399', '>='):
50	525	return new SQLServer2005Platform();
51		default:
52	525	return new SQLServerPlatform();
53		}
54		}
55
56		/**
57		* {@inheritdoc}
58		*/
59	475	public function getDatabase(Connection $conn)
60		{
61	475	$params = $conn->getParams();
62
63	475	return $params['dbname'] ?? $conn->query('SELECT DB_NAME()')->fetchColumn();
		0 ignored issues – show Bug Best Practice introduced 2018-10-02 06:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $params['dbname']...NAME()')->fetchColumn()` also could return the type `false` which is incompatible with the return type mandated by `Doctrine\DBAL\Driver::getDatabase()` of `string`. Loading history...
64		}
65
66		/**
67		* {@inheritdoc}
68		*/
69	450	public function getDatabasePlatform()
70		{
71	450	return new SQLServer2008Platform();
72		}
73
74		/**
75		* {@inheritdoc}
76		*/
77	425	public function getSchemaManager(Connection $conn)
78		{
79	425	return new SQLServerSchemaManager($conn);
80		}
81		}
82

doctrine / dbal

Push — master ( 5dd66e...5b5c2c )

Doctrine/DBAL/Driver/AbstractSQLServerDriver.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like