Issues in DriverTest.php - All Issues - Inspection of "Merge pull request #2855 from lcobucci/bc-break/fi..." - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c7757e...39cb21 )

by Luís

created 2017-11-18 21:31 UTC

Doctrine/Tests/DBAL/Driver/PDOPgSql/DriverTest.php (4 issues)

Labels

Severity

Marco Pivetta 4

<?php

namespace Doctrine\Tests\DBAL\Driver\PDOPgSql;

use Doctrine\DBAL\Driver\PDOPgSql\Driver;
use Doctrine\Tests\DBAL\Driver\AbstractPostgreSQLDriverTest;
use PDO;
use PDOException;

class DriverTest extends AbstractPostgreSQLDriverTest
{
    public function testReturnsName()
    {
        self::assertSame('pdo_pgsql', $this->driver->getName());
    }

    /**
     * @group DBAL-920
     */
    public function testConnectionDisablesPreparesOnPhp56()
    {
        $this->skipWhenNotUsingPhp56AndPdoPgsql();

        $connection = $this->createDriver()->connect(
            array(
                'host' => $GLOBALS['db_host'],
                'port' => $GLOBALS['db_port']
            ),
            $GLOBALS['db_username'],
            $GLOBALS['db_password']
        );

        self::assertInstanceOf('Doctrine\DBAL\Driver\PDOConnection', $connection);

        try {
            self::assertTrue($connection->getAttribute(PDO::PGSQL_ATTR_DISABLE_PREPARES));
        } catch (PDOException $ignored) {
            /** @link https://bugs.php.net/bug.php?id=68371 */
            $this->markTestIncomplete('See https://bugs.php.net/bug.php?id=68371');
        }
    }

    /**
     * @group DBAL-920
     */
    public function testConnectionDoesNotDisablePreparesOnPhp56WhenAttributeDefined()

    {
        $this->skipWhenNotUsingPhp56AndPdoPgsql();

        $connection = $this->createDriver()->connect(
            array(
                'host' => $GLOBALS['db_host'],
                'port' => $GLOBALS['db_port']
            ),
            $GLOBALS['db_username'],
            $GLOBALS['db_password'],
            array(PDO::PGSQL_ATTR_DISABLE_PREPARES => false)

        );

        self::assertInstanceOf('Doctrine\DBAL\Driver\PDOConnection', $connection);

        try {
            self::assertNotSame(true, $connection->getAttribute(PDO::PGSQL_ATTR_DISABLE_PREPARES));
        } catch (PDOException $ignored) {
            /** @link https://bugs.php.net/bug.php?id=68371 */
            $this->markTestIncomplete('See https://bugs.php.net/bug.php?id=68371');
        }
    }

    /**
     * @group DBAL-920
     */
    public function testConnectionDisablePreparesOnPhp56WhenDisablePreparesIsExplicitlyDefined()

    {
        $this->skipWhenNotUsingPhp56AndPdoPgsql();

        $connection = $this->createDriver()->connect(
            array(
                'host' => $GLOBALS['db_host'],
                'port' => $GLOBALS['db_port']
            ),
            $GLOBALS['db_username'],
            $GLOBALS['db_password'],
            array(PDO::PGSQL_ATTR_DISABLE_PREPARES => true)

        );

        self::assertInstanceOf('Doctrine\DBAL\Driver\PDOConnection', $connection);

        try {
            self::assertTrue($connection->getAttribute(PDO::PGSQL_ATTR_DISABLE_PREPARES));
        } catch (PDOException $ignored) {
            /** @link https://bugs.php.net/bug.php?id=68371 */
            $this->markTestIncomplete('See https://bugs.php.net/bug.php?id=68371');
        }
    }

    /**
     * {@inheritDoc}
     */
    protected function createDriver()
    {
        return new Driver();
    }

    /**
     * @throws \PHPUnit_Framework_SkippedTestError
     */
    private function skipWhenNotUsingPhp56AndPdoPgsql()
    {
        if (! defined('PDO::PGSQL_ATTR_DISABLE_PREPARES')) {
            $this->markTestSkipped('Test requires PHP 5.6+');
        }

        if (! (isset($GLOBALS['db_type']) && $GLOBALS['db_type'] === 'pdo_pgsql')) {
            $this->markTestSkipped('Test enabled only when using pdo_pgsql specific phpunit.xml');
        }
    }
}


1		<?php
2
3		namespace Doctrine\Tests\DBAL\Driver\PDOPgSql;
4
5		use Doctrine\DBAL\Driver\PDOPgSql\Driver;
6		use Doctrine\Tests\DBAL\Driver\AbstractPostgreSQLDriverTest;
7		use PDO;
8		use PDOException;
9
10		class DriverTest extends AbstractPostgreSQLDriverTest
11		{
12		public function testReturnsName()
13		{
14		self::assertSame('pdo_pgsql', $this->driver->getName());
15		}
16
17		/**
18		* @group DBAL-920
19		*/
20		public function testConnectionDisablesPreparesOnPhp56()
21		{
22		$this->skipWhenNotUsingPhp56AndPdoPgsql();
23
24		$connection = $this->createDriver()->connect(
25		array(
26		'host' => $GLOBALS['db_host'],
27		'port' => $GLOBALS['db_port']
28		),
29		$GLOBALS['db_username'],
30		$GLOBALS['db_password']
31		);
32
33		self::assertInstanceOf('Doctrine\DBAL\Driver\PDOConnection', $connection);
34
35		try {
36		self::assertTrue($connection->getAttribute(PDO::PGSQL_ATTR_DISABLE_PREPARES));
37		} catch (PDOException $ignored) {
38		/** @link https://bugs.php.net/bug.php?id=68371 */
39		$this->markTestIncomplete('See https://bugs.php.net/bug.php?id=68371');
40		}
41		}
42
43		/**
44		* @group DBAL-920
45		*/
46	View Code Duplication	public function testConnectionDoesNotDisablePreparesOnPhp56WhenAttributeDefined()
		0 ignored issues – show Duplication introduced 2017-07-31 14:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		{
48		$this->skipWhenNotUsingPhp56AndPdoPgsql();
49
50		$connection = $this->createDriver()->connect(
51		array(
52		'host' => $GLOBALS['db_host'],
53		'port' => $GLOBALS['db_port']
54		),
55		$GLOBALS['db_username'],
56		$GLOBALS['db_password'],
57		array(PDO::PGSQL_ATTR_DISABLE_PREPARES => false)
		0 ignored issues – show Bug introduced 2017-11-18 19:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `PDO::PGSQL_ATTR_DISABLE_PREPARES` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
58		);
59
60		self::assertInstanceOf('Doctrine\DBAL\Driver\PDOConnection', $connection);
61
62		try {
63		self::assertNotSame(true, $connection->getAttribute(PDO::PGSQL_ATTR_DISABLE_PREPARES));
64		} catch (PDOException $ignored) {
65		/** @link https://bugs.php.net/bug.php?id=68371 */
66		$this->markTestIncomplete('See https://bugs.php.net/bug.php?id=68371');
67		}
68		}
69
70		/**
71		* @group DBAL-920
72		*/
73	View Code Duplication	public function testConnectionDisablePreparesOnPhp56WhenDisablePreparesIsExplicitlyDefined()
		0 ignored issues – show Duplication introduced 2017-07-31 14:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
74		{
75		$this->skipWhenNotUsingPhp56AndPdoPgsql();
76
77		$connection = $this->createDriver()->connect(
78		array(
79		'host' => $GLOBALS['db_host'],
80		'port' => $GLOBALS['db_port']
81		),
82		$GLOBALS['db_username'],
83		$GLOBALS['db_password'],
84		array(PDO::PGSQL_ATTR_DISABLE_PREPARES => true)
		0 ignored issues – show Bug introduced 2017-11-18 19:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `PDO::PGSQL_ATTR_DISABLE_PREPARES` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
85		);
86
87		self::assertInstanceOf('Doctrine\DBAL\Driver\PDOConnection', $connection);
88
89		try {
90		self::assertTrue($connection->getAttribute(PDO::PGSQL_ATTR_DISABLE_PREPARES));
91		} catch (PDOException $ignored) {
92		/** @link https://bugs.php.net/bug.php?id=68371 */
93		$this->markTestIncomplete('See https://bugs.php.net/bug.php?id=68371');
94		}
95		}
96
97		/**
98		* {@inheritDoc}
99		*/
100		protected function createDriver()
101		{
102		return new Driver();
103		}
104
105		/**
106		* @throws \PHPUnit_Framework_SkippedTestError
107		*/
108		private function skipWhenNotUsingPhp56AndPdoPgsql()
109		{
110		if (! defined('PDO::PGSQL_ATTR_DISABLE_PREPARES')) {
111		$this->markTestSkipped('Test requires PHP 5.6+');
112		}
113
114		if (! (isset($GLOBALS['db_type']) && $GLOBALS['db_type'] === 'pdo_pgsql')) {
115		$this->markTestSkipped('Test enabled only when using pdo_pgsql specific phpunit.xml');
116		}
117		}
118		}
119

doctrine / dbal

Push — master ( c7757e...39cb21 )

Doctrine/Tests/DBAL/Driver/PDOPgSql/DriverTest.php (4 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like