Connection.php$0 ➔ lastInsertId() - Code Metrics - Inspection of "DBAL 3.0: suggestions to improve the Driver\Connec..." - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — develop (#3335)

unknown

created 2018-11-20 15:56 UTC

Connection.php$0 ➔ lastInsertId() A

↳ Parent: Connection

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3.4326

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	7
cts	11
cp	0.6364
rs	9.6666
c	0
b	0
f	0
cc	3
crap	3.4326

<?php

namespace Doctrine\DBAL\Driver\PDOSqlsrv;

use Doctrine\DBAL\Driver\AbstractDriverException;
use Doctrine\DBAL\Driver\PDOConnection;
use Doctrine\DBAL\Driver\PDOStatement;
use Doctrine\DBAL\ParameterType;
use function strpos;
use function substr;

/**
 * Sqlsrv Connection implementation.
 */
class Connection extends PDOConnection implements \Doctrine\DBAL\Driver\Connection
{
    /**
     * {@inheritDoc}
     */
    public function lastInsertId(?string $name = null) : string
    {
        if ($name === null) {
            return parent::lastInsertId($name);
        }

        $stmt = $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?');
        $stmt->execute([$name]);

        $result = $stmt->fetchColumn();

        if ($result === false) {
            // WIP regarding exceptions, see:
            // https://github.com/doctrine/dbal/pull/3335#discussion_r234381175
            throw new class ('No sequence with name "' . $name . '" found.') extends AbstractDriverException {};
        }

        return (string) $result;
    }

    /**
     * {@inheritDoc}
     */
    public function quote(string $value) : string
    {
        $val = parent::quote($value);

        // Fix for a driver version terminating all values with null byte
        if (strpos($val, "\0") !== false) {
            $val = substr($val, 0, -1);
        }

        return $val;
    }

    /**
     * {@inheritDoc}
     */
    protected function createStatement(\PDOStatement $stmt) : PDOStatement
    {
        return new Statement($stmt);
    }
}


1		<?php
2
3		namespace Doctrine\DBAL\Driver\PDOSqlsrv;
4
5		use Doctrine\DBAL\Driver\AbstractDriverException;
6		use Doctrine\DBAL\Driver\PDOConnection;
7		use Doctrine\DBAL\Driver\PDOStatement;
8		use Doctrine\DBAL\ParameterType;
9		use function strpos;
10		use function substr;
11
12		/**
13		* Sqlsrv Connection implementation.
14		*/
15		class Connection extends PDOConnection implements \Doctrine\DBAL\Driver\Connection
16		{
17		/**
18		* {@inheritDoc}
19	3	*/
20		public function lastInsertId(?string $name = null) : string
21	3	{
22	2	if ($name === null) {
23		return parent::lastInsertId($name);
24		}
25	1
26	1	$stmt = $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?');
27		$stmt->execute([$name]);
28	1
29		$result = $stmt->fetchColumn();
30
31		if ($result === false) {
32		// WIP regarding exceptions, see:
33		// https://github.com/doctrine/dbal/pull/3335#discussion_r234381175
34	8	throw new class ('No sequence with name "' . $name . '" found.') extends AbstractDriverException {};
35		}
36	8
37		return (string) $result;
38		}
39	8
40		/**
41		* {@inheritDoc}
42		*/
43	8	public function quote(string $value) : string
44		{
45		$val = parent::quote($value);
46
47		// Fix for a driver version terminating all values with null byte
48		if (strpos($val, "\0") !== false) {
49	236	$val = substr($val, 0, -1);
50		}
51	236
52		return $val;
53		}
54
55		/**
56		* {@inheritDoc}
57		*/
58		protected function createStatement(\PDOStatement $stmt) : PDOStatement
59		{
60		return new Statement($stmt);
61		}
62		}
63

doctrine / dbal

Pull Request — develop (#3335)

Connection.php$0 ➔ lastInsertId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like