Driver::connect() - Code Metrics - Inspection of "Document MySQL error codes" - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#3795)

by Benjamin

created 2019-12-29 11:03 UTC

Driver::connect() A

↳ Parent: Driver

Complexity

Conditions	3
Paths	4

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	5.0538

Importance

Changes

Metric	Value
eloc	10
dl	0
loc	19
ccs	7
cts	18
cp	0.3889
rs	9.9332
c	0
b	0
f	0
cc	3
nc	4
nop	4
crap	5.0538

<?php

declare(strict_types=1);

namespace Doctrine\DBAL\Driver\PDOOracle;

use Doctrine\DBAL\DBALException;
use Doctrine\DBAL\Driver\AbstractOracleDriver;
use Doctrine\DBAL\Driver\Connection;
use Doctrine\DBAL\Driver\PDOConnection;
use Doctrine\DBAL\Driver\PDOException;
use PDO;

/**
 * PDO Oracle driver.
 *
 * WARNING: This driver gives us segfaults in our testsuites on CLOB and other
 * stuff. PDO Oracle is not maintained by Oracle or anyone in the PHP community,
 * which leads us to the recommendation to use the "oci8" driver to connect
 * to Oracle instead.
 */
class Driver extends AbstractOracleDriver
{
    /**
     * {@inheritdoc}
     */
    public function connect(
        array $params,
        string $username = '',
        string $password = '',
        array $driverOptions = []
    ) : Connection {
        if (! empty($params['persistent'])) {
            $driverOptions[PDO::ATTR_PERSISTENT] = true;
        }

        try {
            return new PDOConnection(
                $this->constructPdoDsn($params),
                $username,
                $password,
                $driverOptions
            );
        } catch (PDOException $e) {
            throw DBALException::driverException($this, $e);
        }
    }

    /**
     * Constructs the Oracle PDO DSN.
     *
     * @param mixed[] $params
     *
     * @return string The DSN.
     */
    private function constructPdoDsn(array $params) : string
    {
        $dsn = 'oci:dbname=' . $this->getEasyConnectString($params);

        if (isset($params['charset'])) {
            $dsn .= ';charset=' . $params['charset'];
        }

        return $dsn;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\DBAL\Driver\PDOOracle;
6
7		use Doctrine\DBAL\DBALException;
8		use Doctrine\DBAL\Driver\AbstractOracleDriver;
9		use Doctrine\DBAL\Driver\Connection;
10		use Doctrine\DBAL\Driver\PDOConnection;
11		use Doctrine\DBAL\Driver\PDOException;
12		use PDO;
13
14		/**
15		* PDO Oracle driver.
16		*
17		* WARNING: This driver gives us segfaults in our testsuites on CLOB and other
18		* stuff. PDO Oracle is not maintained by Oracle or anyone in the PHP community,
19		* which leads us to the recommendation to use the "oci8" driver to connect
20		* to Oracle instead.
21		*/
22		class Driver extends AbstractOracleDriver
23		{
24		/**
25		* {@inheritdoc}
26		*/
27	33	public function connect(
28		array $params,
29		string $username = '',
30		string $password = '',
31		array $driverOptions = []
32		) : Connection {
33	33	if (! empty($params['persistent'])) {
34	1	$driverOptions[PDO::ATTR_PERSISTENT] = true;
35		}
36
37		try {
38	33	return new PDOConnection(
39	33	$this->constructPdoDsn($params),
40		$username,
41		$password,
42		$driverOptions
43		);
44	3	} catch (PDOException $e) {
45	3	throw DBALException::driverException($this, $e);
46		}
47		}
48
49		/**
50		* Constructs the Oracle PDO DSN.
51		*
52		* @param mixed[] $params
53		*
54		* @return string The DSN.
55		*/
56	33	private function constructPdoDsn(array $params) : string
57		{
58	33	$dsn = 'oci:dbname=' . $this->getEasyConnectString($params);
59
60	33	if (isset($params['charset'])) {
61		$dsn .= ';charset=' . $params['charset'];
62		}
63
64	33	return $dsn;
65		}
66		}
67

doctrine / dbal

Pull Request — master (#3795)

Driver::connect() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like