OCI8Connection::exec() - Code Metrics - Inspection of "Merge pull request #3443 from morozov/phpstan-lvl7" - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 30b923...92920e )

by Marco

created 2019-02-04 13:06 UTC

OCI8Connection::exec() A

↳ Parent: OCI8Connection

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1.008

Importance

Changes

Metric	Value
eloc	3
dl	0
loc	6
ccs	4
cts	5
cp	0.8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1.008

<?php

namespace Doctrine\DBAL\Driver\OCI8;

use Doctrine\DBAL\Driver\Connection;
use Doctrine\DBAL\Driver\ServerInfoAwareConnection;
use Doctrine\DBAL\ParameterType;
use UnexpectedValueException;
use const OCI_COMMIT_ON_SUCCESS;
use const OCI_DEFAULT;
use const OCI_NO_AUTO_COMMIT;
use function addcslashes;
use function func_get_args;
use function is_float;
use function is_int;
use function oci_commit;
use function oci_connect;
use function oci_error;
use function oci_pconnect;
use function oci_rollback;
use function oci_server_version;
use function preg_match;
use function sprintf;
use function str_replace;

/**
 * OCI8 implementation of the Connection interface.
 */
class OCI8Connection implements Connection, ServerInfoAwareConnection
{
    /** @var resource */
    protected $dbh;

    /** @var int */
    protected $executeMode = OCI_COMMIT_ON_SUCCESS;

    /**
     * Creates a Connection to an Oracle Database using oci8 extension.
     *
     * @param string $username
     * @param string $password
     * @param string $db
     * @param string $charset
     * @param int    $sessionMode
     * @param bool   $persistent
     *
     * @throws OCI8Exception
     */
    public function __construct(
        $username,
        $password,
        $db,
        $charset = '',
        $sessionMode = OCI_DEFAULT,
        $persistent = false
    ) {
        $dbh = $persistent
            ? @oci_pconnect($username, $password, $db, $charset, $sessionMode)
            : @oci_connect($username, $password, $db, $charset, $sessionMode);

        if ($dbh === false) {

            throw OCI8Exception::fromErrorInfo(oci_error());
        }

        $this->dbh = $dbh;
    }

    /**
     * {@inheritdoc}
     *
     * @throws UnexpectedValueException If the version string returned by the database server
     *                                  does not contain a parsable version number.
     */
    public function getServerVersion()
    {
        $version = oci_server_version($this->dbh);

        if ($version === false) {
            throw OCI8Exception::fromErrorInfo(oci_error($this->dbh));
        }

        if (! preg_match('/\s+(\d+\.\d+\.\d+\.\d+\.\d+)\s+/', $version, $matches)) {
            throw new UnexpectedValueException(
                sprintf(
                    'Unexpected database version string "%s". Cannot parse an appropriate version number from it. ' .
                    'Please report this database version string to the Doctrine team.',
                    $version
                )
            );
        }

        return $matches[1];
    }

    /**
     * {@inheritdoc}
     */
    public function requiresQueryForServerVersion()
    {
        return false;
    }

    /**
     * {@inheritdoc}
     */
    public function prepare($prepareString)
    {
        return new OCI8Statement($this->dbh, $prepareString, $this);
    }

    /**
     * {@inheritdoc}
     */
    public function query()
    {
        $args = func_get_args();
        $sql  = $args[0];
        //$fetchMode = $args[1];
        $stmt = $this->prepare($sql);
        $stmt->execute();

        return $stmt;
    }

    /**
     * {@inheritdoc}
     */
    public function quote($value, $type = ParameterType::STRING)
    {
        if (is_int($value) || is_float($value)) {
            return $value;
        }
        $value = str_replace("'", "''", $value);

        return "'" . addcslashes($value, "\000\n\r\\\032") . "'";
    }

    /**
     * {@inheritdoc}
     */
    public function exec($statement)
    {
        $stmt = $this->prepare($statement);
        $stmt->execute();

        return $stmt->rowCount();
    }

    /**
     * {@inheritdoc}
     */
    public function lastInsertId($name = null)
    {
        if ($name === null) {
            return false;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        }

        $sql    = 'SELECT ' . $name . '.CURRVAL FROM DUAL';
        $stmt   = $this->query($sql);
        $result = $stmt->fetchColumn();

        if ($result === false) {
            throw new OCI8Exception('lastInsertId failed: Query was executed but no result was returned.');
        }

        return (int) $result;
    }

    /**
     * Returns the current execution mode.
     *
     * @return int
     */
    public function getExecuteMode()
    {
        return $this->executeMode;
    }

    /**
     * {@inheritdoc}
     */
    public function beginTransaction()
    {
        $this->executeMode = OCI_NO_AUTO_COMMIT;

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function commit()
    {
        if (! oci_commit($this->dbh)) {
            throw OCI8Exception::fromErrorInfo($this->errorInfo());
        }
        $this->executeMode = OCI_COMMIT_ON_SUCCESS;

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function rollBack()
    {
        if (! oci_rollback($this->dbh)) {
            throw OCI8Exception::fromErrorInfo($this->errorInfo());
        }
        $this->executeMode = OCI_COMMIT_ON_SUCCESS;

        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function errorCode()
    {
        $error = oci_error($this->dbh);
        if ($error !== false) {
            $error = $error['code'];
        }

        return $error;
    }

    /**
     * {@inheritdoc}
     */
    public function errorInfo()
    {
        $error = oci_error($this->dbh);

        if ($error === false) {
            return [];
        }

        return $error;
    }
}


1		<?php
2
3		namespace Doctrine\DBAL\Driver\OCI8;
4
5		use Doctrine\DBAL\Driver\Connection;
6		use Doctrine\DBAL\Driver\ServerInfoAwareConnection;
7		use Doctrine\DBAL\ParameterType;
8		use UnexpectedValueException;
9		use const OCI_COMMIT_ON_SUCCESS;
10		use const OCI_DEFAULT;
11		use const OCI_NO_AUTO_COMMIT;
12		use function addcslashes;
13		use function func_get_args;
14		use function is_float;
15		use function is_int;
16		use function oci_commit;
17		use function oci_connect;
18		use function oci_error;
19		use function oci_pconnect;
20		use function oci_rollback;
21		use function oci_server_version;
22		use function preg_match;
23		use function sprintf;
24		use function str_replace;
25
26		/**
27		* OCI8 implementation of the Connection interface.
28		*/
29		class OCI8Connection implements Connection, ServerInfoAwareConnection
30		{
31		/** @var resource */
32		protected $dbh;
33
34		/** @var int */
35		protected $executeMode = OCI_COMMIT_ON_SUCCESS;
36
37		/**
38		* Creates a Connection to an Oracle Database using oci8 extension.
39		*
40		* @param string $username
41		* @param string $password
42		* @param string $db
43		* @param string $charset
44		* @param int $sessionMode
45		* @param bool $persistent
46		*
47		* @throws OCI8Exception
48		*/
49	30	public function __construct(
50		$username,
51		$password,
52		$db,
53		$charset = '',
54		$sessionMode = OCI_DEFAULT,
55		$persistent = false
56		) {
57	30	$dbh = $persistent
58		? @oci_pconnect($username, $password, $db, $charset, $sessionMode)
59	30	: @oci_connect($username, $password, $db, $charset, $sessionMode);
60
61	30	if ($dbh === false) {
		0 ignored issues – show introduced 2019-01-27 03:48 UTC by Report Bug Copy Issue Report The condition `$dbh === false` is always `false`. Loading history...
62	3	throw OCI8Exception::fromErrorInfo(oci_error());
63		}
64
65	27	$this->dbh = $dbh;
66	27	}
67
68		/**
69		* {@inheritdoc}
70		*
71		* @throws UnexpectedValueException If the version string returned by the database server
72		* does not contain a parsable version number.
73		*/
74		public function getServerVersion()
75		{
76		$version = oci_server_version($this->dbh);
77
78		if ($version === false) {
79		throw OCI8Exception::fromErrorInfo(oci_error($this->dbh));
80		}
81
82		if (! preg_match('/\s+(\d+\.\d+\.\d+\.\d+\.\d+)\s+/', $version, $matches)) {
83		throw new UnexpectedValueException(
84		sprintf(
85		'Unexpected database version string "%s". Cannot parse an appropriate version number from it. ' .
86		'Please report this database version string to the Doctrine team.',
87		$version
88		)
89		);
90		}
91
92		return $matches[1];
93		}
94
95		/**
96		* {@inheritdoc}
97		*/
98	2	public function requiresQueryForServerVersion()
99		{
100	2	return false;
101		}
102
103		/**
104		* {@inheritdoc}
105		*/
106	262	public function prepare($prepareString)
107		{
108	262	return new OCI8Statement($this->dbh, $prepareString, $this);
109		}
110
111		/**
112		* {@inheritdoc}
113		*/
114	173	public function query()
115		{
116	173	$args = func_get_args();
117	173	$sql = $args[0];
118		//$fetchMode = $args[1];
119	173	$stmt = $this->prepare($sql);
120	173	$stmt->execute();
121
122	170	return $stmt;
123		}
124
125		/**
126		* {@inheritdoc}
127		*/
128	4	public function quote($value, $type = ParameterType::STRING)
129		{
130	4	if (is_int($value) \|\| is_float($value)) {
131	2	return $value;
132		}
133	3	$value = str_replace("'", "''", $value);
134
135	3	return "'" . addcslashes($value, "\000\n\r\\\032") . "'";
136		}
137
138		/**
139		* {@inheritdoc}
140		*/
141	174	public function exec($statement)
142		{
143	174	$stmt = $this->prepare($statement);
144	174	$stmt->execute();
145
146	168	return $stmt->rowCount();
147		}
148
149		/**
150		* {@inheritdoc}
151		*/
152	4	public function lastInsertId($name = null)
153		{
154	4	if ($name === null) {
155	1	return false;
		0 ignored issues – show Bug Best Practice introduced 2017-11-18 19:58 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the return type mandated by `Doctrine\DBAL\Driver\Connection::lastInsertId()` of `string`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
156		}
157
158	3	$sql = 'SELECT ' . $name . '.CURRVAL FROM DUAL';
159	3	$stmt = $this->query($sql);
160	3	$result = $stmt->fetchColumn();
161
162	3	if ($result === false) {
163		throw new OCI8Exception('lastInsertId failed: Query was executed but no result was returned.');
164		}
165
166	3	return (int) $result;
167		}
168
169		/**
170		* Returns the current execution mode.
171		*
172		* @return int
173		*/
174	257	public function getExecuteMode()
175		{
176	257	return $this->executeMode;
177		}
178
179		/**
180		* {@inheritdoc}
181		*/
182	15	public function beginTransaction()
183		{
184	15	$this->executeMode = OCI_NO_AUTO_COMMIT;
185
186	15	return true;
187		}
188
189		/**
190		* {@inheritdoc}
191		*/
192	7	public function commit()
193		{
194	7	if (! oci_commit($this->dbh)) {
195		throw OCI8Exception::fromErrorInfo($this->errorInfo());
196		}
197	7	$this->executeMode = OCI_COMMIT_ON_SUCCESS;
198
199	7	return true;
200		}
201
202		/**
203		* {@inheritdoc}
204		*/
205	9	public function rollBack()
206		{
207	9	if (! oci_rollback($this->dbh)) {
208		throw OCI8Exception::fromErrorInfo($this->errorInfo());
209		}
210	9	$this->executeMode = OCI_COMMIT_ON_SUCCESS;
211
212	9	return true;
213		}
214
215		/**
216		* {@inheritdoc}
217		*/
218		public function errorCode()
219		{
220		$error = oci_error($this->dbh);
221		if ($error !== false) {
222		$error = $error['code'];
223		}
224
225		return $error;
226		}
227
228		/**
229		* {@inheritdoc}
230		*/
231		public function errorInfo()
232		{
233		$error = oci_error($this->dbh);
234
235		if ($error === false) {
236		return [];
237		}
238
239		return $error;
240		}
241		}
242

doctrine / dbal

Push — master ( 30b923...92920e )

OCI8Connection::exec() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like