Driver::connect() - Code Metrics - Inspection of "Make classes final where applicable." - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#3590)

by Sergei

created 2020-01-11 16:34 UTC

Driver::connect() A

↳ Parent: Driver

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2.4168

Importance

Changes

Metric	Value
eloc	10
c	0
b	0
f	0
dl	0
loc	17
ccs	9
cts	17
cp	0.5294
rs	9.9332
cc	2
nc	2
nop	4
crap	2.4168

<?php

declare(strict_types=1);

namespace Doctrine\DBAL\Driver\OCI8;

use Doctrine\DBAL\DBALException;
use Doctrine\DBAL\Driver\AbstractOracleDriver;
use Doctrine\DBAL\Driver\Connection;
use const OCI_DEFAULT;

/**
 * A Doctrine DBAL driver for the Oracle OCI8 PHP extensions.
 */
final class Driver extends AbstractOracleDriver
{
    /**
     * {@inheritdoc}
     */
    public function connect(
        array $params,
        string $username = '',
        string $password = '',
        array $driverOptions = []
    ) : Connection {
        try {
            return new OCI8Connection(
                $username,
                $password,
                $this->constructDsn($params),
                $params['charset'] ?? '',
                $params['sessionMode'] ?? OCI_DEFAULT,
                $params['persistent'] ?? false
            );
        } catch (OCI8Exception $e) {
            throw DBALException::driverException($this, $e);
        }
    }

    /**
     * Constructs the Oracle DSN.
     *
     * @param mixed[] $params
     *
     * @return string The DSN.
     */
    private function constructDsn(array $params) : string
    {
        return $this->getEasyConnectString($params);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\DBAL\Driver\OCI8;
6
7		use Doctrine\DBAL\DBALException;
8		use Doctrine\DBAL\Driver\AbstractOracleDriver;
9		use Doctrine\DBAL\Driver\Connection;
10		use const OCI_DEFAULT;
11
12		/**
13		* A Doctrine DBAL driver for the Oracle OCI8 PHP extensions.
14		*/
15		final class Driver extends AbstractOracleDriver
16		{
17		/**
18		* {@inheritdoc}
19		*/
20	30	public function connect(
21		array $params,
22		string $username = '',
23		string $password = '',
24		array $driverOptions = []
25		) : Connection {
26		try {
27	30	return new OCI8Connection(
28	30	$username,
29		$password,
30	30	$this->constructDsn($params),
31	30	$params['charset'] ?? '',
32	30	$params['sessionMode'] ?? OCI_DEFAULT,
33	30	$params['persistent'] ?? false
34		);
35	3	} catch (OCI8Exception $e) {
36	3	throw DBALException::driverException($this, $e);
37		}
38		}
39
40		/**
41		* Constructs the Oracle DSN.
42		*
43		* @param mixed[] $params
44		*
45		* @return string The DSN.
46		*/
47	30	private function constructDsn(array $params) : string
48		{
49	30	return $this->getEasyConnectString($params);
50		}
51		}
52

doctrine / dbal

Pull Request — master (#3590)

Driver::connect() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like