PDOConnection::requiresQueryForServerVersion() - Code Metrics - Inspection of "ContinuousPHP configuration for PDO Oracle driver" - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#3339)

by Sergei

created 2018-12-02 06:15 UTC

PDOConnection::requiresQueryForServerVersion() A

↳ Parent: PDOConnection

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	1
nc	1
nop	0
crap	1

<?php

namespace Doctrine\DBAL\Driver;

use Doctrine\DBAL\ParameterType;
use PDO;
use function count;
use function func_get_args;

/**
 * PDO implementation of the Connection interface.
 * Used by all PDO-based drivers.
 */
class PDOConnection extends PDO implements Connection, ServerInfoAwareConnection
{
    /**
     * @param string       $dsn
     * @param string|null  $user
     * @param string|null  $password
     * @param mixed[]|null $options
     *
     * @throws PDOException In case of an error.
     */
    public function __construct($dsn, $user = null, $password = null, ?array $options = null)
    {
        try {
            parent::__construct($dsn, $user, $password, $options);
            $this->setAttribute(PDO::ATTR_STATEMENT_CLASS, [PDOStatement::class, []]);
            $this->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
        } catch (\PDOException $exception) {
            throw new PDOException($exception);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function exec($statement)
    {
        try {
            return parent::exec($statement);
        } catch (\PDOException $exception) {
            throw new PDOException($exception);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getServerVersion()
    {
        return PDO::getAttribute(PDO::ATTR_SERVER_VERSION);
    }

    /**
     * {@inheritdoc}
     */
    public function prepare($prepareString, $driverOptions = [])
    {
        try {
            return parent::prepare($prepareString, $driverOptions);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        } catch (\PDOException $exception) {
            throw new PDOException($exception);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function query()
    {
        $args      = func_get_args();
        $argsCount = count($args);

        try {
            if ($argsCount === 4) {
                return parent::query($args[0], $args[1], $args[2], $args[3]);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            }

            if ($argsCount === 3) {
                return parent::query($args[0], $args[1], $args[2]);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            }

            if ($argsCount === 2) {
                return parent::query($args[0], $args[1]);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            }

            return parent::query($args[0]);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        } catch (\PDOException $exception) {
            throw new PDOException($exception);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function quote($input, $type = ParameterType::STRING)
    {
        return parent::quote($input, $type);
    }

    /**
     * {@inheritdoc}
     */
    public function lastInsertId($name = null)
    {
        try {
            return parent::lastInsertId($name);
        } catch (\PDOException $exception) {
            throw new PDOException($exception);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function requiresQueryForServerVersion()
    {
        return false;
    }
}


1		<?php
2
3		namespace Doctrine\DBAL\Driver;
4
5		use Doctrine\DBAL\ParameterType;
6		use PDO;
7		use function count;
8		use function func_get_args;
9
10		/**
11		* PDO implementation of the Connection interface.
12		* Used by all PDO-based drivers.
13		*/
14		class PDOConnection extends PDO implements Connection, ServerInfoAwareConnection
15		{
16		/**
17		* @param string $dsn
18		* @param string\|null $user
19		* @param string\|null $password
20		* @param mixed[]\|null $options
21		*
22		* @throws PDOException In case of an error.
23		*/
24	1041	public function __construct($dsn, $user = null, $password = null, ?array $options = null)
25		{
26		try {
27	1041	parent::__construct($dsn, $user, $password, $options);
28	1005	$this->setAttribute(PDO::ATTR_STATEMENT_CLASS, [PDOStatement::class, []]);
29	1005	$this->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
30	66	} catch (\PDOException $exception) {
31	66	throw new PDOException($exception);
32		}
33	1005	}
34
35		/**
36		* {@inheritdoc}
37		*/
38	3160	public function exec($statement)
39		{
40		try {
41	3160	return parent::exec($statement);
42	1994	} catch (\PDOException $exception) {
43	1994	throw new PDOException($exception);
44		}
45		}
46
47		/**
48		* {@inheritdoc}
49		*/
50	395	public function getServerVersion()
51		{
52	395	return PDO::getAttribute(PDO::ATTR_SERVER_VERSION);
53		}
54
55		/**
56		* {@inheritdoc}
57		*/
58	2434	public function prepare($prepareString, $driverOptions = [])
59		{
60		try {
61	2434	return parent::prepare($prepareString, $driverOptions);
		0 ignored issues – show Bug Best Practice introduced 2018-05-10 04:50 UTC by Report Bug Copy Issue Report The expression `return parent::prepare($...String, $driverOptions)` returns the type `PDOStatement\|boolean` which is incompatible with the return type mandated by `Doctrine\DBAL\Driver\Connection::prepare()` of `Doctrine\DBAL\Driver\Statement`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
62	34	} catch (\PDOException $exception) {
63	34	throw new PDOException($exception);
64		}
65		}
66
67		/**
68		* {@inheritdoc}
69		*/
70	3310	public function query()
71		{
72	3310	$args = func_get_args();
73	3310	$argsCount = count($args);
74
75		try {
76	3310	if ($argsCount === 4) {
77		return parent::query($args[0], $args[1], $args[2], $args[3]);
		0 ignored issues – show Bug Best Practice introduced 2018-05-10 04:50 UTC by Report Bug Copy Issue Report The expression `return parent::query($ar...1], $args[2], $args[3])` returns the type `PDOStatement\|boolean` which is incompatible with the return type mandated by `Doctrine\DBAL\Driver\Connection::query()` of `Doctrine\DBAL\Driver\Statement`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
78		}
79
80	3310	if ($argsCount === 3) {
81		return parent::query($args[0], $args[1], $args[2]);
		0 ignored issues – show Bug Best Practice introduced 2018-05-10 04:50 UTC by Report Bug Copy Issue Report The expression `return parent::query($args[0], $args[1], $args[2])` returns the type `PDOStatement\|boolean` which is incompatible with the return type mandated by `Doctrine\DBAL\Driver\Connection::query()` of `Doctrine\DBAL\Driver\Statement`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
82		}
83
84	3310	if ($argsCount === 2) {
85		return parent::query($args[0], $args[1]);
		0 ignored issues – show Bug Best Practice introduced 2018-05-10 04:50 UTC by Report Bug Copy Issue Report The expression `return parent::query($args[0], $args[1])` returns the type `PDOStatement\|boolean` which is incompatible with the return type mandated by `Doctrine\DBAL\Driver\Connection::query()` of `Doctrine\DBAL\Driver\Statement`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
86		}
87
88	3310	return parent::query($args[0]);
		0 ignored issues – show Bug Best Practice introduced 2018-05-10 04:50 UTC by Report Bug Copy Issue Report The expression `return parent::query($args[0])` returns the type `PDOStatement\|boolean` which is incompatible with the return type mandated by `Doctrine\DBAL\Driver\Connection::query()` of `Doctrine\DBAL\Driver\Statement`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
89	113	} catch (\PDOException $exception) {
90	113	throw new PDOException($exception);
91		}
92		}
93
94		/**
95		* {@inheritdoc}
96		*/
97	152	public function quote($input, $type = ParameterType::STRING)
98		{
99	152	return parent::quote($input, $type);
100		}
101
102		/**
103		* {@inheritdoc}
104		*/
105	93	public function lastInsertId($name = null)
106		{
107		try {
108	93	return parent::lastInsertId($name);
109		} catch (\PDOException $exception) {
110		throw new PDOException($exception);
111		}
112		}
113
114		/**
115		* {@inheritdoc}
116		*/
117	411	public function requiresQueryForServerVersion()
118		{
119	411	return false;
120		}
121		}
122

doctrine / dbal

Pull Request — master (#3339)

PDOConnection::requiresQueryForServerVersion() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like