Issues in BasicCrudTest.php (master) - Issues in master - doctrine/couchdb-odm - Measure and Improve Code Quality continuously with Scrutinizer

Issues (251)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Tests/ODM/CouchDB/Functional/BasicCrudTest.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Doctrine\Tests\ODM\CouchDB\Functional;

use Doctrine\ODM\CouchDB\InvalidDocumentTypeException;

class BasicCrudTest extends \Doctrine\Tests\ODM\CouchDB\CouchDBFunctionalTestCase
{
    /**
     * @var DocumentManager
     */
    private $dm;

    private $type;

    public function setUp()
    {
        $this->type = 'Doctrine\Tests\ODM\CouchDB\Functional\User';
        $this->dm = $this->createDocumentManager();


        $httpClient = $this->dm->getHttpClient();

        $data = json_encode(
            array(
                '_id' => "1",
                'username' => 'lsmith',
                'type' => $this->type,
            )
        );
        $resp = $httpClient->request('PUT', '/' . $this->dm->getDatabase() . '/1', $data);
        $this->assertEquals(201, $resp->status);
    }

    public function testFind()

    {
        $user = $this->dm->find($this->type, 1);

        $this->assertInstanceOf($this->type, $user);
        $this->assertEquals('1', $user->id);
        $this->assertEquals('lsmith', $user->username);
    }

    public function testFindUsesIdentityMap()
    {
        $user1 = $this->dm->find($this->type, 1);
        $user2 = $this->dm->find($this->type, 1);

        $this->assertSame($user1, $user2);
    }

    public function testInsert()
    {
        $user = new User();
        $user->id = "myuser-1234";
        $user->username = "test";

        $this->dm->persist($user);
        $this->dm->flush();
        $this->dm->clear();

        $userNew = $this->dm->find($this->type, $user->id);

        $this->assertNotNull($userNew, "Have to hydrate user object!");
        $this->assertEquals($user->id, $userNew->id);
        $this->assertEquals($user->username, $userNew->username);
    }

    public function testDelete()
    {
        $user = $this->dm->find($this->type, 1);

        $this->dm->remove($user);
        $this->dm->flush();
        $this->dm->clear();

        $userRemoved = $this->dm->find($this->type, 1);

        $this->assertNull($userRemoved, "Have to delete user object!");
    }

    public function testDeleteProxy()
    {
        $user = $this->dm->getReference($this->type, 1);

        $this->dm->remove($user);
        $this->dm->flush();
        $this->dm->clear();

        $userRemoved = $this->dm->find($this->type, 1);

        $this->assertNull($userRemoved, "Have to delete user object!");
    }

    public function testUpdate1()
    {
        $user = new User();
        $user->id = "myuser-1234";
        $user->username = "test";

        $this->dm->persist($user);
        $this->dm->flush();
        $this->dm->clear();

        $user = $this->dm->find($this->type, $user->id);
        $user->username = "test2";

        $this->dm->flush();
        $this->dm->clear();

        $userNew = $this->dm->find($this->type, $user->id);

        $this->assertEquals($user->username, $userNew->username);
    }
    
    public function testUpdate2()

    {
        $user = $this->dm->find($this->type, 1);
        $user->username = "new-name";

        $this->dm->flush();
        $this->dm->clear();

        $newUser = $this->dm->find($this->type, 1);
        $this->assertEquals('new-name', $newUser->username);
    }

    public function testRemove()
    {
        $user = $this->dm->find($this->type, 1);

        $this->dm->remove($user);
        $this->dm->flush();

        $newUser = $this->dm->find($this->type, 1);
        $this->assertNull($newUser);
    }

    public function testInsertUpdateMultiple()
    {
        $user1 = $this->dm->find($this->type, 1);
        $user1->username = "new-name";

        $user2 = new User();
        $user2->id = "myuser-1111";
        $user2->username = "test";

        $user3 = new User();
        $user3->id = "myuser-2222";
        $user3->username = "test";

        $this->dm->persist($user2);
        $this->dm->persist($user3);
        $this->dm->flush();
        $this->dm->clear();

        $pUser1 = $this->dm->find($this->type, 1);
        $pUser2 = $this->dm->find($this->type, 'myuser-1111');
        $pUser3 = $this->dm->find($this->type, 'myuser-2222');

        $this->assertEquals('new-name', $pUser1->username);
        $this->assertEquals('myuser-1111', $pUser2->id);
        $this->assertEquals('myuser-2222', $pUser3->id);
    }

    public function testFindTypeValidation()
    {
        $this->setExpectedException('Doctrine\ODM\CouchDB\InvalidDocumentTypeException');
        $user = $this->dm->find($this->type.'2', 1);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testNullConversionHandledAutomatically()

    {
        $user1 = $this->dm->find($this->type, 1);
        $user1->username = null;

        $this->dm->flush();
        $this->dm->clear();

        $pUser1 = $this->dm->find($this->type, 1);

        $this->assertNull($pUser1->username);
    }

    public function testFindWrongTypesDoesNotMessUnitOfWork()
    {
        try {
            $user1 = $this->dm->find(__NAMESPACE__ . '\\User2', 1);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $this->fail('Expecting InvalidDocumentTypeException');
        } catch (InvalidDocumentTypeException $e) {

        }

        $user1 = $this->dm->find(__NAMESPACE__ . '\\User', 1);

        $this->assertEquals('lsmith', $user1->username);
    }

    public function testKeepTrackOfUnmappedData()
    {
        $httpClient = $this->dm->getHttpClient();

        $data =  array(
            '_id' => "2",
            'username' => 'beberlei',
            'email' => '[email protected]',
            'address' => array('city' => 'Bonn', 'country' => 'DE'),
            'type' => str_replace("\\", ".", $this->type),
        );
        $resp = $httpClient->request('PUT', '/' . $this->dm->getDatabase() . '/2', json_encode($data));
        $this->assertEquals(201, $resp->status);

        $user = $this->dm->find($this->type, 2);
        $this->assertInstanceOf($this->type, $user);
        $this->assertEquals('beberlei', $user->username);

        $user->username = 'beberlei2';
        $this->dm->flush();

        $resp = $httpClient->request('GET', '/' . $this->dm->getDatabase() . '/2');
        $this->assertEquals(200, $resp->status);

        $data['username'] = 'beberlei2';

        ksort($resp->body);
        ksort($data);
        unset($resp->body['_rev']);

        $this->assertEquals($data, $resp->body);
    }
}

/**
 * @Document
 */
class User
{
    /** @Id(strategy="ASSIGNED") */
    public $id;
    /** @Field(type="string") */
    public $username;
}

/**
 * @Document
 */
class User2
{
    /** @Id(strategy="ASSIGNED") */
    public $id;
    /** @Field(type="string") */
    public $username;
}


1		<?php
2
3		namespace Doctrine\Tests\ODM\CouchDB\Functional;
4
5		use Doctrine\ODM\CouchDB\InvalidDocumentTypeException;
6
7		class BasicCrudTest extends \Doctrine\Tests\ODM\CouchDB\CouchDBFunctionalTestCase
8		{
9		/**
10		* @var DocumentManager
11		*/
12		private $dm;
13
14		private $type;
15
16		public function setUp()
17		{
18		$this->type = 'Doctrine\Tests\ODM\CouchDB\Functional\User';
19		$this->dm = $this->createDocumentManager();
		0 ignored issues – show Documentation Bug introduced 2016-02-16 21:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->createDocumentManager()` of type `object<Doctrine\ODM\CouchDB\DocumentManager>` is incompatible with the declared type `object<Doctrine\Tests\OD...tional\DocumentManager>` of property `$dm`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
20
21		$httpClient = $this->dm->getHttpClient();
22
23		$data = json_encode(
24		array(
25		'_id' => "1",
26		'username' => 'lsmith',
27		'type' => $this->type,
28		)
29		);
30		$resp = $httpClient->request('PUT', '/' . $this->dm->getDatabase() . '/1', $data);
31		$this->assertEquals(201, $resp->status);
32		}
33
34	View Code Duplication	public function testFind()
		0 ignored issues – show Duplication introduced 2017-09-05 07:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		{
36		$user = $this->dm->find($this->type, 1);
37
38		$this->assertInstanceOf($this->type, $user);
39		$this->assertEquals('1', $user->id);
40		$this->assertEquals('lsmith', $user->username);
41		}
42
43		public function testFindUsesIdentityMap()
44		{
45		$user1 = $this->dm->find($this->type, 1);
46		$user2 = $this->dm->find($this->type, 1);
47
48		$this->assertSame($user1, $user2);
49		}
50
51		public function testInsert()
52		{
53		$user = new User();
54		$user->id = "myuser-1234";
55		$user->username = "test";
56
57		$this->dm->persist($user);
58		$this->dm->flush();
59		$this->dm->clear();
60
61		$userNew = $this->dm->find($this->type, $user->id);
62
63		$this->assertNotNull($userNew, "Have to hydrate user object!");
64		$this->assertEquals($user->id, $userNew->id);
65		$this->assertEquals($user->username, $userNew->username);
66		}
67
68		public function testDelete()
69		{
70		$user = $this->dm->find($this->type, 1);
71
72		$this->dm->remove($user);
73		$this->dm->flush();
74		$this->dm->clear();
75
76		$userRemoved = $this->dm->find($this->type, 1);
77
78		$this->assertNull($userRemoved, "Have to delete user object!");
79		}
80
81		public function testDeleteProxy()
82		{
83		$user = $this->dm->getReference($this->type, 1);
84
85		$this->dm->remove($user);
86		$this->dm->flush();
87		$this->dm->clear();
88
89		$userRemoved = $this->dm->find($this->type, 1);
90
91		$this->assertNull($userRemoved, "Have to delete user object!");
92		}
93
94		public function testUpdate1()
95		{
96		$user = new User();
97		$user->id = "myuser-1234";
98		$user->username = "test";
99
100		$this->dm->persist($user);
101		$this->dm->flush();
102		$this->dm->clear();
103
104		$user = $this->dm->find($this->type, $user->id);
105		$user->username = "test2";
106
107		$this->dm->flush();
108		$this->dm->clear();
109
110		$userNew = $this->dm->find($this->type, $user->id);
111
112		$this->assertEquals($user->username, $userNew->username);
113		}
114
115	View Code Duplication	public function testUpdate2()
		0 ignored issues – show Duplication introduced 2017-09-05 07:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
116		{
117		$user = $this->dm->find($this->type, 1);
118		$user->username = "new-name";
119
120		$this->dm->flush();
121		$this->dm->clear();
122
123		$newUser = $this->dm->find($this->type, 1);
124		$this->assertEquals('new-name', $newUser->username);
125		}
126
127		public function testRemove()
128		{
129		$user = $this->dm->find($this->type, 1);
130
131		$this->dm->remove($user);
132		$this->dm->flush();
133
134		$newUser = $this->dm->find($this->type, 1);
135		$this->assertNull($newUser);
136		}
137
138		public function testInsertUpdateMultiple()
139		{
140		$user1 = $this->dm->find($this->type, 1);
141		$user1->username = "new-name";
142
143		$user2 = new User();
144		$user2->id = "myuser-1111";
145		$user2->username = "test";
146
147		$user3 = new User();
148		$user3->id = "myuser-2222";
149		$user3->username = "test";
150
151		$this->dm->persist($user2);
152		$this->dm->persist($user3);
153		$this->dm->flush();
154		$this->dm->clear();
155
156		$pUser1 = $this->dm->find($this->type, 1);
157		$pUser2 = $this->dm->find($this->type, 'myuser-1111');
158		$pUser3 = $this->dm->find($this->type, 'myuser-2222');
159
160		$this->assertEquals('new-name', $pUser1->username);
161		$this->assertEquals('myuser-1111', $pUser2->id);
162		$this->assertEquals('myuser-2222', $pUser3->id);
163		}
164
165		public function testFindTypeValidation()
166		{
167		$this->setExpectedException('Doctrine\ODM\CouchDB\InvalidDocumentTypeException');
168		$user = $this->dm->find($this->type.'2', 1);
		0 ignored issues – show Unused Code introduced 2016-02-16 21:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$user` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
169		}
170
171	View Code Duplication	public function testNullConversionHandledAutomatically()
		0 ignored issues – show Duplication introduced 2017-09-05 07:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
172		{
173		$user1 = $this->dm->find($this->type, 1);
174		$user1->username = null;
175
176		$this->dm->flush();
177		$this->dm->clear();
178
179		$pUser1 = $this->dm->find($this->type, 1);
180
181		$this->assertNull($pUser1->username);
182		}
183
184		public function testFindWrongTypesDoesNotMessUnitOfWork()
185		{
186		try {
187		$user1 = $this->dm->find(__NAMESPACE__ . '\\User2', 1);
		0 ignored issues – show Unused Code introduced 2016-02-16 21:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$user1` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
188
189		$this->fail('Expecting InvalidDocumentTypeException');
190		} catch (InvalidDocumentTypeException $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-16 21:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider adding a comment why this CATCH block is empty. Loading history...
191		}
192
193		$user1 = $this->dm->find(__NAMESPACE__ . '\\User', 1);
194
195		$this->assertEquals('lsmith', $user1->username);
196		}
197
198		public function testKeepTrackOfUnmappedData()
199		{
200		$httpClient = $this->dm->getHttpClient();
201
202		$data = array(
203		'_id' => "2",
204		'username' => 'beberlei',
205		'email' => '[email protected]',
206		'address' => array('city' => 'Bonn', 'country' => 'DE'),
207		'type' => str_replace("\\", ".", $this->type),
208		);
209		$resp = $httpClient->request('PUT', '/' . $this->dm->getDatabase() . '/2', json_encode($data));
210		$this->assertEquals(201, $resp->status);
211
212		$user = $this->dm->find($this->type, 2);
213		$this->assertInstanceOf($this->type, $user);
214		$this->assertEquals('beberlei', $user->username);
215
216		$user->username = 'beberlei2';
217		$this->dm->flush();
218
219		$resp = $httpClient->request('GET', '/' . $this->dm->getDatabase() . '/2');
220		$this->assertEquals(200, $resp->status);
221
222		$data['username'] = 'beberlei2';
223
224		ksort($resp->body);
225		ksort($data);
226		unset($resp->body['_rev']);
227
228		$this->assertEquals($data, $resp->body);
229		}
230		}
231
232		/**
233		* @Document
234		*/
235		class User
236		{
237		/** @Id(strategy="ASSIGNED") */
238		public $id;
239		/** @Field(type="string") */
240		public $username;
241		}
242
243		/**
244		* @Document
245		*/
246		class User2
247		{
248		/** @Id(strategy="ASSIGNED") */
249		public $id;
250		/** @Field(type="string") */
251		public $username;
252		}
253

doctrine / couchdb-odm

Issues (251)

Security Analysis no request data

Tests/ODM/CouchDB/Functional/BasicCrudTest.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like