Issues in doctrine-couchdb.php - All Issues - Inspection of "Merge pull request #134 from mikeSimonson/pr/129" - doctrine/couchdb-odm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 707688...6da863 )

by Mike

created 2017-02-24 16:55 UTC

bin/doctrine-couchdb.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the LGPL. For more information, see
 * <http://www.doctrine-project.org>.
 */

(@include_once __DIR__ . '/../vendor/autoload.php') || @include_once __DIR__ . '/../../../autoload.php';

$classLoader = new \Doctrine\Common\ClassLoader('Doctrine');

$classLoader->register();

$classLoader = new \Doctrine\Common\ClassLoader('Symfony', 'Doctrine');

$classLoader->register();

$configFile = getcwd() . DIRECTORY_SEPARATOR . 'cli-config.php';

$helperSet = null;
if (file_exists($configFile)) {
    if ( ! is_readable($configFile)) {
        trigger_error(
            'Configuration file [' . $configFile . '] does not have read permission.', E_ERROR
        );
    }

    require $configFile;

    foreach ($GLOBALS as $helperSetCandidate) {
        if ($helperSetCandidate instanceof \Symfony\Component\Console\Helper\HelperSet) {
            $helperSet = $helperSetCandidate;
            break;
        }
    }
}

$cli = new \Symfony\Component\Console\Application('Doctrine CouchDB CLI', Doctrine\ODM\CouchDB\Version::VERSION);
$cli->setHelperSet($helperSet);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
$cli->addCommands(array(
    new \Doctrine\CouchDB\Tools\Console\Command\ReplicationStartCommand(),
    new \Doctrine\CouchDB\Tools\Console\Command\ReplicationCancelCommand(),
    new \Doctrine\CouchDB\Tools\Console\Command\ViewCleanupCommand(),
    new \Doctrine\CouchDB\Tools\Console\Command\CompactDatabaseCommand(),
    new \Doctrine\CouchDB\Tools\Console\Command\CompactViewCommand(),
    new \Doctrine\CouchDB\Tools\Console\Command\MigrationCommand(),
    new \Doctrine\ODM\CouchDB\Tools\Console\Command\GenerateProxiesCommand(),
    new \Doctrine\ODM\CouchDB\Tools\Console\Command\UpdateDesignDocCommand(),
));
$cli->run();


1			<?php
2			/*
3			* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
4			* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
5			* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
6			* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
7			* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
8			* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
9			* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
10			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
11			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
12			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
13			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
14			*
15			* This software consists of voluntary contributions made by many individuals
16			* and is licensed under the LGPL. For more information, see
17			* <http://www.doctrine-project.org>.
18			*/
19
20			(@include_once __DIR__ . '/../vendor/autoload.php') \|\| @include_once __DIR__ . '/../../../autoload.php';
21
22			$classLoader = new \Doctrine\Common\ClassLoader('Doctrine');
			0 ignored issues – show Deprecated Code introduced 2016-02-16 21:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `Doctrine\Common\ClassLoader` has been deprecated with message: the ClassLoader is deprecated and will be removed in version 3.0 of doctrine/common. This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
23			$classLoader->register();
24
25			$classLoader = new \Doctrine\Common\ClassLoader('Symfony', 'Doctrine');
			0 ignored issues – show Deprecated Code introduced 2016-02-16 21:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `Doctrine\Common\ClassLoader` has been deprecated with message: the ClassLoader is deprecated and will be removed in version 3.0 of doctrine/common. This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
26			$classLoader->register();
27
28			$configFile = getcwd() . DIRECTORY_SEPARATOR . 'cli-config.php';
29
30			$helperSet = null;
31			if (file_exists($configFile)) {
32			if ( ! is_readable($configFile)) {
33			trigger_error(
34			'Configuration file [' . $configFile . '] does not have read permission.', E_ERROR
35			);
36			}
37
38			require $configFile;
39
40			foreach ($GLOBALS as $helperSetCandidate) {
41			if ($helperSetCandidate instanceof \Symfony\Component\Console\Helper\HelperSet) {
42			$helperSet = $helperSetCandidate;
43			break;
44			}
45			}
46			}
47
48			$cli = new \Symfony\Component\Console\Application('Doctrine CouchDB CLI', Doctrine\ODM\CouchDB\Version::VERSION);
49			$cli->setHelperSet($helperSet);
			0 ignored issues – show Bug introduced 2016-02-16 21:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$helperSet` defined by `null` on line `30` can be `null`; however, `Symfony\Component\Consol...ication::setHelperSet()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
50			$cli->addCommands(array(
51			new \Doctrine\CouchDB\Tools\Console\Command\ReplicationStartCommand(),
52			new \Doctrine\CouchDB\Tools\Console\Command\ReplicationCancelCommand(),
53			new \Doctrine\CouchDB\Tools\Console\Command\ViewCleanupCommand(),
54			new \Doctrine\CouchDB\Tools\Console\Command\CompactDatabaseCommand(),
55			new \Doctrine\CouchDB\Tools\Console\Command\CompactViewCommand(),
56			new \Doctrine\CouchDB\Tools\Console\Command\MigrationCommand(),
57			new \Doctrine\ODM\CouchDB\Tools\Console\Command\GenerateProxiesCommand(),
58			new \Doctrine\ODM\CouchDB\Tools\Console\Command\UpdateDesignDocCommand(),
59			));
60			$cli->run();
61

doctrine / couchdb-odm

Push — master ( 707688...6da863 )

bin/doctrine-couchdb.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like