doctrine /
couchdb-odm
| Conditions | 22 |
| Paths | 6 |
| Total Lines | 79 |
| Code Lines | 51 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 57 | public function serializeEmbeddedDocument($embeddedValue, $embeddedFieldMapping, $embedMany = false) |
||
| 58 | { |
||
| 59 | if ($embeddedValue === null) { |
||
| 60 | return null; |
||
| 61 | } |
||
| 62 | |||
| 63 | if (!$embedMany && 'many' == $embeddedFieldMapping['embedded'] && (is_array($embeddedValue) || $embeddedValue instanceof \Traversable)) { |
||
| 64 | $data = array(); |
||
| 65 | foreach ($embeddedValue as $key => $val) { |
||
| 66 | $data[$key] = $this->serializeEmbeddedDocument($val, $embeddedFieldMapping, true); |
||
| 67 | } |
||
| 68 | } else { |
||
| 69 | $embeddedClass = null; |
||
|
|
|||
| 70 | if (isset($embeddedFieldMapping['targetDocument'])) { |
||
| 71 | $embeddedClass = $this->metadataFactory->getMetadataFor(ClassUtils::getClass($embeddedValue)); |
||
| 72 | |||
| 73 | if ($embeddedClass->name !== $embeddedFieldMapping['targetDocument'] && |
||
| 74 | !is_subclass_of($embeddedClass->name, $embeddedFieldMapping['targetDocument']) ) { |
||
| 75 | |||
| 76 | throw new \InvalidArgumentException( |
||
| 77 | 'Mismatching metadata description in the EmbeddedDocument, expected class ' . |
||
| 78 | $embeddedFieldMapping['targetDocument'] . ' but got ' . get_class($embeddedValue) |
||
| 79 | ); |
||
| 80 | } |
||
| 81 | } else { |
||
| 82 | $embeddedClass = $this->metadataFactory->getMetadataFor(get_class($embeddedValue)); |
||
| 83 | } |
||
| 84 | |||
| 85 | $data = $this->metadataResolver->createDefaultDocumentStruct($embeddedClass); |
||
| 86 | foreach($embeddedClass->reflFields AS $fieldName => $reflProperty) { |
||
| 87 | $value = $reflProperty->getValue($embeddedValue); |
||
| 88 | |||
| 89 | if (isset($fieldName, $embeddedClass->fieldMappings[$fieldName])) { |
||
| 90 | $fieldMapping = $embeddedClass->fieldMappings[$fieldName]; |
||
| 91 | } elseif (isset($embeddedClass->associationsMappings, $embeddedClass->associationsMappings[$fieldName])) { |
||
| 92 | /** @see UnitOfWork::flush() */ |
||
| 93 | if ($embeddedClass->associationsMappings[$fieldName]['type'] & ClassMetadata::TO_ONE) { |
||
| 94 | $fieldValue = null; |
||
| 95 | if (\is_object($value)) { |
||
| 96 | $fieldValueMetadata = $this->metadataFactory->getMetadataFor(get_class($value)); |
||
| 97 | $fieldValue = $fieldValueMetadata->getIdentifierValue($value); |
||
| 98 | } |
||
| 99 | $data['doctrine_metadata']['associations'][] = $fieldName; |
||
| 100 | $data[$fieldName] = $fieldValue; |
||
| 101 | } else if ($embeddedClass->associationsMappings[$fieldName]['type'] & ClassMetadata::TO_MANY) { |
||
| 102 | |||
| 103 | if ($embeddedClass->associationsMappings[$fieldName]['isOwning']) { |
||
| 104 | // TODO: Optimize when not initialized yet! In ManyToMany case we can keep track of ALL ids |
||
| 105 | $ids = array(); |
||
| 106 | if (is_array($value) || $value instanceof \Doctrine\Common\Collections\Collection) { |
||
| 107 | foreach ($value AS $key => $relatedObject) { |
||
| 108 | $fieldValueMetadata = $this->metadataFactory->getMetadataFor(get_class($relatedObject)); |
||
| 109 | $ids[$key] = $fieldValueMetadata->getIdentifierValue($relatedObject); |
||
| 110 | } |
||
| 111 | } |
||
| 112 | |||
| 113 | $data['doctrine_metadata']['associations'][] = $ids; |
||
| 114 | $data[$fieldName] = $ids; |
||
| 115 | } |
||
| 116 | } |
||
| 117 | |||
| 118 | continue; |
||
| 119 | } else { |
||
| 120 | $fieldMapping = []; |
||
| 121 | } |
||
| 122 | |||
| 123 | if ($value === null) { |
||
| 124 | continue; |
||
| 125 | } else if (isset($fieldMapping['embedded'])) { |
||
| 126 | $data[$fieldMapping['jsonName']] = $this->serializeEmbeddedDocument($value, $fieldMapping); |
||
| 127 | } else { |
||
| 128 | $data[$fieldMapping['jsonName']] = Type::getType($fieldMapping['type']) |
||
| 129 | ->convertToCouchDBValue($value); |
||
| 130 | } |
||
| 131 | } |
||
| 132 | } |
||
| 133 | |||
| 134 | return $data; |
||
| 135 | } |
||
| 136 | |||
| 299 |
Loading history...
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.