MongoDBCacheTest::testGetStats() - Code Metrics - Inspection of "Merge pull request #132 from doctrine/scrutinizer-..." - doctrine/cache - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a8b991...dda2b8 )

by Marco

created 2015-12-31 17:56 UTC

MongoDBCacheTest::testGetStats() A

↳ Parent: MongoDBCacheTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	11
rs	9.4286
cc	1
eloc	8
nc	1
nop	0

<?php

namespace Doctrine\Tests\Common\Cache;

use Doctrine\Common\Cache\Cache;
use Doctrine\Common\Cache\MongoDBCache;
use MongoClient;
use MongoCollection;

/**
 * @requires extension mongo
 */
class MongoDBCacheTest extends CacheTest
{
    /**
     * @var MongoCollection
     */
    private $collection;

    protected function setUp()
    {
        if ( ! version_compare(phpversion('mongo'), '1.3.0', '>=')) {
            $this->markTestSkipped('Mongo >= 1.3.0 is required.');
        }

        $mongo = new MongoClient();
        $this->collection = $mongo->selectCollection('doctrine_common_cache', 'test');
    }

    protected function tearDown()
    {
        if ($this->collection instanceof MongoCollection) {
            $this->collection->drop();
        }
    }

    public function testGetStats()
    {
        $cache = $this->_getCacheDriver();
        $stats = $cache->getStats();

        $this->assertNull($stats[Cache::STATS_HITS]);
        $this->assertNull($stats[Cache::STATS_MISSES]);
        $this->assertGreaterThan(0, $stats[Cache::STATS_UPTIME]);
        $this->assertEquals(0, $stats[Cache::STATS_MEMORY_USAGE]);
        $this->assertNull($stats[Cache::STATS_MEMORY_AVAILABLE]);
    }

    /**
     * @group 108
     */
    public function testMongoCursorExceptionsDoNotBubbleUp()
    {
        /* @var $collection \MongoCollection|\PHPUnit_Framework_MockObject_MockObject */
        $collection = $this->getMock('MongoCollection', array(), array(), '', false);

        $collection->expects(self::once())->method('update')->willThrowException(new \MongoCursorException());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $cache = new MongoDBCache($collection);

        self::assertFalse($cache->save('foo', 'bar'));
    }

    protected function _getCacheDriver()
    {
        return new MongoDBCache($this->collection);
    }
}


1			<?php
2
3			namespace Doctrine\Tests\Common\Cache;
4
5			use Doctrine\Common\Cache\Cache;
6			use Doctrine\Common\Cache\MongoDBCache;
7			use MongoClient;
8			use MongoCollection;
9
10			/**
11			* @requires extension mongo
12			*/
13			class MongoDBCacheTest extends CacheTest
14			{
15			/**
16			* @var MongoCollection
17			*/
18			private $collection;
19
20			protected function setUp()
21			{
22			if ( ! version_compare(phpversion('mongo'), '1.3.0', '>=')) {
23			$this->markTestSkipped('Mongo >= 1.3.0 is required.');
24			}
25
26			$mongo = new MongoClient();
27			$this->collection = $mongo->selectCollection('doctrine_common_cache', 'test');
28			}
29
30			protected function tearDown()
31			{
32			if ($this->collection instanceof MongoCollection) {
33			$this->collection->drop();
34			}
35			}
36
37			public function testGetStats()
38			{
39			$cache = $this->_getCacheDriver();
40			$stats = $cache->getStats();
41
42			$this->assertNull($stats[Cache::STATS_HITS]);
43			$this->assertNull($stats[Cache::STATS_MISSES]);
44			$this->assertGreaterThan(0, $stats[Cache::STATS_UPTIME]);
45			$this->assertEquals(0, $stats[Cache::STATS_MEMORY_USAGE]);
46			$this->assertNull($stats[Cache::STATS_MEMORY_AVAILABLE]);
47			}
48
49			/**
50			* @group 108
51			*/
52			public function testMongoCursorExceptionsDoNotBubbleUp()
53			{
54			/* @var $collection \MongoCollection\|\PHPUnit_Framework_MockObject_MockObject */
55			$collection = $this->getMock('MongoCollection', array(), array(), '', false);
56
57			$collection->expects(self::once())->method('update')->willThrowException(new \MongoCursorException());
			0 ignored issues – show Bug introduced 2015-12-31 17:39 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `MongoCollection`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
58
59			$cache = new MongoDBCache($collection);
60
61			self::assertFalse($cache->save('foo', 'bar'));
62			}
63
64			protected function _getCacheDriver()
65			{
66			return new MongoDBCache($this->collection);
67			}
68			}
69

doctrine / cache

Push — master ( a8b991...dda2b8 )

MongoDBCacheTest::testGetStats() A

Complexity

Size

Duplication

Available Fixes

Duplication Side-by-Side

Filter issues like