Completed
Pull Request — master (#155)
by Benoît
04:01
created
lib/Doctrine/Common/Cache/RedisCache.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
 
96 96
             // Keys have lifetime, use SETEX for each of them
97 97
             foreach ($keysAndValues as $key => $value) {
98
-                if (!$this->redis->setex($key, $lifetime, $value)) {
98
+                if ( ! $this->redis->setex($key, $lifetime, $value)) {
99 99
                     $success = false;
100 100
                 }
101 101
             }
Please login to merge, or discard this patch.
tests/Doctrine/Tests/Common/Cache/ChainCacheTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Doctrine\Tests\Common\Cache;
4 4
 
5
-use Doctrine\Common\Cache\ApcCache;
6 5
 use Doctrine\Common\Cache\ArrayCache;
7 6
 use Doctrine\Common\Cache\ChainCache;
8 7
 
Please login to merge, or discard this patch.
lib/Doctrine/Common/Cache/CacheProvider.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
      */
197 197
     private function getNamespacedId($id)
198 198
     {
199
-        $namespaceVersion  = $this->getNamespaceVersion();
199
+        $namespaceVersion = $this->getNamespaceVersion();
200 200
 
201 201
         return sprintf('%s[%s][%s]', $this->namespace, $id, $namespaceVersion);
202 202
     }
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
         $success = true;
280 280
 
281 281
         foreach ($keysAndValues as $key => $value) {
282
-            if (!$this->doSave($key, $value, $lifetime)) {
282
+            if ( ! $this->doSave($key, $value, $lifetime)) {
283 283
                 $success = false;
284 284
             }
285 285
         }
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
311 311
         $success = true;
312 312
 
313 313
         foreach ($keys as $key) {
314
-            if (!$this->doDelete($key)) {
314
+            if ( ! $this->doDelete($key)) {
315 315
                 $success = false;
316 316
             }
317 317
         }
Please login to merge, or discard this patch.
lib/Doctrine/Common/Cache/ChainCache.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
                 $value = $cacheProvider->doFetch($id);
66 66
 
67 67
                 // We populate all the previous cache layers (that are assumed to be faster)
68
-                for ($subKey = $key - 1 ; $subKey >= 0 ; $subKey--) {
68
+                for ($subKey = $key - 1; $subKey >= 0; $subKey--) {
69 69
                     $this->cacheProviders[$subKey]->doSave($id, $value);
70 70
                 }
71 71
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 
90 90
             // We populate all the previous cache layers (that are assumed to be faster)
91 91
             if (count($values) === $count) {
92
-                for ($subKey = $key - 1 ; $subKey >= 0 ; $subKey--) {
92
+                for ($subKey = $key - 1; $subKey >= 0; $subKey--) {
93 93
                     $this->cacheProviders[$subKey]->doSaveMultiple($values);
94 94
                 }
95 95
 
Please login to merge, or discard this patch.