Completed
Pull Request — master (#184)
by Marco
03:55
created
lib/Doctrine/Common/Cache/PhpFileCache.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     {
44 44
         parent::__construct($directory, $extension, $umask);
45 45
 
46
-        self::$emptyErrorHandler = function () {
46
+        self::$emptyErrorHandler = function() {
47 47
         };
48 48
     }
49 49
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     {
55 55
         $value = $this->includeFileForId($id);
56 56
 
57
-        if (! $value) {
57
+        if ( ! $value) {
58 58
             return false;
59 59
         }
60 60
 
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
     {
73 73
         $value = $this->includeFileForId($id);
74 74
 
75
-        if (! $value) {
75
+        if ( ! $value) {
76 76
             return false;
77 77
         }
78 78
 
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
             $lifeTime = time() + $lifeTime;
89 89
         }
90 90
 
91
-        $filename  = $this->getFilename($id);
91
+        $filename = $this->getFilename($id);
92 92
 
93 93
         $value = [
94 94
             'lifetime'  => $lifeTime,
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 
123 123
         restore_error_handler();
124 124
 
125
-        if (! isset($value['lifetime'])) {
125
+        if ( ! isset($value['lifetime'])) {
126 126
             return false;
127 127
         }
128 128
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/Common/Cache/BaseFileCacheTest.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,6 +69,9 @@  discard block
 block discarded – undo
69 69
         ];
70 70
     }
71 71
 
72
+    /**
73
+     * @param integer $pathLength
74
+     */
72 75
     private static function getBasePathForWindowsPathLengthTests($pathLength)
73 76
     {
74 77
         return FileCacheTest::getBasePathForWindowsPathLengthTests($pathLength);
@@ -78,7 +81,7 @@  discard block
 block discarded – undo
78 81
      * @param int    $length
79 82
      * @param string $basePath
80 83
      *
81
-     * @return array
84
+     * @return string[]
82 85
      */
83 86
     private static function getKeyAndPathFittingLength($length, $basePath)
84 87
     {
Please login to merge, or discard this patch.
tests/Doctrine/Tests/Common/Cache/FileCacheTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -170,7 +170,7 @@
 block discarded – undo
170 170
      * @param int    $length
171 171
      * @param string $basePath
172 172
      *
173
-     * @return array
173
+     * @return string[]
174 174
      */
175 175
     public static function getKeyAndPathFittingLength($length, $basePath)
176 176
     {
Please login to merge, or discard this patch.
lib/Doctrine/Common/Cache/CacheProvider.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
      */
113 113
     public function saveMultiple(array $keysAndValues, $lifetime = 0)
114 114
     {
115
-        if (! is_numeric($lifetime)) {
115
+        if ( ! is_numeric($lifetime)) {
116 116
             throw LifeTimeException::fromNonIntegerLifetime($lifetime);
117 117
         }
118 118
 
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
      */
144 144
     public function save($id, $data, $lifeTime = 0)
145 145
     {
146
-        if (! is_numeric($lifeTime)) {
146
+        if ( ! is_numeric($lifeTime)) {
147 147
             throw LifeTimeException::fromNonIntegerLifetime($lifeTime);
148 148
         }
149 149
 
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
      */
205 205
     private function getNamespacedId($id)
206 206
     {
207
-        $namespaceVersion  = $this->getNamespaceVersion();
207
+        $namespaceVersion = $this->getNamespaceVersion();
208 208
 
209 209
         return sprintf('%s[%s][%s]', $this->namespace, $id, $namespaceVersion);
210 210
     }
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
         $success = true;
288 288
 
289 289
         foreach ($keysAndValues as $key => $value) {
290
-            if (!$this->doSave($key, $value, $lifetime)) {
290
+            if ( ! $this->doSave($key, $value, $lifetime)) {
291 291
                 $success = false;
292 292
             }
293 293
         }
Please login to merge, or discard this patch.