ArrayType::describe() - Code Metrics - Inspection of "Type hiearchy for property types and enums" - doctrine/annotations - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#256)

by Michael

created 2019-03-29 00:48 UTC

ArrayType::describe() A

↳ Parent: ArrayType

Complexity

Conditions	4
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	4

Importance

Changes

Metric	Value
eloc	5
dl	0
loc	10
ccs	6
cts	6
cp	1
rs	10
c	0
b	0
f	0
cc	4
nc	2
nop	0
crap	4

<?php

declare(strict_types=1);

namespace Doctrine\Annotations\Type;

use function is_array;
use function sprintf;

/**
 * @internal
 */
class ArrayType implements Type
{
    /** @var Type */
    private $keyType;

    /** @var Type */
    private $valueType;

    public function __construct(Type $keyType, Type $valueType)
    {
        $this->keyType   = $keyType;
        $this->valueType = $valueType;
    }

    public function getKeyType() : Type
    {
        return $this->keyType;
    }

    public function getValueType() : Type
    {
        return $this->valueType;
    }

    public function describe() : string
    {
        if ($this->keyType instanceof MixedType
            || $this->keyType->describe() === 'int|string'
            || $this->keyType->describe() === 'string|int'
        ) {
            return sprintf('array<%s>', $this->valueType->describe());
        }

        return sprintf('array<%s, %s>', $this->keyType->describe(), $this->valueType->describe());
    }

    /**
     * @param mixed $value
     */
    public function validate($value) : bool
    {
        if (! is_array($value)) {
            return false;
        }

        foreach ($value as $key => $innerValue) {
            if (! $this->keyType->validate($key)) {
                return false;
            }

            if (! $this->valueType->validate($innerValue)) {
                return false;
            }
        }

        return true;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\Annotations\Type;
6
7		use function is_array;
8		use function sprintf;
9
10		/**
11		* @internal
12		*/
13		class ArrayType implements Type
14		{
15		/** @var Type */
16		private $keyType;
17
18		/** @var Type */
19		private $valueType;
20
21	296	public function __construct(Type $keyType, Type $valueType)
22		{
23	296	$this->keyType = $keyType;
24	296	$this->valueType = $valueType;
25	296	}
26
27	1	public function getKeyType() : Type
28		{
29	1	return $this->keyType;
30		}
31
32	205	public function getValueType() : Type
33		{
34	205	return $this->valueType;
35		}
36
37	7	public function describe() : string
38		{
39	7	if ($this->keyType instanceof MixedType
40	5	\|\| $this->keyType->describe() === 'int\|string'
41	7	\|\| $this->keyType->describe() === 'string\|int'
42		) {
43	4	return sprintf('array<%s>', $this->valueType->describe());
44		}
45
46	3	return sprintf('array<%s, %s>', $this->keyType->describe(), $this->valueType->describe());
47		}
48
49		/**
50		* @param mixed $value
51		*/
52	218	public function validate($value) : bool
53		{
54	218	if (! is_array($value)) {
55	3	return false;
56		}
57
58	215	foreach ($value as $key => $innerValue) {
59	213	if (! $this->keyType->validate($key)) {
60	1	return false;
61		}
62
63	212	if (! $this->valueType->validate($innerValue)) {
64	39	return false;
65		}
66		}
67
68	211	return true;
69		}
70		}
71

doctrine / annotations

Pull Request — master (#256)

ArrayType::describe() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like