Conditions | 1 |
Paths | 1 |
Total Lines | 66 |
Code Lines | 51 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
30 | public static function createMetadata() : MetadataCollection |
||
31 | { |
||
32 | return new MetadataCollection( |
||
33 | new AnnotationMetadata( |
||
34 | Attribute::class, |
||
35 | AnnotationTarget::annotation(), |
||
36 | false, |
||
37 | new PropertyMetadata( |
||
38 | 'name', |
||
39 | ['type' => 'string'], |
||
40 | true, |
||
41 | true |
||
42 | ), |
||
43 | new PropertyMetadata( |
||
44 | 'type', |
||
45 | ['type' => 'string'], |
||
46 | true |
||
47 | ), |
||
48 | new PropertyMetadata( |
||
49 | 'required', |
||
50 | ['type' => 'boolean'] |
||
51 | ) |
||
52 | ), |
||
53 | new AnnotationMetadata( |
||
54 | Attributes::class, |
||
55 | AnnotationTarget::class(), |
||
56 | false, |
||
57 | new PropertyMetadata( |
||
58 | 'value', |
||
59 | [ |
||
60 | 'type' => 'array', |
||
61 | 'array_type' =>'Doctrine\Annotations\Annotation\Attribute', |
||
62 | 'value' =>'array<Doctrine\Annotations\Annotation\Attribute>', |
||
63 | ], |
||
64 | true, |
||
65 | true |
||
66 | ) |
||
67 | ), |
||
68 | new AnnotationMetadata( |
||
69 | Enum::class, |
||
70 | AnnotationTarget::property(), |
||
71 | true, |
||
72 | new PropertyMetadata( |
||
73 | 'value', |
||
74 | ['type' => 'array'], |
||
75 | true, |
||
76 | true |
||
77 | ), |
||
78 | new PropertyMetadata( |
||
79 | 'literal', |
||
80 | ['type' => 'array'] |
||
81 | ) |
||
82 | ), |
||
83 | new AnnotationMetadata( |
||
84 | Target::class, |
||
85 | AnnotationTarget::class(), |
||
86 | true, |
||
87 | new PropertyMetadata( |
||
88 | 'value', |
||
89 | [ |
||
90 | 'type' =>'array', |
||
91 | 'array_type'=>'string', |
||
92 | 'value' =>'array<string>', |
||
93 | ], |
||
94 | false, |
||
95 | true |
||
96 | ) |
||
101 |