ConfigurationFactory::__invoke() - Code Metrics - Inspection of "Merge pull request #562 from kokspflanze/feature/p..." - doctrine/DoctrineORMModule - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dcca99...06202c )

by Tom

created 2018-03-30 19:58 UTC

ConfigurationFactory::__invoke() F

↳ Parent: ConfigurationFactory

Complexity

Conditions	22
Paths	10576

Size

Total Lines	128
Code Lines	74

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	59
CRAP Score	23.8766

Importance

Changes

Metric	Value
dl	0
loc	128
ccs	59
cts	70
cp	0.8429
rs	2
c	0
b	0
f	0
cc	22
eloc	74
nc	10576
nop	3
crap	23.8766

How to fix Long Method Complexity

<?php

namespace DoctrineORMModule\Service;

use Doctrine\ORM\Cache\CacheConfiguration;
use Doctrine\ORM\Cache\DefaultCacheFactory;
use Doctrine\ORM\Cache\RegionsConfiguration;
use Doctrine\ORM\Mapping\EntityListenerResolver;
use DoctrineORMModule\Options\Configuration as DoctrineORMModuleConfiguration;
use DoctrineORMModule\Service\DBALConfigurationFactory as DoctrineConfigurationFactory;
use Interop\Container\ContainerInterface;
use Zend\ServiceManager\ServiceLocatorInterface;
use Zend\ServiceManager\Exception\InvalidArgumentException;
use Doctrine\ORM\Configuration;

class ConfigurationFactory extends DoctrineConfigurationFactory
{
    /**
     * {@inheritDoc}
     *
     * @return Configuration
     */
    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
    {
        /** @var $options DoctrineORMModuleConfiguration */
        $options = $this->getOptions($container);
        $config  = new Configuration();

        $config->setAutoGenerateProxyClasses($options->getGenerateProxies());
        $config->setProxyDir($options->getProxyDir());
        $config->setProxyNamespace($options->getProxyNamespace());

        $config->setEntityNamespaces($options->getEntityNamespaces());

        $config->setCustomDatetimeFunctions($options->getDatetimeFunctions());
        $config->setCustomStringFunctions($options->getStringFunctions());
        $config->setCustomNumericFunctions($options->getNumericFunctions());

        $config->setClassMetadataFactoryName($options->getClassMetadataFactoryName());

        foreach ($options->getNamedQueries() as $name => $query) {
            $config->addNamedQuery($name, $query);
        }

        foreach ($options->getNamedNativeQueries() as $name => $query) {
            $config->addNamedNativeQuery($name, $query['sql'], new $query['rsm']);
        }

        foreach ($options->getCustomHydrationModes() as $modeName => $hydrator) {
            $config->addCustomHydrationMode($modeName, $hydrator);
        }

        foreach ($options->getFilters() as $name => $class) {
            $config->addFilter($name, $class);
        }

        $config->setMetadataCacheImpl($container->get($options->getMetadataCache()));
        $config->setQueryCacheImpl($container->get($options->getQueryCache()));
        $config->setResultCacheImpl($container->get($options->getResultCache()));
        $config->setHydrationCacheImpl($container->get($options->getHydrationCache()));
        $config->setMetadataDriverImpl($container->get($options->getDriver()));

        if ($namingStrategy = $options->getNamingStrategy()) {
            if (is_string($namingStrategy)) {
                if (! $container->has($namingStrategy)) {
                    throw new InvalidArgumentException(sprintf('Naming strategy "%s" not found', $namingStrategy));
                }

                $config->setNamingStrategy($container->get($namingStrategy));
            } else {
                $config->setNamingStrategy($namingStrategy);
            }
        }

        if ($quoteStrategy = $options->getQuoteStrategy()) {
            if (is_string($quoteStrategy)) {
                if (! $container->has($quoteStrategy)) {
                    throw new InvalidArgumentException(sprintf('Quote strategy "%s" not found', $quoteStrategy));
                }

                $config->setQuoteStrategy($container->get($quoteStrategy));
            } else {
                $config->setQuoteStrategy($quoteStrategy);
            }
        }

        if ($repositoryFactory = $options->getRepositoryFactory()) {
            if (is_string($repositoryFactory)) {
                if (! $container->has($repositoryFactory)) {
                    throw new InvalidArgumentException(
                        sprintf('Repository factory "%s" not found', $repositoryFactory)
                    );
                }

                $config->setRepositoryFactory($container->get($repositoryFactory));
            } else {
                $config->setRepositoryFactory($repositoryFactory);
            }
        }

        if ($entityListenerResolver = $options->getEntityListenerResolver()) {
            if ($entityListenerResolver instanceof EntityListenerResolver) {
                $config->setEntityListenerResolver($entityListenerResolver);
            } else {
                $config->setEntityListenerResolver($container->get($entityListenerResolver));
            }
        }

        $secondLevelCache = $options->getSecondLevelCache();

        if ($secondLevelCache->isEnabled()) {
            $regionsConfig = new RegionsConfiguration(
                $secondLevelCache->getDefaultLifetime(),
                $secondLevelCache->getDefaultLockLifetime()
            );

            foreach ($secondLevelCache->getRegions() as $regionName => $regionConfig) {
                if (isset($regionConfig['lifetime'])) {
                    $regionsConfig->setLifetime($regionName, $regionConfig['lifetime']);
                }

                if (isset($regionConfig['lock_lifetime'])) {
                    $regionsConfig->setLockLifetime($regionName, $regionConfig['lock_lifetime']);
                }
            }

            // As Second Level Cache caches queries results, we reuse the result cache impl
            $cacheFactory = new DefaultCacheFactory($regionsConfig, $config->getResultCacheImpl());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            $cacheFactory->setFileLockRegionDirectory($secondLevelCache->getFileLockRegionDirectory());

            $cacheConfiguration = new CacheConfiguration();
            $cacheConfiguration->setCacheFactory($cacheFactory);
            $cacheConfiguration->setRegionsConfiguration($regionsConfig);

            $config->setSecondLevelCacheEnabled();
            $config->setSecondLevelCacheConfiguration($cacheConfiguration);
        }

        if ($filterSchemaAssetsExpression = $options->getFilterSchemaAssetsExpression()) {
            $config->setFilterSchemaAssetsExpression($filterSchemaAssetsExpression);
        }

        if ($className = $options->getDefaultRepositoryClassName()) {
            $config->setDefaultRepositoryClassName($className);
        }

        $this->setupDBALConfiguration($container, $config);

        return $config;
    }

    public function createService(ServiceLocatorInterface $container)
    {
        return $this($container, Configuration::class);
    }

    /**
     * @return string
     */
    protected function getOptionsClass()
    {
        return DoctrineORMModuleConfiguration::class;
    }
}


1		<?php
2
3		namespace DoctrineORMModule\Service;
4
5		use Doctrine\ORM\Cache\CacheConfiguration;
6		use Doctrine\ORM\Cache\DefaultCacheFactory;
7		use Doctrine\ORM\Cache\RegionsConfiguration;
8		use Doctrine\ORM\Mapping\EntityListenerResolver;
9		use DoctrineORMModule\Options\Configuration as DoctrineORMModuleConfiguration;
10		use DoctrineORMModule\Service\DBALConfigurationFactory as DoctrineConfigurationFactory;
11		use Interop\Container\ContainerInterface;
12		use Zend\ServiceManager\ServiceLocatorInterface;
13		use Zend\ServiceManager\Exception\InvalidArgumentException;
14		use Doctrine\ORM\Configuration;
15
16		class ConfigurationFactory extends DoctrineConfigurationFactory
17		{
18		/**
19		* {@inheritDoc}
20		*
21		* @return Configuration
22		*/
23	88	public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
24		{
25		/** @var $options DoctrineORMModuleConfiguration */
26	88	$options = $this->getOptions($container);
27	88	$config = new Configuration();
28
29	88	$config->setAutoGenerateProxyClasses($options->getGenerateProxies());
30	88	$config->setProxyDir($options->getProxyDir());
31	88	$config->setProxyNamespace($options->getProxyNamespace());
32
33	88	$config->setEntityNamespaces($options->getEntityNamespaces());
34
35	88	$config->setCustomDatetimeFunctions($options->getDatetimeFunctions());
36	88	$config->setCustomStringFunctions($options->getStringFunctions());
37	88	$config->setCustomNumericFunctions($options->getNumericFunctions());
38
39	88	$config->setClassMetadataFactoryName($options->getClassMetadataFactoryName());
40
41	88	foreach ($options->getNamedQueries() as $name => $query) {
42		$config->addNamedQuery($name, $query);
43		}
44
45	88	foreach ($options->getNamedNativeQueries() as $name => $query) {
46		$config->addNamedNativeQuery($name, $query['sql'], new $query['rsm']);
47		}
48
49	88	foreach ($options->getCustomHydrationModes() as $modeName => $hydrator) {
50		$config->addCustomHydrationMode($modeName, $hydrator);
51		}
52
53	88	foreach ($options->getFilters() as $name => $class) {
54		$config->addFilter($name, $class);
55		}
56
57	88	$config->setMetadataCacheImpl($container->get($options->getMetadataCache()));
58	88	$config->setQueryCacheImpl($container->get($options->getQueryCache()));
59	88	$config->setResultCacheImpl($container->get($options->getResultCache()));
60	88	$config->setHydrationCacheImpl($container->get($options->getHydrationCache()));
61	88	$config->setMetadataDriverImpl($container->get($options->getDriver()));
62
63	88	if ($namingStrategy = $options->getNamingStrategy()) {
64	3	if (is_string($namingStrategy)) {
65	2	if (! $container->has($namingStrategy)) {
66	1	throw new InvalidArgumentException(sprintf('Naming strategy "%s" not found', $namingStrategy));
67		}
68
69	1	$config->setNamingStrategy($container->get($namingStrategy));
70		} else {
71	1	$config->setNamingStrategy($namingStrategy);
72		}
73		}
74
75	87	if ($quoteStrategy = $options->getQuoteStrategy()) {
76	3	if (is_string($quoteStrategy)) {
77	2	if (! $container->has($quoteStrategy)) {
78	1	throw new InvalidArgumentException(sprintf('Quote strategy "%s" not found', $quoteStrategy));
79		}
80
81	1	$config->setQuoteStrategy($container->get($quoteStrategy));
82		} else {
83	1	$config->setQuoteStrategy($quoteStrategy);
84		}
85		}
86
87	86	if ($repositoryFactory = $options->getRepositoryFactory()) {
88		if (is_string($repositoryFactory)) {
89		if (! $container->has($repositoryFactory)) {
90		throw new InvalidArgumentException(
91		sprintf('Repository factory "%s" not found', $repositoryFactory)
92		);
93		}
94
95		$config->setRepositoryFactory($container->get($repositoryFactory));
96		} else {
97		$config->setRepositoryFactory($repositoryFactory);
98		}
99		}
100
101	86	if ($entityListenerResolver = $options->getEntityListenerResolver()) {
102	2	if ($entityListenerResolver instanceof EntityListenerResolver) {
103	1	$config->setEntityListenerResolver($entityListenerResolver);
104		} else {
105	1	$config->setEntityListenerResolver($container->get($entityListenerResolver));
106		}
107		}
108
109	86	$secondLevelCache = $options->getSecondLevelCache();
110
111	86	if ($secondLevelCache->isEnabled()) {
112	1	$regionsConfig = new RegionsConfiguration(
113	1	$secondLevelCache->getDefaultLifetime(),
114	1	$secondLevelCache->getDefaultLockLifetime()
115		);
116
117	1	foreach ($secondLevelCache->getRegions() as $regionName => $regionConfig) {
118	1	if (isset($regionConfig['lifetime'])) {
119	1	$regionsConfig->setLifetime($regionName, $regionConfig['lifetime']);
120		}
121
122	1	if (isset($regionConfig['lock_lifetime'])) {
123	1	$regionsConfig->setLockLifetime($regionName, $regionConfig['lock_lifetime']);
124		}
125		}
126
127		// As Second Level Cache caches queries results, we reuse the result cache impl
128	1	$cacheFactory = new DefaultCacheFactory($regionsConfig, $config->getResultCacheImpl());
		0 ignored issues – show Bug introduced 2015-12-07 13:24 UTC by Report Bug Copy Issue Report It seems like `$config->getResultCacheImpl()` can be `null`; however, `__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
129	1	$cacheFactory->setFileLockRegionDirectory($secondLevelCache->getFileLockRegionDirectory());
130
131	1	$cacheConfiguration = new CacheConfiguration();
132	1	$cacheConfiguration->setCacheFactory($cacheFactory);
133	1	$cacheConfiguration->setRegionsConfiguration($regionsConfig);
134
135	1	$config->setSecondLevelCacheEnabled();
136	1	$config->setSecondLevelCacheConfiguration($cacheConfiguration);
137		}
138
139	86	if ($filterSchemaAssetsExpression = $options->getFilterSchemaAssetsExpression()) {
140		$config->setFilterSchemaAssetsExpression($filterSchemaAssetsExpression);
141		}
142
143	86	if ($className = $options->getDefaultRepositoryClassName()) {
144	73	$config->setDefaultRepositoryClassName($className);
145		}
146
147	86	$this->setupDBALConfiguration($container, $config);
148
149	86	return $config;
150		}
151
152	88	public function createService(ServiceLocatorInterface $container)
153		{
154	88	return $this($container, Configuration::class);
155		}
156
157		/**
158		* @return string
159		*/
160	88	protected function getOptionsClass()
161		{
162	88	return DoctrineORMModuleConfiguration::class;
163		}
164		}
165

doctrine / DoctrineORMModule

Push — master ( dcca99...06202c )

ConfigurationFactory::__invoke() F

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like