doctrine / DoctrineModule

src/DoctrineModule/Validator/Service/NoObjectExistsFactory.php

<?php

/*
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license. For more information, see
 * <http://www.doctrine-project.org>.
 */

namespace DoctrineModule\Validator\Service;

use Interop\Container\ContainerInterface;
use DoctrineModule\Validator\NoObjectExists;

/**
 * Factory for creating NoObjectExists instances
 *
 * @license MIT
 * @link    http://www.doctrine-project.org/
 * @since   1.3.0
 * @author  Fabian Grutschus <f.grutschus@lubyte.de>
 */
class NoObjectExistsFactory extends AbstractValidatorFactory
{
    protected $validatorClass = NoObjectExists::class;

    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
    {
        $container = $this->container($container);

        $repository = $this->getRepository($container, $options);

It seems like $options defined by parameter $options on line 38 can also be of type null; however, DoctrineModule\Validator\Service\AbstractValidatorFactory::getRepository() does only seem to accept array, maybe add an additional type check?

        $validator = new NoObjectExists($this->merge($options, [

It seems like $options defined by parameter $options on line 38 can also be of type null; however, DoctrineModule\Validator\Service\AbstractValidatorFactory::merge() does only seem to accept array, maybe add an additional type check?

            'object_repository' => $repository,
            'fields'            => $this->getFields($options),

It seems like $options defined by parameter $options on line 38 can also be of type null; however, DoctrineModule\Validator\Service\AbstractValidatorFactory::getFields() does only seem to accept array, maybe add an additional type check?

        ]));

        return $validator;
    }
}