Issues in NoObjectExistsTest.php - New Issues - Inspection of "Merge pull request #697 from doctrine/develop" - doctrine/DoctrineModule - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e0017c...6b1304 )

by Tom

created 2020-04-09 05:25 UTC

Validator/NoObjectExistsTest.php (3 issues)

Labels

Bug 3

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace DoctrineModuleTest\Validator\Adapter;

use DoctrineModule\Validator\NoObjectExists;
use PHPUnit\Framework\TestCase as BaseTestCase;
use stdClass;
use function str_replace;

/**
 * Tests for the NoObjectExists tests
 *
 * @link    http://www.doctrine-project.org/
 */
class NoObjectExistsTest extends BaseTestCase
{
    public function testCanValidateWithNoAvailableObjectInRepository() : void
    {
        $repository = $this->createMock('Doctrine\Persistence\ObjectRepository');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $repository
            ->expects($this->once())
            ->method('findOneBy')
            ->will($this->returnValue(null));

        $validator = new NoObjectExists(['object_repository' => $repository, 'fields' => 'matchKey']);

        $this->assertTrue($validator->isValid('matchValue'));
    }

    public function testCannotValidateWithAvailableObjectInRepository() : void
    {
        $repository = $this->createMock('Doctrine\Persistence\ObjectRepository');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        $repository
            ->expects($this->once())
            ->method('findOneBy')
            ->will($this->returnValue(new stdClass()));

        $validator = new NoObjectExists(['object_repository' => $repository, 'fields' => 'matchKey']);

        $this->assertFalse($validator->isValid('matchValue'));
    }

    public function testErrorMessageIsStringInsteadArray() : void
    {
        $repository = $this->createMock('Doctrine\Persistence\ObjectRepository');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $repository
            ->expects($this->once())
            ->method('findOneBy')
            ->will($this->returnValue(new stdClass()));
        $validator = new NoObjectExists(['object_repository' => $repository, 'fields' => 'matchKey']);

        $this->assertFalse($validator->isValid('matchValue'));

        $messageTemplates = $validator->getMessageTemplates();

        $expectedMessage = str_replace(
            '%value%',
            'matchValue',
            $messageTemplates[NoObjectExists::ERROR_OBJECT_FOUND]
        );
        $messages        = $validator->getMessages();
        $receivedMessage = $messages[NoObjectExists::ERROR_OBJECT_FOUND];

        $this->assertSame($expectedMessage, $receivedMessage);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace DoctrineModuleTest\Validator\Adapter;
6
7			use DoctrineModule\Validator\NoObjectExists;
8			use PHPUnit\Framework\TestCase as BaseTestCase;
9			use stdClass;
10			use function str_replace;
11
12			/**
13			* Tests for the NoObjectExists tests
14			*
15			* @link http://www.doctrine-project.org/
16			*/
17			class NoObjectExistsTest extends BaseTestCase
18			{
19			public function testCanValidateWithNoAvailableObjectInRepository() : void
20			{
21			$repository = $this->createMock('Doctrine\Persistence\ObjectRepository');
			0 ignored issues – show Bug introduced 2020-03-24 20:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$repository` is correct as `$this->createMock('Doctr...nce\\ObjectRepository')` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
22
23			$repository
24			->expects($this->once())
25			->method('findOneBy')
26			->will($this->returnValue(null));
27
28			$validator = new NoObjectExists(['object_repository' => $repository, 'fields' => 'matchKey']);
29
30			$this->assertTrue($validator->isValid('matchValue'));
31			}
32
33			public function testCannotValidateWithAvailableObjectInRepository() : void
34			{
35			$repository = $this->createMock('Doctrine\Persistence\ObjectRepository');
			0 ignored issues – show Bug introduced 2020-03-24 20:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$repository` is correct as `$this->createMock('Doctr...nce\\ObjectRepository')` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
36
37			$repository
38			->expects($this->once())
39			->method('findOneBy')
40			->will($this->returnValue(new stdClass()));
41
42			$validator = new NoObjectExists(['object_repository' => $repository, 'fields' => 'matchKey']);
43
44			$this->assertFalse($validator->isValid('matchValue'));
45			}
46
47			public function testErrorMessageIsStringInsteadArray() : void
48			{
49			$repository = $this->createMock('Doctrine\Persistence\ObjectRepository');
			0 ignored issues – show Bug introduced 2020-03-24 20:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$repository` is correct as `$this->createMock('Doctr...nce\\ObjectRepository')` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
50			$repository
51			->expects($this->once())
52			->method('findOneBy')
53			->will($this->returnValue(new stdClass()));
54			$validator = new NoObjectExists(['object_repository' => $repository, 'fields' => 'matchKey']);
55
56			$this->assertFalse($validator->isValid('matchValue'));
57
58			$messageTemplates = $validator->getMessageTemplates();
59
60			$expectedMessage = str_replace(
61			'%value%',
62			'matchValue',
63			$messageTemplates[NoObjectExists::ERROR_OBJECT_FOUND]
64			);
65			$messages = $validator->getMessages();
66			$receivedMessage = $messages[NoObjectExists::ERROR_OBJECT_FOUND];
67
68			$this->assertSame($expectedMessage, $receivedMessage);
69			}
70			}
71

doctrine / DoctrineModule

Push — master ( e0017c...6b1304 )

Validator/NoObjectExistsTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like