Issues in SelectableAdapterTest.php - New Issues - Inspection of "Merge pull request #697 from doctrine/develop" - doctrine/DoctrineModule - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e0017c...6b1304 )

by Tom

created 2020-04-09 05:25 UTC

Paginator/Adapter/SelectableAdapterTest.php (42 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace DoctrineModuleTest\Paginator\Adapter;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Criteria;
use DoctrineModule\Paginator\Adapter\Selectable as SelectableAdapter;
use PHPUnit\Framework\TestCase;
use function range;

/**
 * Tests for the Selectable pagination adapter
 *
 * @link    http://www.doctrine-project.org/
 */
class SelectableAdapterTest extends TestCase
{
    /**
     * @covers \DoctrineModule\Paginator\Adapter\Selectable::getItems
     */
    public function testGetItemsAtOffsetZeroWithEmptyCriteria() : void
    {
        $selectable = $this->createMock('Doctrine\Common\Collections\Selectable');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $adapter    = new SelectableAdapter($selectable);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $me = $this;

        $selectable

            ->expects($this->once())

            ->method('matching')
            ->with(
                $this->callback(

                    static function (Criteria $criteria) use ($me) {
                        $me->assertEquals(0, $criteria->getFirstResult());
                        $me->assertEquals(10, $criteria->getMaxResults());


                        return true;
                    }
                )
            )
            ->will($this->returnValue(new ArrayCollection(range(1, 10))));


        $expected = range(1, 10);
        $actual   = $adapter->getItems(0, 10);

        $this->assertEquals($expected, $actual);

    }

    /**
     * @covers \DoctrineModule\Paginator\Adapter\Selectable::getItems
     */
    public function testGetItemsAtOffsetZeroWithNonEmptyCriteria() : void
    {
        $selectable = $this->createMock('Doctrine\Common\Collections\Selectable');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $criteria   = new Criteria(Criteria::expr()->eq('foo', 'bar'));
        $adapter    = new SelectableAdapter($selectable, $criteria);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $me = $this;

        $selectable->expects($this->once())

            ->method('matching')
            ->with(
                $this->callback(

                    static function (Criteria $innerCriteria) use ($criteria, $me) {
                        // Criteria are cloned internally
                        $me->assertNotEquals($innerCriteria, $criteria);

                        $me->assertEquals(0, $innerCriteria->getFirstResult());
                        $me->assertEquals(10, $innerCriteria->getMaxResults());

                        $me->assertEquals($innerCriteria->getWhereExpression(), $criteria->getWhereExpression());


                        return true;
                    }
                )
            )
            ->will($this->returnValue(new ArrayCollection(range(1, 10))));


        $expected = range(1, 10);
        $actual   = $adapter->getItems(0, 10);

        $this->assertEquals($expected, $actual);

    }

    /**
     * @covers \DoctrineModule\Paginator\Adapter\Selectable::getItems
     */
    public function testGetItemsAtOffsetTenWithEmptyCriteria() : void
    {
        $selectable = $this->createMock('Doctrine\Common\Collections\Selectable');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $adapter    = new SelectableAdapter($selectable);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $me = $this;

        $selectable->expects($this->once())

            ->method('matching')
            ->with(
                $this->callback(

                    static function (Criteria $criteria) use ($me) {
                        $me->assertEquals(10, $criteria->getFirstResult());
                        $me->assertEquals(10, $criteria->getMaxResults());


                        return true;
                    }
                )
            )
            ->will($this->returnValue(new ArrayCollection(range(11, 20))));


        $expected = range(11, 20);
        $actual   = $adapter->getItems(10, 10);

        $this->assertEquals($expected, $actual);

    }

    /**
     * @covers \DoctrineModule\Paginator\Adapter\Selectable::getItems
     */
    public function testGetItemsAtOffsetTenWithNonEmptyCriteria() : void
    {
        $selectable = $this->createMock('Doctrine\Common\Collections\Selectable');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $criteria   = new Criteria(Criteria::expr()->eq('foo', 'bar'));
        $adapter    = new SelectableAdapter($selectable, $criteria);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $me = $this;

        $selectable->expects($this->once())

            ->method('matching')
            ->with(
                $this->callback(

                    static function (Criteria $innerCriteria) use ($criteria, $me) {
                        // Criteria are cloned internally
                        $me->assertNotEquals($innerCriteria, $criteria);

                        $me->assertEquals(10, $innerCriteria->getFirstResult());
                        $me->assertEquals(10, $innerCriteria->getMaxResults());

                        $me->assertEquals($innerCriteria->getWhereExpression(), $criteria->getWhereExpression());


                        return true;
                    }
                )
            )
            ->will($this->returnValue(new ArrayCollection(range(11, 20))));


        $expected = range(11, 20);
        $actual   = $adapter->getItems(10, 10);

        $this->assertEquals($expected, $actual);

    }

    /**
     * @covers \DoctrineModule\Paginator\Adapter\Selectable::count
     */
    public function testReturnsCorrectCount() : void
    {
        $selectable = $this->createMock('Doctrine\Common\Collections\Selectable');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $expression = Criteria::expr()->eq('foo', 'bar');
        $criteria   = new Criteria($expression, ['baz' => Criteria::DESC], 10, 20);
        $adapter    = new SelectableAdapter($selectable, $criteria);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $selectable->expects($this->once())

            ->method('matching')
            ->with(
                $this->callback(

                    static function (Criteria $criteria) use ($expression) {
                        return $criteria->getWhereExpression() === $expression
                            && ($criteria->getOrderings() === ['baz' => Criteria::DESC])
                            && $criteria->getFirstResult() === null
                            && $criteria->getMaxResults() === null;
                    }
                )
            )
            ->will($this->returnValue(new ArrayCollection(range(1, 101))));


        $this->assertEquals(101, $adapter->count());

        $this->assertSame(10, $criteria->getFirstResult(), 'Original criteria was not modified');
        $this->assertSame(20, $criteria->getMaxResults(), 'Original criteria was not modified');
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace DoctrineModuleTest\Paginator\Adapter;
6
7			use Doctrine\Common\Collections\ArrayCollection;
8			use Doctrine\Common\Collections\Criteria;
9			use DoctrineModule\Paginator\Adapter\Selectable as SelectableAdapter;
10			use PHPUnit\Framework\TestCase;
11			use function range;
12
13			/**
14			* Tests for the Selectable pagination adapter
15			*
16			* @link http://www.doctrine-project.org/
17			*/
18			class SelectableAdapterTest extends TestCase
19			{
20			/**
21			* @covers \DoctrineModule\Paginator\Adapter\Selectable::getItems
22			*/
23			public function testGetItemsAtOffsetZeroWithEmptyCriteria() : void
24			{
25			$selectable = $this->createMock('Doctrine\Common\Collections\Selectable');
			0 ignored issues – show Bug introduced 2020-03-25 06:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$selectable` is correct as `$this->createMock('Doctr...llections\\Selectable')` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
26			$adapter = new SelectableAdapter($selectable);
			0 ignored issues – show Documentation introduced 2020-03-25 06:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$selectable` is of type `null`, but the function expects a `object<Doctrine\Common\Collections\Selectable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27
28			$me = $this;
29
30			$selectable
			0 ignored issues – show Bug introduced 2020-03-25 06:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expects` cannot be called on `$selectable` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
31			->expects($this->once())
			0 ignored issues – show Bug introduced 2020-03-25 06:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `once()` does not seem to exist on `object<DoctrineModuleTes...\SelectableAdapterTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
32			->method('matching')
33			->with(
34			$this->callback(
			0 ignored issues – show Bug introduced 2020-03-25 06:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `callback()` does not seem to exist on `object<DoctrineModuleTes...\SelectableAdapterTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
35			static function (Criteria $criteria) use ($me) {

doctrine / DoctrineModule

Push — master ( e0017c...6b1304 )

Paginator/Adapter/SelectableAdapterTest.php (42 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like