Issues in ObjectRepositoryTest.php - New Issues - Inspection of "Merge pull request #697 from doctrine/develop" - doctrine/DoctrineModule - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e0017c...6b1304 )

by Tom

created 2020-04-09 05:25 UTC

Authentication/Storage/ObjectRepositoryTest.php (2 issues)

Labels

Bug 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace DoctrineModuleTest\Authentication\Storage;

use DoctrineModule\Authentication\Storage\ObjectRepository as ObjectRepositoryStorage;
use DoctrineModuleTest\Authentication\Adapter\TestAsset\IdentityObject;
use Laminas\Authentication\Storage\NonPersistent as NonPersistentStorage;
use PHPUnit\Framework\TestCase as BaseTestCase;

/**
 * Tests for the ObjectRepository based authentication adapter
 *
 * @link    http://www.doctrine-project.org/
 */
class ObjectRepositoryTest extends BaseTestCase
{
    public function testCanRetrieveEntityFromObjectRepositoryStorage() : void
    {
        // Identifier is considered to be username here
        $entity = new IdentityObject();
        $entity->setUsername('a username');
        $entity->setPassword('a password');

        $objectRepository = $this->createMock('Doctrine\Persistence\ObjectRepository');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $objectRepository->expects($this->exactly(1))
                         ->method('find')
                         ->with($this->equalTo('a username'))
                         ->will($this->returnValue($entity));

        $metadata = $this->createMock('Doctrine\Persistence\Mapping\ClassMetadata');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $metadata->expects($this->exactly(1))
                 ->method('getIdentifierValues')
                 ->with($this->equalTo($entity))
                 ->will($this->returnValue($entity->getUsername()));

        $storage = new ObjectRepositoryStorage([
            'objectRepository' => $objectRepository,
            'classMetadata' => $metadata,
            'storage' => new NonPersistentStorage(),
        ]);

        $storage->write($entity);
        $this->assertFalse($storage->isEmpty());

        $result = $storage->read();
        $this->assertEquals($entity, $result);

        $key = $storage->readKeyOnly();
        $this->assertEquals('a username', $key);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace DoctrineModuleTest\Authentication\Storage;
6
7			use DoctrineModule\Authentication\Storage\ObjectRepository as ObjectRepositoryStorage;
8			use DoctrineModuleTest\Authentication\Adapter\TestAsset\IdentityObject;
9			use Laminas\Authentication\Storage\NonPersistent as NonPersistentStorage;
10			use PHPUnit\Framework\TestCase as BaseTestCase;
11
12			/**
13			* Tests for the ObjectRepository based authentication adapter
14			*
15			* @link http://www.doctrine-project.org/
16			*/
17			class ObjectRepositoryTest extends BaseTestCase
18			{
19			public function testCanRetrieveEntityFromObjectRepositoryStorage() : void
20			{
21			// Identifier is considered to be username here
22			$entity = new IdentityObject();
23			$entity->setUsername('a username');
24			$entity->setPassword('a password');
25
26			$objectRepository = $this->createMock('Doctrine\Persistence\ObjectRepository');
			0 ignored issues – show Bug introduced 2020-04-07 22:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$objectRepository` is correct as `$this->createMock('Doctr...nce\\ObjectRepository')` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
27			$objectRepository->expects($this->exactly(1))
28			->method('find')
29			->with($this->equalTo('a username'))
30			->will($this->returnValue($entity));
31
32			$metadata = $this->createMock('Doctrine\Persistence\Mapping\ClassMetadata');
			0 ignored issues – show Bug introduced 2020-04-07 22:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$metadata` is correct as `$this->createMock('Doctr...apping\\ClassMetadata')` (which targets `PHPUnit\Framework\TestCase::createMock()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
33			$metadata->expects($this->exactly(1))
34			->method('getIdentifierValues')
35			->with($this->equalTo($entity))
36			->will($this->returnValue($entity->getUsername()));
37
38			$storage = new ObjectRepositoryStorage([
39			'objectRepository' => $objectRepository,
40			'classMetadata' => $metadata,
41			'storage' => new NonPersistentStorage(),
42			]);
43
44			$storage->write($entity);
45			$this->assertFalse($storage->isEmpty());
46
47			$result = $storage->read();
48			$this->assertEquals($entity, $result);
49
50			$key = $storage->readKeyOnly();
51			$this->assertEquals('a username', $key);
52			}
53			}
54

doctrine / DoctrineModule

Push — master ( e0017c...6b1304 )

Authentication/Storage/ObjectRepositoryTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like