Issues in ObjectRepositoryTest.php - New Issues - Inspection of "Merge pull request #697 from doctrine/develop" - doctrine/DoctrineModule - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e0017c...6b1304 )

by Tom

created 2020-04-09 05:25 UTC

Authentication/Adapter/ObjectRepositoryTest.php (52 issues)

Labels

Bug 52

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace DoctrineModuleTest\Authentication\Adapter;

use DoctrineModule\Authentication\Adapter\ObjectRepository as ObjectRepositoryAdapter;
use DoctrineModuleTest\Authentication\Adapter\TestAsset\IdentityObject;
use DoctrineModuleTest\Authentication\Adapter\TestAsset\PublicPropertiesIdentityObject;
use PHPUnit\Framework\TestCase as BaseTestCase;
use stdClass;
use function crypt;

/**
 * Tests for the ObjectRepository based authentication adapter
 *
 * @link    http://www.doctrine-project.org/
 */
class ObjectRepositoryTest extends BaseTestCase
{
    public function testWillRejectInvalidIdentityProperty() : void
    {
        $this->expectException(

            'Laminas\Authentication\Adapter\Exception\InvalidArgumentException'
        );
        $this->expectExceptionMessage(

            'Provided $identityProperty is invalid, string given'
        );

        new ObjectRepositoryAdapter(['identity_property' => false]);
    }

    public function testWillRejectInvalidCredentialProperty() : void
    {
        $this->expectException(

            'Laminas\Authentication\Adapter\Exception\InvalidArgumentException'
        );
        $this->expectExceptionMessage(

            'Provided $credentialProperty is invalid, string given'
        );
        new ObjectRepositoryAdapter(['credential_property' => false]);
    }

    public function testWillRequireIdentityValue() : void
    {
        $this->expectException(

            'Laminas\Authentication\Adapter\Exception\RuntimeException'
        );
        $this->expectExceptionMessage(

            'A value for the identity was not provided prior to authentication with ObjectRepository authentication '
            . 'adapter'
        );
        $adapter = new ObjectRepositoryAdapter();
        $adapter->setOptions([
            'object_manager' => $this->createMock('Doctrine\Persistence\ObjectManager'),
            'identity_class' => 'DoctrineModuleTest\Authentication\Adapter\TestAsset\IdentityObject',
        ]);
        $adapter->setCredential('a credential');
        $adapter->authenticate();
    }

    public function testWillRequireCredentialValue() : void
    {
        $this->expectException(

            'Laminas\Authentication\Adapter\Exception\RuntimeException'
        );
        $this->expectExceptionMessage(

            'A credential value was not provided prior to authentication with ObjectRepository authentication adapter'
        );
        $adapter = new ObjectRepositoryAdapter();
        $adapter->setOptions([
            'object_manager' => $this->createMock('Doctrine\Persistence\ObjectManager'),
            'identity_class' => 'DoctrineModuleTest\Authentication\Adapter\TestAsset\IdentityObject',
        ]);

        $adapter->setIdentity('an identity');
        $adapter->authenticate();
    }

    public function testWillRejectInvalidCredentialCallable() : void
    {
        $this->expectException(

            'Laminas\Authentication\Adapter\Exception\InvalidArgumentException'
        );
        $this->expectExceptionMessage(

            '"array" is not a callable'
        );
        $adapter = new ObjectRepositoryAdapter();
        $adapter->setOptions([
            'object_manager'      => $this->createMock('Doctrine\Persistence\ObjectManager'),
            'identity_class'      => 'DoctrineModuleTest\Authentication\Adapter\TestAsset\IdentityObject',
            'credential_callable' => [],
        ]);

        $adapter->authenticate();
    }

    public function testAuthentication() : void
    {
        $entity = new IdentityObject();
        $entity->setUsername('a username');
        $entity->setPassword('a password');

        $objectRepository = $this->createMock('Doctrine\Persistence\ObjectRepository');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $method           = $objectRepository

            ->expects($this->exactly(2))

            ->method('findOneBy')
            ->with($this->equalTo(['username' => 'a username']))

            ->will($this->returnValue($entity));


        $objectManager = $this->createMock('Doctrine\Persistence\ObjectManager');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $objectManager->expects($this->exactly(2))
                      ->method('getRepository')
                      ->with($this->equalTo('DoctrineModuleTest\Authentication\Adapter\TestAsset\IdentityObject'))
                      ->will($this->returnValue($objectRepository));

        $adapter = new ObjectRepositoryAdapter();
        $adapter->setOptions([
            'object_manager'      => $objectManager,
            'identity_class'      => 'DoctrineModuleTest\Authentication\Adapter\TestAsset\IdentityObject',
            'credential_property' => 'password',
            'identity_property'   => 'username',
        ]);

        $adapter->setIdentity('a username');
        $adapter->setCredential('a password');

        $result = $adapter->authenticate();

        $this->assertTrue($result->isValid());

        $this->assertInstanceOf(

            'DoctrineModuleTest\Authentication\Adapter\TestAsset\IdentityObject',
            $result->getIdentity()
        );

        $method->will($this->returnValue(null));


        $result = $adapter->authenticate();

        $this->assertFalse($result->isValid());

    }

    public function testAuthenticationWithPublicProperties() : void
    {
        $entity           = new PublicPropertiesIdentityObject();
        $entity->username = 'a username';
        $entity->password = 'a password';

        $objectRepository = $this->createMock('Doctrine\Persistence\ObjectRepository');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $method           = $objectRepository

            ->expects($this->exactly(2))

            ->method('findOneBy')
            ->with($this->equalTo(['username' => 'a username']))

            ->will($this->returnValue($entity));


        $adapter = new ObjectRepositoryAdapter();
        $adapter->setOptions([
            'object_repository' => $objectRepository,
            'credential_property' => 'password',
            'identity_property' => 'username',
        ]);

        $adapter->setIdentity('a username');
        $adapter->setCredential('a password');

        $result = $adapter->authenticate();

        $this->assertTrue($result->isValid());


        $method->will($this->returnValue(null));


        $result = $adapter->authenticate();

        $this->assertFalse($result->isValid());

    }

    public function testWillRefuseToAuthenticateWithoutGettersOrPublicMethods() : void
    {
        $this->expectException('Laminas\Authentication\Adapter\Exception\UnexpectedValueException');


        $objectRepository = $this->createMock('Doctrine\Persistence\ObjectRepository');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $objectRepository

            ->expects($this->once())

            ->method('findOneBy')
            ->with($this->equalTo(['username' => 'a username']))

            ->will($this->returnValue(new stdClass()));


        $adapter = new ObjectRepositoryAdapter();
        $adapter->setOptions([
            'object_repository' => $objectRepository,
            'credential_property' => 'password',
            'identity_property' => 'username',
        ]);

        $adapter->setIdentity('a username');
        $adapter->setCredential('a password');
        $adapter->authenticate();
    }

    public function testCanValidateWithSpecialCrypt() : void
    {
        $hash   = '$2y$07$usesomesillystringforsalt$';
        $entity = new IdentityObject();
        $entity->setUsername('username');
        // Crypt password using Blowfish
        $entity->setPassword(crypt('password', $hash));

        $objectRepository = $this->createMock('Doctrine\Persistence\ObjectRepository');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $objectRepository

            ->expects($this->exactly(2))

            ->method('findOneBy')
            ->with($this->equalTo(['username' => 'username']))

            ->will($this->returnValue($entity));


        $adapter = new ObjectRepositoryAdapter();
        $adapter->setOptions([
            'object_repository' => $objectRepository,
            'credential_property' => 'password',
            'identity_property' => 'username',
            // enforced type hinting to verify that closure is invoked correctly
            'credential_callable' => static function (IdentityObject $identity, $credentialValue) use ($hash) {
                return $identity->getPassword() === crypt($credentialValue, $hash);
            },
        ]);

        $adapter->setIdentity('username');
        $adapter->setCredential('password');

        $result = $adapter->authenticate();

        $this->assertTrue($result->isValid());


        $adapter->setCredential('wrong password');
        $result = $adapter->authenticate();

        $this->assertFalse($result->isValid());

    }

    public function testWillRefuseToAuthenticateWhenInvalidInstanceIsFound() : void
    {
        $this->expectException('Laminas\Authentication\Adapter\Exception\UnexpectedValueException');


        $objectRepository = $this->createMock('Doctrine\Persistence\ObjectRepository');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $objectRepository

            ->expects($this->once())

            ->method('findOneBy')
            ->with($this->equalTo(['username' => 'a username']))

            ->will($this->returnValue(new stdClass()));


        $adapter = new ObjectRepositoryAdapter();
        $adapter->setOptions([
            'object_repository'   => $objectRepository,
            'credential_property' => 'password',
            'identity_property'   => 'username',
        ]);

        $adapter->setIdentity('a username');
        $adapter->setCredential('a password');

        $adapter->authenticate();
    }

    public function testWillNotCastAuthCredentialValue() : void
    {
        $objectRepository = $this->createMock('Doctrine\Persistence\ObjectRepository');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        $adapter          = new ObjectRepositoryAdapter();
        $entity           = new IdentityObject();

        $entity->setPassword(0);
        $adapter->setOptions([
            'object_repository'   => $objectRepository,
            'credential_property' => 'password',
            'identity_property'   => 'username',
        ]);
        $adapter->setIdentity('a username');
        $adapter->setCredential('00000');
        $objectRepository

            ->expects($this->once())

            ->method('findOneBy')
            ->with($this->equalTo(['username' => 'a username']))

            ->will($this->returnValue($entity));


        $this->assertFalse($adapter->authenticate()->isValid());
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace DoctrineModuleTest\Authentication\Adapter;
6
7			use DoctrineModule\Authentication\Adapter\ObjectRepository as ObjectRepositoryAdapter;
8			use DoctrineModuleTest\Authentication\Adapter\TestAsset\IdentityObject;
9			use DoctrineModuleTest\Authentication\Adapter\TestAsset\PublicPropertiesIdentityObject;
10			use PHPUnit\Framework\TestCase as BaseTestCase;
11			use stdClass;
12			use function crypt;
13
14			/**
15			* Tests for the ObjectRepository based authentication adapter
16			*
17			* @link http://www.doctrine-project.org/
18			*/
19			class ObjectRepositoryTest extends BaseTestCase
20			{
21			public function testWillRejectInvalidIdentityProperty() : void
22			{
23			$this->expectException(
			0 ignored issues – show Bug introduced 2020-03-25 06:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expectException()` does not seem to exist on `object<DoctrineModuleTes...r\ObjectRepositoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
24			'Laminas\Authentication\Adapter\Exception\InvalidArgumentException'
25			);
26			$this->expectExceptionMessage(
			0 ignored issues – show Bug introduced 2020-03-25 06:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expectExceptionMessage()` does not seem to exist on `object<DoctrineModuleTes...r\ObjectRepositoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
27			'Provided $identityProperty is invalid, string given'
28			);
29
30			new ObjectRepositoryAdapter(['identity_property' => false]);
31			}
32
33			public function testWillRejectInvalidCredentialProperty() : void
34			{
35			$this->expectException(
			0 ignored issues – show Bug introduced 2020-03-25 06:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `expectException()` does not seem to exist on `object<DoctrineModuleTes...r\ObjectRepositoryTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
36			'Laminas\Authentication\Adapter\Exception\InvalidArgumentException'
37			);

doctrine / DoctrineModule

Push — master ( e0017c...6b1304 )

Authentication/Adapter/ObjectRepositoryTest.php (52 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like