AdapterFactory::__invoke() - Code Metrics - Inspection of "Merge pull request #684 from TomHAnderson/hotfix/r..." - doctrine/DoctrineModule - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( f3c8ea...81dc89 )

by Tom

created 2020-02-17 19:22 UTC

AdapterFactory::__invoke() A

↳ Parent: AdapterFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0185

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	5
cts	6
cp	0.8333
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	3
crap	2.0185

<?php

declare(strict_types=1);

namespace DoctrineModule\Service\Authentication;

use DoctrineModule\Authentication\Adapter\ObjectRepository;
use DoctrineModule\Options\Authentication;
use DoctrineModule\Service\AbstractFactory;
use Interop\Container\ContainerInterface;
use Laminas\ServiceManager\ServiceLocatorInterface;
use function is_string;

/**
 * Factory to create authentication adapter object.
 *
 * @link    http://www.doctrine-project.org/
 */
class AdapterFactory extends AbstractFactory
{
    /**
     * {@inheritDoc}
     */
    public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null)
    {
        $options = $this->getOptions($container, 'authentication');

        $objectManager = $options->getObjectManager();
        if (is_string($objectManager)) {
            $options->setObjectManager($container->get($objectManager));
        }

        return new ObjectRepository($options);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * {@inheritDoc}
     *
     * @return ObjectRepository
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        return $this($serviceLocator, ObjectRepository::class);
    }

    public function getOptionsClass() : string
    {
        return 'DoctrineModule\Options\Authentication';
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace DoctrineModule\Service\Authentication;
6
7		use DoctrineModule\Authentication\Adapter\ObjectRepository;
8		use DoctrineModule\Options\Authentication;
9		use DoctrineModule\Service\AbstractFactory;
10		use Interop\Container\ContainerInterface;
11		use Laminas\ServiceManager\ServiceLocatorInterface;
12		use function is_string;
13
14		/**
15		* Factory to create authentication adapter object.
16		*
17		* @link http://www.doctrine-project.org/
18		*/
19		class AdapterFactory extends AbstractFactory
20		{
21		/**
22		* {@inheritDoc}
23		*/
24	2	public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null)
25		{
26	2	$options = $this->getOptions($container, 'authentication');
27
28	2	$objectManager = $options->getObjectManager();
29	2	if (is_string($objectManager)) {
30		$options->setObjectManager($container->get($objectManager));
31		}
32
33	2	return new ObjectRepository($options);
		0 ignored issues – show Documentation introduced 2020-02-17 19:20 UTC by Report Bug Copy Issue Report `$options` is of type `object<Laminas\Stdlib\AbstractOptions>`, but the function expects a `array<integer,*>\|object<...Options\Authentication>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34		}
35
36		/**
37		* {@inheritDoc}
38		*
39		* @return ObjectRepository
40		*/
41	1	public function createService(ServiceLocatorInterface $serviceLocator)
42		{
43	1	return $this($serviceLocator, ObjectRepository::class);
44		}
45
46	2	public function getOptionsClass() : string
47		{
48	2	return 'DoctrineModule\Options\Authentication';
49		}
50		}
51

doctrine / DoctrineModule

Push — develop ( f3c8ea...81dc89 )

AdapterFactory::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like