NoObjectExistsFactory - Code Metrics - doctrine/DoctrineModule - Measure and Improve Code Quality continuously with Scrutinizer

NoObjectExistsFactory A
last analyzed 2020-06-16 07:36 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	2
dl	0
loc	20
ccs	6
cts	6
cp	1
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	11	1

<?php

declare(strict_types=1);

namespace DoctrineModule\Validator\Service;

use DoctrineModule\Validator\NoObjectExists;
use Interop\Container\ContainerInterface;

/**
 * Factory for creating NoObjectExists instances
 *
 * @link    http://www.doctrine-project.org/
 */
class NoObjectExistsFactory extends AbstractValidatorFactory
{
    /** @var string */
    protected $validatorClass = NoObjectExists::class;

    /**
     * {@inheritDoc}
     */
    public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null)
    {
        $container = $this->container($container);

        $repository = $this->getRepository($container, $options);


        return new NoObjectExists($this->merge($options, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            'object_repository' => $repository,
            'fields'            => $this->getFields($options),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ]));
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace DoctrineModule\Validator\Service;
6
7		use DoctrineModule\Validator\NoObjectExists;
8		use Interop\Container\ContainerInterface;
9
10		/**
11		* Factory for creating NoObjectExists instances
12		*
13		* @link http://www.doctrine-project.org/
14		*/
15		class NoObjectExistsFactory extends AbstractValidatorFactory
16		{
17		/** @var string */
18		protected $validatorClass = NoObjectExists::class;
19
20		/**
21		* {@inheritDoc}
22		*/
23	2	public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null)
24		{
25	2	$container = $this->container($container);
26
27	2	$repository = $this->getRepository($container, $options);
		0 ignored issues – show Bug introduced 2020-02-16 06:59 UTC by Report Bug Copy Issue Report It seems like `$options` defined by parameter `$options` on line 23 can also be of type `array`; however, `DoctrineModule\Validator...actory::getRepository()` does only seem to accept `array<integer,*>\|null`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
28
29	2	return new NoObjectExists($this->merge($options, [
		0 ignored issues – show Documentation introduced 2020-02-16 06:59 UTC by Report Bug Copy Issue Report `$options` is of type `null\|array`, but the function expects a `array<integer,*>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30	2	'object_repository' => $repository,
31	2	'fields' => $this->getFields($options),
		0 ignored issues – show Documentation introduced 2020-02-16 06:59 UTC by Report Bug Copy Issue Report `$options` is of type `null\|array`, but the function expects a `array<integer,*>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32		]));
33		}
34		}
35

doctrine / DoctrineModule

NoObjectExistsFactory A last analyzed 2020-06-16 07:36 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like

NoObjectExistsFactory A
last analyzed 2020-06-16 07:36 UTC