Issues in ProfilerController.php (master) - Issues in master - doctrine/DoctrineBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (220)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Controller/ProfilerController.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Doctrine\Bundle\DoctrineBundle\Controller;

use Doctrine\DBAL\Connection;
use Doctrine\DBAL\Platforms\SqlitePlatform;
use Doctrine\DBAL\Platforms\SQLServerPlatform;
use Exception;
use PDO;
use Symfony\Component\DependencyInjection\ContainerAwareInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Profiler\Profiler;
use Symfony\Component\VarDumper\Cloner\Data;

class ProfilerController implements ContainerAwareInterface
{
    /** @var ContainerInterface */
    private $container;

    /**
     * {@inheritDoc}
     */
    public function setContainer(ContainerInterface $container = null)
    {
        $this->container = $container;
    }

    /**
     * Renders the profiler panel for the given token.
     *
     * @param string $token          The profiler token
     * @param string $connectionName
     * @param int    $query
     *
     * @return Response A Response instance
     */
    public function explainAction($token, $connectionName, $query)
    {
        /** @var Profiler $profiler */
        $profiler = $this->container->get('profiler');
        $profiler->disable();

        $profile = $profiler->loadProfile($token);
        $queries = $profile->getCollector('db')->getQueries();

        if (! isset($queries[$connectionName][$query])) {
            return new Response('This query does not exist.');
        }

        $query = $queries[$connectionName][$query];
        if (! $query['explainable']) {
            return new Response('This query cannot be explained.');
        }

        /** @var Connection $connection */
        $connection = $this->container->get('doctrine')->getConnection($connectionName);
        try {
            $platform = $connection->getDatabasePlatform();
            if ($platform instanceof SqlitePlatform) {
                $results = $this->explainSQLitePlatform($connection, $query);
            } elseif ($platform instanceof SQLServerPlatform) {
                $results = $this->explainSQLServerPlatform($connection, $query);
            } else {
                $results = $this->explainOtherPlatform($connection, $query);
            }
        } catch (Exception $e) {
            return new Response('This query cannot be explained.');
        }

        return new Response($this->container->get('twig')->render('@Doctrine/Collector/explain.html.twig', [
            'data' => $results,
            'query' => $query,
        ]));
    }

    /**
     * @param mixed[] $query
     */
    private function explainSQLitePlatform(Connection $connection, array $query)
    {
        $params = $query['params'];

        if ($params instanceof Data) {
            $params = $params->getValue(true);
        }

        return $connection->executeQuery('EXPLAIN QUERY PLAN ' . $query['sql'], $params, $query['types'])

            ->fetchAll(PDO::FETCH_ASSOC);
    }

    private function explainSQLServerPlatform(Connection $connection, $query)
    {
        if (stripos($query['sql'], 'SELECT') === 0) {
            $sql = 'SET STATISTICS PROFILE ON; ' . $query['sql'] . '; SET STATISTICS PROFILE OFF;';
        } else {
            $sql = 'SET SHOWPLAN_TEXT ON; GO; SET NOEXEC ON; ' . $query['sql'] . '; SET NOEXEC OFF; GO; SET SHOWPLAN_TEXT OFF;';
        }

        $params = $query['params'];

        if ($params instanceof Data) {
            $params = $params->getValue(true);
        }

        $stmt = $connection->executeQuery($sql, $params, $query['types']);
        $stmt->nextRowset();

        return $stmt->fetchAll(PDO::FETCH_ASSOC);

    }

    private function explainOtherPlatform(Connection $connection, $query)
    {
        $params = $query['params'];

        if ($params instanceof Data) {
            $params = $params->getValue(true);
        }

        return $connection->executeQuery('EXPLAIN ' . $query['sql'], $params, $query['types'])

            ->fetchAll(PDO::FETCH_ASSOC);
    }
}


1		<?php
2
3		namespace Doctrine\Bundle\DoctrineBundle\Controller;
4
5		use Doctrine\DBAL\Connection;
6		use Doctrine\DBAL\Platforms\SqlitePlatform;
7		use Doctrine\DBAL\Platforms\SQLServerPlatform;
8		use Exception;
9		use PDO;
10		use Symfony\Component\DependencyInjection\ContainerAwareInterface;
11		use Symfony\Component\DependencyInjection\ContainerInterface;
12		use Symfony\Component\HttpFoundation\Response;
13		use Symfony\Component\HttpKernel\Profiler\Profiler;
14		use Symfony\Component\VarDumper\Cloner\Data;
15
16		class ProfilerController implements ContainerAwareInterface
17		{
18		/** @var ContainerInterface */
19		private $container;
20
21		/**
22		* {@inheritDoc}
23		*/
24		public function setContainer(ContainerInterface $container = null)
25		{
26		$this->container = $container;
27		}
28
29		/**
30		* Renders the profiler panel for the given token.
31		*
32		* @param string $token The profiler token
33		* @param string $connectionName
34		* @param int $query
35		*
36		* @return Response A Response instance
37		*/
38		public function explainAction($token, $connectionName, $query)
39		{
40		/** @var Profiler $profiler */
41		$profiler = $this->container->get('profiler');
42		$profiler->disable();
43
44		$profile = $profiler->loadProfile($token);
45		$queries = $profile->getCollector('db')->getQueries();
46
47		if (! isset($queries[$connectionName][$query])) {
48		return new Response('This query does not exist.');
49		}
50
51		$query = $queries[$connectionName][$query];
52		if (! $query['explainable']) {
53		return new Response('This query cannot be explained.');
54		}
55
56		/** @var Connection $connection */
57		$connection = $this->container->get('doctrine')->getConnection($connectionName);
58		try {
59		$platform = $connection->getDatabasePlatform();
60		if ($platform instanceof SqlitePlatform) {
61		$results = $this->explainSQLitePlatform($connection, $query);
62		} elseif ($platform instanceof SQLServerPlatform) {
63		$results = $this->explainSQLServerPlatform($connection, $query);
64		} else {
65		$results = $this->explainOtherPlatform($connection, $query);
66		}
67		} catch (Exception $e) {
68		return new Response('This query cannot be explained.');
69		}
70
71		return new Response($this->container->get('twig')->render('@Doctrine/Collector/explain.html.twig', [
72		'data' => $results,
73		'query' => $query,
74		]));
75		}
76
77		/**
78		* @param mixed[] $query
79		*/
80	View Code Duplication	private function explainSQLitePlatform(Connection $connection, array $query)
81		{
82		$params = $query['params'];
83
84		if ($params instanceof Data) {
85		$params = $params->getValue(true);
86		}
87
88		return $connection->executeQuery('EXPLAIN QUERY PLAN ' . $query['sql'], $params, $query['types'])
		0 ignored issues – show Deprecated Code introduced 2020-06-28 14:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Doctrine\DBAL\Driver\ResultStatement::fetchAll()` has been deprecated with message: Use fetchAllNumeric(), fetchAllAssociative() or fetchFirstColumn() instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
89		->fetchAll(PDO::FETCH_ASSOC);
90		}
91
92		private function explainSQLServerPlatform(Connection $connection, $query)
93		{
94		if (stripos($query['sql'], 'SELECT') === 0) {
95		$sql = 'SET STATISTICS PROFILE ON; ' . $query['sql'] . '; SET STATISTICS PROFILE OFF;';
96		} else {
97		$sql = 'SET SHOWPLAN_TEXT ON; GO; SET NOEXEC ON; ' . $query['sql'] . '; SET NOEXEC OFF; GO; SET SHOWPLAN_TEXT OFF;';
98		}
99
100		$params = $query['params'];
101
102		if ($params instanceof Data) {
103		$params = $params->getValue(true);
104		}
105
106		$stmt = $connection->executeQuery($sql, $params, $query['types']);
107		$stmt->nextRowset();
108
109		return $stmt->fetchAll(PDO::FETCH_ASSOC);
		0 ignored issues – show Deprecated Code introduced 2020-06-28 14:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Doctrine\DBAL\Driver\ResultStatement::fetchAll()` has been deprecated with message: Use fetchAllNumeric(), fetchAllAssociative() or fetchFirstColumn() instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
110		}
111
112	View Code Duplication	private function explainOtherPlatform(Connection $connection, $query)
113		{
114		$params = $query['params'];
115
116		if ($params instanceof Data) {
117		$params = $params->getValue(true);
118		}
119
120		return $connection->executeQuery('EXPLAIN ' . $query['sql'], $params, $query['types'])
		0 ignored issues – show Deprecated Code introduced 2020-06-28 14:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Doctrine\DBAL\Driver\ResultStatement::fetchAll()` has been deprecated with message: Use fetchAllNumeric(), fetchAllAssociative() or fetchFirstColumn() instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
121		->fetchAll(PDO::FETCH_ASSOC);
122		}
123		}
124

doctrine / DoctrineBundle

Issues (220)

Security Analysis not enabled

Controller/ProfilerController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like