doctrine /
DoctrineBundle
These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
| 1 | <?php |
||
| 2 | |||
| 3 | namespace Doctrine\Bundle\DoctrineBundle; |
||
| 4 | |||
| 5 | use Doctrine\ORM\ORMException; |
||
| 6 | use Psr\Container\ContainerInterface; |
||
| 7 | use Symfony\Bridge\Doctrine\ManagerRegistry; |
||
| 8 | |||
| 9 | /** |
||
| 10 | * References all Doctrine connections and entity managers in a given Container. |
||
| 11 | */ |
||
| 12 | class Registry extends ManagerRegistry |
||
| 13 | { |
||
| 14 | /** |
||
| 15 | * @param string[] $connections |
||
| 16 | * @param string[] $entityManagers |
||
| 17 | * @param string $defaultConnection |
||
| 18 | * @param string $defaultEntityManager |
||
| 19 | */ |
||
| 20 | public function __construct(ContainerInterface $container, array $connections, array $entityManagers, $defaultConnection, $defaultEntityManager) |
||
| 21 | { |
||
| 22 | $this->container = $container; |
||
|
0 ignored issues
–
show
|
|||
| 23 | |||
| 24 | parent::__construct('ORM', $connections, $entityManagers, $defaultConnection, $defaultEntityManager, 'Doctrine\ORM\Proxy\Proxy'); |
||
| 25 | } |
||
| 26 | |||
| 27 | /** |
||
| 28 | * Resolves a registered namespace alias to the full namespace. |
||
| 29 | * |
||
| 30 | * This method looks for the alias in all registered entity managers. |
||
| 31 | * |
||
| 32 | * @see Configuration::getEntityNamespace |
||
| 33 | * |
||
| 34 | * @param string $alias The alias |
||
| 35 | * |
||
| 36 | * @return string The full namespace |
||
| 37 | */ |
||
| 38 | public function getAliasNamespace($alias) |
||
| 39 | { |
||
| 40 | foreach (array_keys($this->getManagers()) as $name) { |
||
| 41 | try { |
||
| 42 | return $this->getManager($name)->getConfiguration()->getEntityNamespace($alias); |
||
|
0 ignored issues
–
show
It seems like you code against a concrete implementation and not the interface
Doctrine\Common\Persistence\ObjectManager as the method getConfiguration() does only exist in the following implementations of said interface: Doctrine\ORM\Decorator\EntityManagerDecorator, Doctrine\ORM\EntityManager.
Let’s take a look at an example: interface User
{
/** @return string */
public function getPassword();
}
class MyUser implements User
{
public function getPassword()
{
// return something
}
public function getDisplayName()
{
// return some name.
}
}
class AuthSystem
{
public function authenticate(User $user)
{
$this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
// do something.
}
}
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types
inside the if block in such a case.
Loading history...
|
|||
| 43 | } catch (ORMException $e) { |
||
|
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
|
|||
| 44 | } |
||
| 45 | } |
||
| 46 | |||
| 47 | throw ORMException::unknownEntityNamespace($alias); |
||
| 48 | } |
||
| 49 | } |
||
| 50 |
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly.
Either this assignment is in error or an instanceof check should be added for that assignment.