| Conditions | 20 |
| Paths | 484 |
| Total Lines | 123 |
| Code Lines | 74 |
| Lines | 21 |
| Ratio | 17.07 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 44 | public function collect(Request $request, Response $response, \Exception $exception = null) |
||
| 45 | { |
||
| 46 | parent::collect($request, $response, $exception); |
||
| 47 | |||
| 48 | $errors = array(); |
||
| 49 | $entities = array(); |
||
| 50 | $caches = array( |
||
| 51 | 'enabled' => false, |
||
| 52 | 'log_enabled' => false, |
||
| 53 | 'counts' => array( |
||
| 54 | 'puts' => 0, |
||
| 55 | 'hits' => 0, |
||
| 56 | 'misses' => 0, |
||
| 57 | ), |
||
| 58 | 'regions' => array( |
||
| 59 | 'puts' => array(), |
||
| 60 | 'hits' => array(), |
||
| 61 | 'misses' => array(), |
||
| 62 | ), |
||
| 63 | ); |
||
| 64 | |||
| 65 | foreach ($this->registry->getManagers() as $name => $em) { |
||
| 66 | $entities[$name] = array(); |
||
| 67 | /** @var $factory \Doctrine\ORM\Mapping\ClassMetadataFactory */ |
||
| 68 | $factory = $em->getMetadataFactory(); |
||
| 69 | $validator = new SchemaValidator($em); |
||
| 70 | |||
| 71 | /** @var $class \Doctrine\ORM\Mapping\ClassMetadataInfo */ |
||
| 72 | foreach ($factory->getLoadedMetadata() as $class) { |
||
| 73 | if (!isset($entities[$name][$class->getName()])) { |
||
| 74 | $classErrors = $validator->validateClass($class); |
||
| 75 | $entities[$name][$class->getName()] = $class->getName(); |
||
| 76 | |||
| 77 | if (!empty($classErrors)) { |
||
| 78 | $errors[$name][$class->getName()] = $classErrors; |
||
| 79 | } |
||
| 80 | } |
||
| 81 | } |
||
| 82 | |||
| 83 | if (version_compare(Version::VERSION, '2.5.0-DEV') < 0) { |
||
| 84 | continue; |
||
| 85 | } |
||
| 86 | |||
| 87 | /** @var $emConfig \Doctrine\ORM\Configuration */ |
||
| 88 | $emConfig = $em->getConfiguration(); |
||
| 89 | $slcEnabled = $emConfig->isSecondLevelCacheEnabled(); |
||
| 90 | |||
| 91 | if (!$slcEnabled) { |
||
| 92 | continue; |
||
| 93 | } |
||
| 94 | |||
| 95 | $caches['enabled'] = true; |
||
| 96 | |||
| 97 | /** @var $cacheConfiguration \Doctrine\ORM\Cache\CacheConfiguration */ |
||
| 98 | /** @var $cacheLoggerChain \Doctrine\ORM\Cache\Logging\CacheLoggerChain */ |
||
| 99 | $cacheConfiguration = $emConfig->getSecondLevelCacheConfiguration(); |
||
| 100 | $cacheLoggerChain = $cacheConfiguration->getCacheLogger(); |
||
| 101 | |||
| 102 | if (!$cacheLoggerChain || !$cacheLoggerChain->getLogger('statistics')) { |
||
| 103 | continue; |
||
| 104 | } |
||
| 105 | |||
| 106 | /** @var $cacheLoggerStats \Doctrine\ORM\Cache\Logging\StatisticsCacheLogger */ |
||
| 107 | $cacheLoggerStats = $cacheLoggerChain->getLogger('statistics'); |
||
| 108 | $caches['log_enabled'] = true; |
||
| 109 | |||
| 110 | $caches['counts']['puts'] += $cacheLoggerStats->getPutCount(); |
||
| 111 | $caches['counts']['hits'] += $cacheLoggerStats->getHitCount(); |
||
| 112 | $caches['counts']['misses'] += $cacheLoggerStats->getMissCount(); |
||
| 113 | |||
| 114 | View Code Duplication | foreach ($cacheLoggerStats->getRegionsPut() as $key => $value) { |
|
| 115 | if (!isset($caches['regions']['puts'][$key])) { |
||
| 116 | $caches['regions']['puts'][$key] = 0; |
||
| 117 | } |
||
| 118 | |||
| 119 | $caches['regions']['puts'][$key] += $value; |
||
| 120 | } |
||
| 121 | |||
| 122 | View Code Duplication | foreach ($cacheLoggerStats->getRegionsHit() as $key => $value) { |
|
| 123 | if (!isset($caches['regions']['hits'][$key])) { |
||
| 124 | $caches['regions']['hits'][$key] = 0; |
||
| 125 | } |
||
| 126 | |||
| 127 | $caches['regions']['hits'][$key] += $value; |
||
| 128 | } |
||
| 129 | |||
| 130 | View Code Duplication | foreach ($cacheLoggerStats->getRegionsMiss() as $key => $value) { |
|
| 131 | if (!isset($caches['regions']['misses'][$key])) { |
||
| 132 | $caches['regions']['misses'][$key] = 0; |
||
| 133 | } |
||
| 134 | |||
| 135 | $caches['regions']['misses'][$key] += $value; |
||
| 136 | } |
||
| 137 | } |
||
| 138 | |||
| 139 | $groupedQueries = array(); |
||
| 140 | foreach ($this->data['queries'] as $connection => $queries) { |
||
| 141 | $connectionGroupedQueries = array(); |
||
| 142 | foreach ($queries as $i => $query) { |
||
| 143 | $key = $query['sql']; |
||
| 144 | if (!isset($connectionGroupedQueries[$key])) { |
||
| 145 | $connectionGroupedQueries[$key] = $query; |
||
| 146 | $connectionGroupedQueries[$key]['executionMS'] = 0; |
||
| 147 | $connectionGroupedQueries[$key]['count'] = 0; |
||
| 148 | $connectionGroupedQueries[$key]['i'] = $i; // "Explain query" relies on query index in 'queries'. |
||
| 149 | } |
||
| 150 | $connectionGroupedQueries[$key]['executionMS'] += $query['executionMS']; |
||
| 151 | $connectionGroupedQueries[$key]['count']++; |
||
| 152 | } |
||
| 153 | usort($connectionGroupedQueries, function ($a, $b) { |
||
| 154 | if ($a['executionMS'] === $b['executionMS']) { |
||
| 155 | return 0; |
||
| 156 | } |
||
| 157 | return ($a['executionMS'] < $b['executionMS']) ? 1 : -1; |
||
| 158 | }); |
||
| 159 | $groupedQueries[$connection] = $connectionGroupedQueries; |
||
| 160 | } |
||
| 161 | |||
| 162 | $this->data['entities'] = $entities; |
||
| 163 | $this->data['errors'] = $errors; |
||
| 164 | $this->data['caches'] = $caches; |
||
| 165 | $this->data['groupedQueries'] = $groupedQueries; |
||
| 166 | } |
||
| 167 | |||
| 222 |