ContainerRepositoryFactory::__construct() - Code Metrics - Inspection of "Adding option to allow repositories to be fetched..." - doctrine/DoctrineBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#727)

unknown

created 2017-10-29 01:22 UTC

ContainerRepositoryFactory::__construct() A

↳ Parent: ContainerRepositoryFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php

/*
 * This file is part of the Doctrine Bundle
 *
 * The code was originally distributed inside the Symfony framework.
 *
 * (c) Fabien Potencier <[email protected]>
 * (c) Doctrine Project, Benjamin Eberlei <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Doctrine\Bundle\DoctrineBundle\Repository;

use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\Repository\RepositoryFactory;
use Psr\Container\ContainerInterface;
use Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\ServiceRepositoryCompilerPass;

/**
 * A custom repository factory that fetches repositories from the container.
 *
 * @author Ryan Weaver <[email protected]>
 */
class ContainerRepositoryFactory implements RepositoryFactory
{
    private $managedRepositories = [];

    private $container;

    /**
     * @param ContainerInterface $container A service locator containing the repositories
     */
    public function __construct(ContainerInterface $container)
    {
        $this->container = $container;
    }

    /**
     * {@inheritDoc}
     */
    public function getRepository(EntityManagerInterface $entityManager, $entityName)
    {
        $metadata = $entityManager->getClassMetadata($entityName);
        $repositoryServiceId = $metadata->customRepositoryClassName;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        if (null !== $repositoryServiceId) {
            if (!$this->container->has($metadata->customRepositoryClassName)) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                throw new \RuntimeException(sprintf('Could not find the repository service for the "%s" entity. Make sure the "%s" service exists and is tagged with "%s".', $entityName, $repositoryServiceId, ServiceRepositoryCompilerPass::REPOSITORY_SERVICE_TAG));
            }

            $repository = $this->container->get($metadata->customRepositoryClassName);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

            if (!$repository instanceof EntityRepository) {
                throw new \RuntimeException(sprintf('The service "%s" must extend EntityRepository (or a base class, like ServiceEntityRepository).', $repositoryServiceId));
            }

            return $repository;
        }

        $repositoryHash = $metadata->getName() . spl_object_hash($entityManager);
        if (isset($this->managedRepositories[$repositoryHash])) {
            return $this->managedRepositories[$repositoryHash];
        }

        $repositoryClassName = $entityManager->getConfiguration()->getDefaultRepositoryClassName();

        return $this->managedRepositories[$repositoryHash] = new $repositoryClassName($entityManager, $metadata);
    }
}


1			<?php
2
3			/*
4			* This file is part of the Doctrine Bundle
5			*
6			* The code was originally distributed inside the Symfony framework.
7			*
8			* (c) Fabien Potencier <[email protected]>
9			* (c) Doctrine Project, Benjamin Eberlei <[email protected]>
10			*
11			* For the full copyright and license information, please view the LICENSE
12			* file that was distributed with this source code.
13			*/
14
15			namespace Doctrine\Bundle\DoctrineBundle\Repository;
16
17			use Doctrine\ORM\EntityManagerInterface;
18			use Doctrine\ORM\EntityRepository;
19			use Doctrine\ORM\Repository\RepositoryFactory;
20			use Psr\Container\ContainerInterface;
21			use Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\ServiceRepositoryCompilerPass;
22
23			/**
24			* A custom repository factory that fetches repositories from the container.
25			*
26			* @author Ryan Weaver <[email protected]>
27			*/
28			class ContainerRepositoryFactory implements RepositoryFactory
29			{
30			private $managedRepositories = [];
31
32			private $container;
33
34			/**
35			* @param ContainerInterface $container A service locator containing the repositories
36			*/
37			public function __construct(ContainerInterface $container)
38			{
39			$this->container = $container;
40			}
41
42			/**
43			* {@inheritDoc}
44			*/
45			public function getRepository(EntityManagerInterface $entityManager, $entityName)
46			{
47			$metadata = $entityManager->getClassMetadata($entityName);
48			$repositoryServiceId = $metadata->customRepositoryClassName;
			0 ignored issues – show Bug introduced 2017-10-29 01:24 UTC by Report Bug Copy Issue Report Accessing `customRepositoryClassName` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
49
50			if (null !== $repositoryServiceId) {
51			if (!$this->container->has($metadata->customRepositoryClassName)) {
			0 ignored issues – show Bug introduced 2017-10-29 01:24 UTC by Report Bug Copy Issue Report Accessing `customRepositoryClassName` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
52			throw new \RuntimeException(sprintf('Could not find the repository service for the "%s" entity. Make sure the "%s" service exists and is tagged with "%s".', $entityName, $repositoryServiceId, ServiceRepositoryCompilerPass::REPOSITORY_SERVICE_TAG));
53			}
54
55			$repository = $this->container->get($metadata->customRepositoryClassName);
			0 ignored issues – show Bug introduced 2017-10-29 01:24 UTC by Report Bug Copy Issue Report Accessing `customRepositoryClassName` on the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
56
57			if (!$repository instanceof EntityRepository) {
58			throw new \RuntimeException(sprintf('The service "%s" must extend EntityRepository (or a base class, like ServiceEntityRepository).', $repositoryServiceId));
59			}
60
61			return $repository;
62			}
63
64			$repositoryHash = $metadata->getName() . spl_object_hash($entityManager);
65			if (isset($this->managedRepositories[$repositoryHash])) {
66			return $this->managedRepositories[$repositoryHash];
67			}
68
69			$repositoryClassName = $entityManager->getConfiguration()->getDefaultRepositoryClassName();
70
71			return $this->managedRepositories[$repositoryHash] = new $repositoryClassName($entityManager, $metadata);
72			}
73			}
74

doctrine / DoctrineBundle

Pull Request — master (#727)

ContainerRepositoryFactory::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like